[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/56
  
many thanks!


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...

2018-02-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/56


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/56
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/30/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/56
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/36/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread jaikiran
Github user jaikiran commented on the issue:

https://github.com/apache/ant/pull/56
  
this is ok to test


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/56
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/56
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...

2018-02-01 Thread reudismam
GitHub user reudismam opened a pull request:

https://github.com/apache/ant/pull/56

Use equals method of a string literal to prevent NPE and isEmpty() me…

…thod instead of comparing a String object with an empty string.

This change has already been done for some locations in the commit:

https://github.com/apache/ant/commit/b7d1e9bde44cb8e5233d6e70bb96e14cbb2f3e2d

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/reudismam/ant equals

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit debf404d170cfd771a517e9c5b408bc9735e2f70
Author: reudismam 
Date:   2018-02-01T17:03:19Z

Use equals method of a string literal to prevent NPE and isEmpty() method 
instead of comparing a String object with an empty string.




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/56
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #56: Use equals method of a string literal to prevent NPE and isEm...

2018-02-01 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/56
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #65: IVY-1485 Ensure dependency is applicable to all configura...

2018-02-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/65
  
@jaikiran please let me know if you did some addition coding, otherwise I 
hope you would rather focus on JUnit 5 😄


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #65: IVY-1485 Ensure dependency is applicable to all co...

2018-02-01 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/65

IVY-1485 Ensure dependency is applicable to all configurations

I adopted a patch by @tbingaman

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy ivy-1485

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #65


commit fbac59fbbd6f7c7fa8aa99597f8804211d05bd26
Author: twogee 
Date:   2018-02-01T13:54:30Z

IVY-1485 Ensure dependency is applicable to all configurations




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/64
  
Looking at 
[examples](https://github.com/apache/httpcomponents-client/blob/4.6.x/httpclient/src/examples/org/apache/http/examples/client/ClientPreemptiveDigestAuthentication.java),
 digest authentication uses the same cache, only sets a different scheme.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/64
  
I have noticed that. Perhaps it's enough to document that preemptive 
authentication only works with basic scheme.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread AurelienLourot
Github user AurelienLourot commented on the issue:

https://github.com/apache/ant-ivy/pull/64
  
Note that I didn't push it upstream because of this open point: 
https://github.com/tt-gf/ant-ivy/pull/2#discussion_r135625987

So this might break some authentication schemes, I'm not really sure.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/64

IVY-1280 Support preemptive authentication

I adopted a patch by @AurelienLourot

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy ivy-1280

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit 2422f51ffad184465a5a9bacdc92e44f7f4a756a
Author: twogee 
Date:   2018-02-01T10:40:10Z

IVY-1280 Support preemptive authentication




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org