Re: ant git commit: Check spelling

2018-09-10 Thread Jaikiran Pai
Things haven't changed (nor do I expect any changes anymore). To say the
least - it's followed the same pattern:

- do changes like these

- when requested not to do such changes, argue over it and move it to
some abstract discussion

- then give an impression it won't be repeated

- few days down the line push changes like these and repeat the whole
cycle again.

Although I stay silent with these commits these days it's because I have
nothing good or new to say about this behaviour and am fully exhausted
with this exercise to the extent that I just delete such commit
notifications instead of reviewing them, to avoid it ruining any energy
I might have to contribute anything in my spare time.

Committer rights is a privilege as well as a responsibility, but this
behaviour is nothing but an abuse of it and no different than being a troll.

-Jaikiran


On 10/09/18 5:12 AM, Nicolas Lalevée wrote:
> I have been away from the project out of boredom. Still curious, I came to 
> read some emails. It seems things didn’t changed much: yet another unreadable 
> commit with a log which doesn’t indicate what it actually do.
>
>
>> Le 9 sept. 2018 à 09:09, gin...@apache.org a écrit :
>>
>> Repository: ant
>> Updated Branches:
>>  refs/heads/master fde6b0e94 -> 54b6df2f4
>>
>>
>> Check spelling
>>
>> Project: http://git-wip-us.apache.org/repos/asf/ant/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/54b6df2f
>> Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/54b6df2f
>> Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/54b6df2f
>>
>> Branch: refs/heads/master
>> Commit: 54b6df2f44c5cb4f9573f99330c2d2908f1bf506
>> Parents: fde6b0e
>> Author: Gintas Grigelionis 
>> Authored: Sat Sep 8 22:12:24 2018 +0200
>> Committer: Gintas Grigelionis 
>> Committed: Sun Sep 9 09:07:18 2018 +0200
>>
>> --
>> .../checkstyle-frames-sortby-check.xsl  | 194 +--
>> src/etc/jdepend-frames.xsl  |  18 +-
>> src/etc/jdepend.xsl |  48 +++--
>> src/etc/testcases/taskdefs/exec/exec.xml|   4 +-
>> .../taskdefs/optional/unix/symlink.xml  |  78 
>> .../optional/xml/endpiece-noSchema-invalid.xml  |   9 +-
>> .../taskdefs/optional/xml/endpiece-noSchema.xml |   7 +-
>> src/etc/testcases/types/assertions.xml  | 178 +
>> src/etc/testcases/types/selectors.xml   | 104 +-
>> src/main/org/apache/tools/ant/Diagnostics.java  |   2 +-
>> src/main/org/apache/tools/ant/taskdefs/Ant.java |   2 +-
>> .../org/apache/tools/ant/taskdefs/Checksum.java |   2 +-
>> .../org/apache/tools/ant/taskdefs/Exec.java |   2 +-
>> .../org/apache/tools/ant/taskdefs/SignJar.java  |   2 +-
>> src/main/org/apache/tools/ant/taskdefs/Zip.java |   2 +-
>> .../ant/taskdefs/condition/IsReachable.java |   4 +-
>> .../optional/ejb/GenericDeploymentTool.java |   4 +-
>> .../optional/ejb/JonasDeploymentTool.java   |   4 +-
>> .../tools/ant/taskdefs/optional/jsp/WLJspc.java |   2 +-
>> .../junitlauncher/JUnitLauncherTask.java|   2 +-
>> .../optional/junitlauncher/TestRequest.java |   8 +-
>> .../tools/ant/taskdefs/optional/net/FTP.java|   4 +-
>> .../optional/net/FTPTaskMirrorImpl.java |   4 +-
>> .../tools/ant/taskdefs/optional/vss/MSVSS.java  |   2 +-
>> .../ant/taskdefs/optional/vss/MSVSSCHECKIN.java |   2 +-
>> .../org/apache/tools/ant/types/XMLCatalog.java  |   2 +-
>> .../org/apache/tools/ant/util/FileUtils.java|   2 +-
>> .../org/apache/tools/ant/util/ProxySetup.java   |   2 +-
>> .../org/apache/tools/zip/ZipOutputStream.java   |   4 +-
>> src/script/antenv.cmd   |   2 +-
>> src/script/envset.cmd   |   2 +-
>> src/tests/antunit/taskdefs/echoxml-test.xml |   2 +-
>> .../apache/tools/ant/taskdefs/UnzipTest.java|   2 +-
>> .../ant/taskdefs/optional/TraXLiaisonTest.java  |   2 +-
>> .../tools/ant/util/ReaderInputStreamTest.java   |   4 +-
>> 35 files changed, 350 insertions(+), 362 deletions(-)
>> --
>>
>>
>> http://git-wip-us.apache.org/repos/asf/ant/blob/54b6df2f/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl
>> --
>> diff --git a/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl 
>> b/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl
>> index 060f878..1f02b90 100644
>> --- a/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl
>> +++ b/src/etc/checkstyle/checkstyle-frames-sortby-check.xsl
>> @@ -22,7 +22,7 @@
>> -->
>>
>> 
>> -
>> +
>>
>> 
>> 
>> @@ -43,7 +43,7 @@
>> 
>> 
>>
>> -
>> +
>> 
>> 
>> 
>> @@ -76,15 +76,15 @@
>>
>>
>> 
>> 
>>
>>
>>
>>  
>> +Generates the navigation bar.
>> +-->
>> 
>> 
>>

Re: ant-ivy git commit: Update the release notes

2018-09-10 Thread Jaikiran Pai
Hi Maarten,

Agreed - the change(s) should be done taking into account any existing
caches (from previous version of Ivy). As of now, I have reverted my
changes which had introduced the test failures. To fix properly, it will
require a couple of hours of dedicated work to make sure all cases are
covered. However, I haven't been able to focus on it at a stretch and
would like to finish off some pending junitlauncher task work in Ant
project, before I can get to this. Hence I decided to undo my changes
for now and leave it in a state as of our latest released version.

-Jaikiran


On 29/08/18 8:27 PM, Maarten Coene wrote:
> Without knowing the details of the change, one thing we should take care 
> about is that older Ivy versions should still be able to read that property 
> properly.
> Maarten
>
>Op woensdag 29 augustus 2018 16:48:01 CEST schreef Gintautas Grigelionis 
> :  
>  
>  I like the idea, though. One thing that should be investigated further is
> places where location is obtained by getResource().getName()
> AFAICS that happens in CacheResolver (deprecated), BasicResolver (where
> also a Resource is constructed from location), and
> DefaultRepositoryCacheManager. There's no uniformity in
> Resource-implementing classes either, sometimes getName() works on an URI,
> sometimes a path string.
>
> Gintas
>
> On Wed, 29 Aug 2018 at 08:34, Jaikiran Pai  wrote:
>
>> More of a FYI - I'm still not convinced that my fix for this handles all
>> the necessary cases (looks like the ArtifactOrigin#location gets used in
>> various different ways), so I may either revert back my changes or
>> decide to change it in a different way. So right now, in its current
>> form, my changes aren't a fix.
>>
>> -Jaikiran
>>
>>
>> On 29/08/18 11:34 AM, gin...@apache.org wrote:
>>> Repository: ant-ivy
>>> Updated Branches:
>>>   refs/heads/master d976a4a27 -> fd81f4461
>>>
>>>
>>> Update the release notes
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/fd81f446
>>> Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/fd81f446
>>> Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/fd81f446
>>>
>>> Branch: refs/heads/master
>>> Commit: fd81f44619b05a176ecbf4ff1499d64b39251520
>>> Parents: d976a4a
>>> Author: Gintas Grigelionis 
>>> Authored: Wed Aug 29 08:03:13 2018 +0200
>>> Committer: Gintas Grigelionis 
>>> Committed: Wed Aug 29 08:05:12 2018 +0200
>>>
>>> --
>>>   asciidoc/release-notes.adoc | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>> --
>>>
>>>
>>>
>> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/fd81f446/asciidoc/release-notes.adoc
>>> --
>>> diff --git a/asciidoc/release-notes.adoc b/asciidoc/release-notes.adoc
>>> index cc53bb3..efa7057 100644
>>> --- a/asciidoc/release-notes.adoc
>>> +++ b/asciidoc/release-notes.adoc
>>> @@ -85,6 +85,7 @@ For details about the following changes, check our
>> JIRA install at link:https://
>>>   - FIX: Don't throw a CircularDependencyException when parsing an import
>> scoped dependency in dependencyManagement section of a pom (jira:IVY-1588[])
>>>   - FIX: Respect exclude regardless of resolution order (jira:IVY-1486[])
>> (thanks to David Turner)
>>>   - FIX: ModuleDescriptorMemoryCache didn't detect outdated entries when
>> Ivy file was updated in the cache by another process
>>> +- FIX: Store ArtifactOrigin's location as a URL
>>>
>>>   - IMPROVEMENT: Throw an IllegalStateException when retrieving the
>> resolutionCacheRoot on the DefaultResolutionCacheManager if the basedir (or
>> IvySettings) is not set (jira:IVY-1482[])
>>>   - IMPROVEMENT: Optimization: limit the revision numbers scanned if
>> revision prefix is specified (Thanks to Ernestas Vaiciukeviius)
>>> @@ -181,7 +182,6 @@ Here is the list of people who have contributed
>> source code and documentation up
>>>   * Tobias Himstedt
>>>   * Achim Huegen
>>>   * Pierre Hgnestrand
>>> -* Ilya
>>>   * Matt Inger
>>>   * Anders Jacobsson
>>>   * Anders Janmyr
>>> @@ -196,6 +196,7 @@ Here is the list of people who have contributed
>> source code and documentation up
>>>   * Sebastian Krueger
>>>   * Thomas Kurpick
>>>   * Costin Leau
>>> +* Ilya Leoshkevich
>>>   * Tat Leung
>>>   * Antoine Levy-Lambert
>>>   * Tony Likhite
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>>
>>
>   


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: JDK 12 & JMC 7.0.0 Early Access builds are available

2018-09-10 Thread Rory O'Donnell

Many thanks Jaikiran!


On 10/09/2018 06:39, Jaikiran Pai wrote:

Hi Rory,


On 07/09/18 2:58 PM, Rory O'Donnell wrote:


Can you confirm the fix in JDK 12 b09, thanks ?


*FOSS bug fixes in recent builds.*

  * *Apache Ant -
**JDK-8209965**(b09)*

I gave the JDK 12 EA version a try:

java -version
openjdk version "12-ea" 2019-03-19
OpenJDK Runtime Environment 19.3 (build 12-ea+10)
OpenJDK 64-Bit Server VM 19.3 (build 12-ea+10, mixed mode)

and can confirm that this issue is indeed fixed in that version.

-Jaikiran


--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org