Re: Jenkins-Builds failing

2018-07-24 Thread Jaikiran Pai
I've committed a change[1] to handle this in the part where we trigger the tutorial run. [1] https://github.com/apache/ant-ivy/commit/43ddccb859b94c79350ece7520af4c991c2bb5e6 -Jaikiran On 24/07/18 10:53 PM, Gintautas Grigelionis wrote: > Thank you for all attempts, the failure occurs in

Re: Jenkins-Builds failing

2018-07-20 Thread Jaikiran Pai
permissions or if it's something that changed with the recent Jenkins upgrade. -Jaikiran On 20/07/18 1:34 PM, Gintautas Grigelionis wrote: > My hypothesis is that Java 7 must have TLS version forced to 1.2 in order > to avoid protocol errors when downloading new binaries from Maven Central >

Re: Jenkins-Builds failing

2018-07-20 Thread Jaikiran Pai
Haven't checked the job, but why is this system property required to be set? -Jaikiran On 20/07/18 12:51 AM, Gintautas Grigelionis wrote: > I'd like to add a Java option to Ivy builds -Dhttps.protocols=TLSv1.2 but I > get > This job's current authorization strategy does not perm

[GitHub] ant issue #65: Update manual for subject alternative name attribute of genke...

2018-07-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/65 I picked the commit which updated just the documentation and merged it to upstream. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task

2018-07-15 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/64 @jnsnkrllive I've merged this into 1.9.x as well as master branches. Thank you for the PR. I've also included your name "Karl Jansen" in our contributors list. If you like to use a different

[ANNOUNCE] Apache Ant 1.9.13 and 1.10.5 Released

2018-07-15 Thread Jaikiran Pai
bug reports, patches, or suggestions for improvement, see the Apache Ant website https://ant.apache.org/ -Jaikiran Pai, on behalf of the Apache Ant community signature.asc Description: OpenPGP digital signature

[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/64 Thank you @jnsnkrllive. This now looks fine to me. I'll merge this later tonight/tomorrow, once our currently in-progress Ant release(s) are officially announced

[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/64#discussion_r202287386 --- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java --- @@ -413,6 +429,16 @@ public void execute() throws BuildException

[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task

2018-07-12 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/64#discussion_r202054728 --- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java --- @@ -413,6 +429,16 @@ public void execute() throws BuildException

[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task

2018-07-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/64 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

Re: [VOTE] Release Ant 1.10.5 based on RC1

2018-07-11 Thread Jaikiran Pai
feature of Java task works:                 A.java: public class A {     public static void main(final String[] args) throws Exception {         System.out.println("Hello Ant 1.10.5!");     } } Worked fine. -Jaikiran On 10/07/18 3:25 PM, Stefan Bodewig wrote: Hi all I've crea

Re: [VOTE] Release Ant 1.9.13 based on RC1

2018-07-11 Thread Jaikiran Pai
with this new version (and fails with previous 1.9.x released version) to verify the https://bz.apache.org/bugzilla/show_bug.cgi?id=62164 issue:             src="http://downloads.sourceforge.net/easymock/easymock-3.2.zip; dest="${basedir}/downloaded/"/>     -Jaikiran O

Re: ant git commit: Unbreak tests

2018-07-07 Thread Jaikiran Pai
to this. -Jaikiran On 06/07/18 5:19 PM, j...@apache.org wrote: Hello all Just for your info, please take into consideration for a rollback or not descision (I am neither happy with the commit, nor happy with a rollback and therefore am 0 on rollback or not): I have written a small checker

Re: ant git commit: Unbreak tests

2018-07-07 Thread Jaikiran Pai
etween the trailing whitespace, force updated merge commits on master. Reviewed this comparison diff and it looked fine and correct to me. Pushed this state to "master" branch of upstream repo. At this point, these branches are in a state where they can be used for regular developmen

Re: ant git commit: Unbreak tests

2018-07-06 Thread Jaikiran Pai
On 05/07/18 2:42 PM, Stefan Bodewig wrote: On 2018-07-05, Jaikiran Pai wrote: I personally believe that reviewing these meaningless changes is a waste of time and energy. I'm in favour of rolling back the entire commit set if that's what it takes. +1 although reverting the commits in both

Re: ant git commit: Enhance the Java task to allow single file source program execution, a feature, introduced in Java 11

2018-07-05 Thread Jaikiran Pai
. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant git commit: Unbreak tests

2018-07-04 Thread Jaikiran Pai
layground and forcing it on the rest of the community. At this point, I personally believe that reviewing these meaningless changes is a waste of time and energy. I'm in favour of rolling back the entire commit set if that's what it takes. -Jaikiran

Re: Testing IvyDE

2018-07-04 Thread Jaikiran Pai
On 01/07/18 6:35 PM, Nicolas Lalevée wrote: Le 28 juin 2018 à 08:41, Jaikiran Pai a écrit : On 27/06/18 10:12 PM, Nicolas Lalevée wrote: Since there is a work around (hitting refresh after resolve) and it is an RC, we could ship it like that and fix it later. But due to the automatic

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-03 Thread Jaikiran Pai
someone else sees any issues, I think we can go ahead and do the release that you had planned for. -Jaikiran On 03/07/18 1:16 PM, Stefan Bodewig wrote: On 2018-07-02, Stefan Bodewig wrote: On 2018-07-02, Jaikiran Pai wrote: I just checked the commits related to this and it looks mostly correct

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-02 Thread Jaikiran Pai
not even be valid. I'm going to build the latest changes of Ant give it a try against a bunch of my theoretical use cases and see if my suspicions are really valid or not. [1] https://github.com/apache/ant/commit/6a41d62cb9ab4e640b72cb4de42a6c211dea645d -Jaikiran On 01/07/18 2:57 PM

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Jaikiran Pai
On 28/06/18 8:37 PM, Stefan Bodewig wrote: On 2018-06-28, Jaikiran Pai wrote: However, looking at the FileUtils#isLeadingPath(...) implementation, I wonder why it even uses normalize. Given that the goal of that API (as stated in the javadoc) is to figure out if one path leads the other

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Jaikiran Pai
adingPath API solely based on the names of that passed files rather than their actual resolved location on the filesystem? I haven't yet tried it out myself to have a more clearer understanding of how it will end up behaving in the context that we use this API. -Jaikiran On 28/06/18 7:17

[CANCELLED]Re: [VOTE] Release 2.3.0-rc1 of Apache IvyDE

2018-06-28 Thread Jaikiran Pai
This vote is now officially cancelledfor the reasons noted below. -Jaikiran On 28/06/18 12:11 PM, Jaikiran Pai wrote: On 27/06/18 10:12 PM, Nicolas Lalevée wrote: Since there is a work around (hitting refresh after resolve) and it is an RC, we could ship it like that and fix it later

Re: [VOTE] Release 2.3.0-rc1 of Apache IvyDE

2018-06-28 Thread Jaikiran Pai
I'll vote a -1 on this now. I know we have gone through 3 voting rounds for this release, so thank you everyone for being patient and testing out the binaries. I'll file this issue in JIRA and hopefully spend some time in Eclipse this weekend to try and sort this out. -Jaikiran

Re: [Bug 33169] KIndly update the date feature

2018-06-27 Thread Jaikiran Pai
Just curious about our bugzilla infrastructure - do random users get to change the content of these bugs, even if they aren't the ones who reported the issue? -Jaikiran On 28/06/18 9:05 AM, bugzi...@apache.org wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=33169 Ranjeet Mane

[VOTE] Release 2.3.0-rc1 of Apache IvyDE

2018-06-24 Thread Jaikiran Pai
: Support for storing credentials securely Do you vote for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Release AntUnit 1.4 based on RC3

2018-06-24 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Checked some of the docs/manual - Ran a simple project using this released version - Checked the NOTICE file All looks fine. -Jaikiran On 22/06/18 11:02 AM, Stefan Bodewig wrote: Hi all this is the third RC for AntUnit 1.4 with the problems Gintas

Re: [ANN] Apache Ant 1.9.12 and 1.10.4 Released

2018-06-24 Thread Jaikiran Pai
Thank you for running this release, Stefan. -Jaikiran On 22/06/18 9:09 PM, Stefan Bodewig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Ant Team is pleased to announce the releases of Apache Ant 1.9.12 and 1.10.4. Apache Ant is a Java library and command-line tool

Re: [VOTE] Release Ant 1.10.4 based on RC1

2018-06-22 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Checked some docs in the manual - Used this new version to run builds against existing internal Ant projects. All went fine. -Jaikiran On 19/06/18 12:38 PM, Stefan Bodewig wrote: Hi all I've created a new release candidate for 1.10.4 with a bunch

Re: [CANCELLED] Release AntUnit 1.4 Based on RC2

2018-06-21 Thread Jaikiran Pai
I think moving to Ant 1.8.x would be a better option, given the relatively low chances of it causing any issues. -Jaikiran On 21/06/18 2:47 PM, Stefan Bodewig wrote: On 2018-06-21, Gintautas Grigelionis wrote: POM template has inconsistent Ant versions, 1.7.1 in compile scope and 1.8.1

Re: [VOTE] Release Ant 1.9.12 based on RC1

2018-06-19 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Installed locally, checked the NOTICE and some tasks' manuals. Look fine. - Built some random existing Ant based projects using this new version. All went fine. -Jaikiran On 19/06/18 12:38 PM, Stefan Bodewig wrote: Hi all I've created a new release

Re: .git(modules|attributes|ignore) files in source dists?

2018-06-19 Thread Jaikiran Pai
hing about files like .gitignore being packaged into the archive. So I looked into the generated source tar and those are indeed present. I actually can't think of a reason why we should exclude these files. [1] https://github.com/apache/ant-ivyde/blob/master/build.xml -Jaikiran On 19/06/

Re: [VOTE] Release AntUnit 1.4 Based on RC1

2018-06-19 Thread Jaikiran Pai
tml repo link typo to be a blocker. I don't know if the copyright year issue should warrant a new vote. If it doesn't, then it's a +1 for this release from me. -Jaikiran On 19/06/18 1:27 AM, Stefan Bodewig wrote: On 2018-06-18, Stefan Bodewig wrote: Hi all there haven't been big chan

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Given the nature of this issue, I'm cancelling this vote. A new one will be initiated this week. -Jaikiran On 19/06/18 5:05 AM, Jaikiran Pai wrote: Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll also include

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll also include the sha and rev in a newer vote and update our release instructions. -Jaikiran On Tuesday, June 19, 2018, Nicolas Lalevée wrote: > First, thank you v

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
+1. Tried the installation and used a basic Ivy based project for dependency resolution. Also checked some of the Ivy plugin screens to make sure all is fine. -Jaikiran On 17/06/18 12:15 PM, Jaikiran Pai wrote: This is a newer vote mail that I'm initiating for the 2.3.0-rc1 release

Re: thinking about new releases

2018-06-18 Thread Jaikiran Pai
I am willing to test and vote on an AntUnit release. -Jaikiran On 18/06/18 12:45 PM, Stefan Bodewig wrote: OK, then I'll revert the antunit change so the source release ships with a released version of it and prepare release candidates sometime the coming days. The alternative would

Re: svn commit: r27516 - /release/ant/KEYS

2018-06-17 Thread Jaikiran Pai
Thank you Stefan, I forgot to add it to this location and added only in the git repo. -Jaikiran On 17/06/18 2:00 PM, bode...@apache.org wrote: Author: bodewig Date: Sun Jun 17 08:30:47 2018 New Revision: 27516 Log: Add Jaikiran's key Modified: release/ant/KEYS Modified: release/ant

Re: thinking about new releases

2018-06-17 Thread Jaikiran Pai
+1. I don't have anything in a state that I can push to either of these branches, in the immediate future. -Jaikiran On 16/06/18 9:38 PM, Stefan Bodewig wrote: Hi all given https://dev.snyk.io/research/zip-slip-vulnerability lists Ant 1.9.12 as a release fixing a security problem it might

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-17 Thread Jaikiran Pai
I pushed a bunch of commits to address these issues and have now released newer binaries for 2.3.0-rc1 release and initiated a separate VOTE mail for it. -Jaikiran On 16/06/18 6:48 PM, Stefan Bodewig wrote: Hi please add your PGP key to dist.apache.org/release/ant/KEYS * checksums

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-17 Thread Jaikiran Pai
: Support for storing credentials securely Do you vote for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Given some of the valid issues that Stefan has raised with this released instance, I'm cancelling this vote. This is a first release after a long time and I plan to have this as clean as possible. I will send out a new vote mail once I sort out these issues. -Jaikiran On 16/06/18 6:48 PM

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Thanks Stefan, I'll fix these issues and send out a new voting mail. -Jaikiran On Saturday, June 16, 2018, Stefan Bodewig wrote: > Hi > > please add your PGP key to dist.apache.org/release/ant/KEYS > > * checksums and signatures are good > * for the files in updatesite it s

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-15 Thread Jaikiran Pai
I tried reproducing this issue but haven't been able to. Either way, given the nature of this issue, I personally don't consider it a blocker for this release vote to pass. Please do file a JIRA with the relevant details if this is reproducible. -Jaikiran On 14/06/18 12:53 AM, Gintautas

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-15 Thread Jaikiran Pai
that dependency in a simple Java class. - Checked some Ivy plugin settings page to make sure they look and work fine. -Jaikiran On 13/06/18 9:18 PM, Jaikiran Pai wrote: I have built a release candidate 2.3.0-rc1 for Apache IvyDE. The tag is here: https://git1-us-west.apache.org/repos/asf?p=ant

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-14 Thread Jaikiran Pai
On 14/06/18 11:50 AM, Stefan Bodewig wrote: On 2018-06-13, Jaikiran Pai wrote: You can download the distribution from this URL: https://dist.apache.org/repos/dist/dev/ant/ivyde/2.3.0-rc1 Be the releas policy that is in place now SHA1 is deprecated, MD5 is frowned upon and at least SHA256

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-14 Thread Jaikiran Pai
Sure, i'll do that today. -Jaikiran On Thursday, June 14, 2018, Stefan Bodewig wrote: > [As usual I'll only be able to review the legal stuff but probably won't > find time to do so before tomorrow or even Saturday (am currently > traveling).] > > On 2018-06-13, Jaikiran Pai wrot

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
Gintas, When and where do you see these messages? What activity triggers it? -Jaikiran On 14/06/18 12:36 AM, Gintautas Grigelionis wrote: I am testing on Oxygen 3.A and seeing errors like org.xml.sax.SAXParseException; systemId: http://ant.apache.org/ivy/ivyde/updatesite/p2-mirrors--xml.cgi

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Proposing Apache IvyDE release

2018-06-13 Thread Jaikiran Pai
to call this release 2.3.0-rc1. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
On 09/06/18 5:22 PM, Gintautas Grigelionis wrote: Thanks for review, Jaikiran. You're correct, that is the proposed solution, adding a separator (a newline followed by an exception name for clarity -- mind that exception is logged only in debug mode). The exception class name would already

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
this commit, it used to print just the stacktrace. I don't see how this change would solve what's being discussed in that bugzilla. If this isn't the proposed solution, is there some other place I can read up on what's being proposed? -Jaikiran

Re: AntUnit Bug Causing Jenkins Failures

2018-06-04 Thread Jaikiran Pai
Sounds fine to me. -Jaikiran On 04/06/18 1:08 PM, Stefan Bodewig wrote: Hi all one of the recurring issues that make Jenkins builds fail is a thread-safety bug in AntUnit's log capturing code. This is supposed to be fixed in AntUnit's master branch. I propose to build an alpha version

Re: InputHandler and end-of-stream

2018-06-03 Thread Jaikiran Pai
an empty input and maybe fall back to the default value? Given that the null return value happens when the stream, from which we are reading, has ended earlier than expected, IMO we should consider it an error case and throw a more legible exception inste

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
On 03/06/18 3:13 PM, Jaikiran Pai wrote: I have now added a section in the junitlauncher task's manual The section's titled "Using the classpath element to include test engines". -Jaikiran to include an example which shows how to setup the classpath element to include thet

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
to reply with details if there's something else you are looking for. [1] https://raw.githubusercontent.com/apache/ant/master/manual/Tasks/junitlauncher.html -Jaikiran On 02/06/18 8:39 AM, Jaikiran Pai wrote: HelloLucas, On 01/06/18 10:46 PM, Lucas Bullen wrote: However, when attempting

Re: ClassLoaders in JUnit Launcher Task

2018-06-01 Thread Jaikiran Pai
been able to come up with a solution. I'll look more into this in the upcoming days and see how we can improve this. If I misunderstood your use case, please do let us know. [1] https://ant.apache.org/manual/Tasks/junitlauncher.html -Jaikiran

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-18 Thread Jaikiran Pai
0ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL888 [5] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL1359 [6] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#diff-b98a3d2097d6a9b5d7e0fc2eac033f24L348 -Jaikiran

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
it into some other form (thus additional code plus additional objects allocated in the process), all this to iterate over it and run some logic on it - all of which was already possible with the enumeration that was already available. -Jaikiran On 18/05/18 12:22 AM, Gintautas Grigelionis

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
I agree. Especially when it's being done on something like for archive entries which can betoo many depending on the archive that is being dealt with. -Jaikiran On 17/05/18 12:04 PM, Maarten Coene wrote: Converting an Enumeration to a List just for iterating it doesn't seem performance

[GitHub] ant-antlibs-antunit issue #1: Avoid potential thread safety issues in LogCap...

2018-05-14 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-antlibs-antunit/pull/1 Thank you. Merged. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev

[GitHub] ant-antlibs-antunit pull request #1: Avoid potential thread safety issues in...

2018-05-13 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-antlibs-antunit/pull/1 Avoid potential thread safety issues in LogCapturer This commit is prompted by the exception I saw in one of the Ant Jenkins jobs which failed with: ``` /home/jenkins

Re: [GitHub] ant pull request #:

2018-05-13 Thread Jaikiran Pai
No problem. That change to WHATSNEW is fine, I don't mind. -Jaikiran On 13/05/18 1:03 PM, Gintautas Grigelionis wrote: Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai <jai.forums2...@gmail.com>: I di

Re: [GitHub] ant pull request #:

2018-05-12 Thread Jaikiran Pai
on. -Jaikiran On 12/05/18 9:19 PM, twogee wrote: Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
should be available here[2]. [1] https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ it works! Glad to hear that :) -Jaikiran

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ -Jaikiran On 12/05/18 5:30 PM, Jaikiran Pai wrote: Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
has moved to TIMTOWTDIBSCINABTE? Sorry, I really don't know what that means or how that relates to what we are discussing. -Jaikiran Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai <jai.forums2...@gmail.com>: On 30/04/18 11:12 AM, Gintautas Grigelionis wrote: Names of buildfiles used in tests can b

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
t ways a certain thing can be implemented. I hope you do realize that what we are discussing in this thread (and others) is much more broader than finding copy/paste errors due to usage of one API over other. -Jaikiran - To unsub

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
se commits anymore and just stay away from them and stop sending this frustrated and rude sounding mails. -Jaikiran The point is that these names are used exactly once, and need not to be put in a field which is named inconsistently. Deviations from this rule of thumb indicate that tests are par

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
What purpose is this change serving? -Jaikiran On 30/04/18 10:08 AM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 0add85310 -> f3dfb7779 Inline buildfile names, make search easier Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://

Re: [Announce] Release of Apache Ivy 2.5.0-rc1

2018-04-22 Thread Jaikiran Pai
Thank you Nicolas for running this release. -Jaikiran On 22/04/18 11:24 PM, Nicolas Lalevée wrote: The Apache Ivy project is pleased to announce its 2.5.0-rc1 release. Apache Ivy is a tool for managing (recording, tracking, resolving and reporting) project dependencies, characterized

Re: Ant JUnit tests

2018-04-19 Thread Jaikiran Pai
ing those assumptions? -Jaikiran On 20/04/18 10:39 AM, Gintautas Grigelionis wrote: I am refactoring Ant JUnit tests with a goal to make them more "IDE-friendly". I found several tests that are implictly dependent on ant.home property being set. In these cases, the test shou

Include ANT_HOME location in "ant -version" ?

2018-04-19 Thread Jaikiran Pai
from. Any thoughts? [1] https://www.mail-archive.com/user@ant.apache.org/msg42757.html -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

JUnit 5 tests incorrectly picked up during Ant junit tests

2018-04-15 Thread Jaikiran Pai
It indeed looks like a build exclusion that I might have missed. I will take a look at this and fix it. -Jaikiran On 15/04/18 9:35 PM, Stefan Bodewig wrote: On 2018-04-15, Gintautas Grigelionis wrote: By the looks of it, JUnit 5 runner tests need an assumption check, too. Not sure why

Re: ant git commit: More isEmpty()

2018-04-13 Thread Jaikiran Pai
ill lead to NullPointerException, which most likely will be the case in a lot of places other than those that just set the incoming value to some member variable. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-12 Thread Jaikiran Pai
bug fixes for some random fixes that were part of this release (IVY-1540 and IVY-1577). Worked fine. - Built some internal projects using the downloaded version of Ivy, using Java 9. All went fine. -Jaikiran On 12/04/18 9:59 PM, Nicolas Lalevée wrote: I have built a release candidate

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-11 Thread Jaikiran Pai
tests. Considering the commits that have been made (even just considering only the Ant ones), I don't see how those relate to some plan to refactor JUnit tests. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apac

Re: Ivy release

2018-04-09 Thread Jaikiran Pai
+1. Thanks Nicolas. -Jaikiran On Monday, April 9, 2018, Nicolas Lalevée <nicolas.lale...@hibnet.org> wrote: > The last thread about a release has been stuck in the discussion about which PR, patch or Jira needed to be tackled before releasing. I suggest we just move forward with th

Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-06 Thread Jaikiran Pai
please reconsider whether or not we should be doing such changes? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function

2018-04-04 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno, thank you for this PR. I have gone ahead and included your patch with minor modifications to upstream and also included a test along with it. I have also included your name in our release

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694759 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder(&qu

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694862 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder(&qu

[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function

2018-03-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno Thank you for the patch. This mostly looks fine. I have added some review comments. Can you please also introduce a test case for this? Something that tests that these command options

Re: [ANN] Apache Ant 1.9.11 and 1.10.3 Released

2018-03-27 Thread Jaikiran Pai
Stefan, thank you for running these releases. -Jaikiran On 28/03/18 10:52 AM, Stefan Bodewig wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The Apache Ant Team is pleased to announce the releases of Apache Ant 1.9.11 and 1.10.3. Apache Ant is a Java library and command-line tool

Re: [VOTE] Release Ant 1.10.3 based on RC2

2018-03-25 Thread Jaikiran Pai
+1. Verified that the changes in the junitlauncher task documentation are present. Also ran some local projects with this new 1.10.3 tar.gz and all was fine. -Jaikiran On 24/03/18 6:18 PM, Stefan Bodewig wrote: Hi all I've created a new release candidate for 1.10.3 incorporating the doc

Re: junitlauncher doc fix (was Re: [VOTE] Release Ant 1.10.3 based on RC1)

2018-03-24 Thread Jaikiran Pai
On 24/03/18 1:03 PM, Stefan Bodewig wrote: On 2018-03-24, Jaikiran Pai wrote: I'm not sure if for the documentation fix (which I have pushed upstream) we need to redo a new RC release. If I understand your change correctly then the manual as would be released with 1.10.3 is plain wrong

Re: ant git commit: Add dependency description

2018-03-24 Thread Jaikiran Pai
element of the junitlauncher task. I had attempted this in the very first version of this task, but ran into certain classloader issues which I did not time to investigate, so decided to push it out for now. [1] http://ant.apache.org/faq.html#delegating-classloader -Jaikiran On 17/03/18 8:39 PM

Re: [VOTE] Release Ant 1.9.11 based on RC1

2018-03-24 Thread Jaikiran Pai
to the binary distribution's layout to upstream[1], but I don't thinkthat's a big enough change to warrant another RCfor this release. [1] https://github.com/apache/ant/commit/a3b065b967b87641dc0e5a154a44002395f656c8 -Jaikiran On 23/03/18 11:03 PM, Stefan Bodewig wrote: correction, the Maven

Re: [VOTE] Release Ant 1.10.3 based on RC1

2018-03-24 Thread Jaikiran Pai
apache/ant/commit/12c975888a762f0f901391a1bf27703360d179d0 -Jaikiran On 24/03/18 1:07 AM, Stefan Bodewig wrote: Hi all I've created a release candidate for 1.10.3: git tag: ANT_1.10.3_RC1 on commit: d00658c tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 2

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Jaikiran Pai
other mails due to limited internet connectivity this few days. I'll respond to them soon. -Jaikiran On 20/03/18 8:57 PM, Stefan Bodewig wrote: Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass

Re: ant git commit: Add dependency description

2018-03-17 Thread Jaikiran Pai
. -Jaikiran On 17/03/18 7:22 PM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 50b9be737 -> a312b6728 Add dependency description Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/a312b672 T

Snapshot access to regular users of Ant

2018-03-17 Thread Jaikiran Pai
reading that policy, I'm starting to wonder if the Jenkins job should even publish these snapshots. [1] http://www.apache.org/legal/release-policy.html#publication -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

Re: AW: Ant nightly Jenkins job

2018-03-17 Thread Jaikiran Pai
This is now done. The Ant_Nightly job now generates the Ant distribution which can be used for testing the bug fixes/features that go into the "master" branch. The distribution is available at https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/

Re: When is Ant 1.10.3 release expected?

2018-03-17 Thread Jaikiran Pai
I (finally) merged the JUnit 5 work to master. Rest of the fork related work for this task is something that I don't plan to make available in this release (the work is going to take some time). So I guess, we can make a new release. -Jaikiran On 12/03/18 4:53 PM, Stefan Bodewig wrote

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/60 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-03-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 This is now merged upstream. Closing this PR. Thanks Stefan for the extensive review. --- - To unsubscribe, e-mail: dev-unsubscr

Re: User implementations of custom interfaces can have access to Task instance?

2018-03-17 Thread Jaikiran Pai
in something like: classname="some.custom.class.implementing.an.task.specific.interface"/> plus the fact that this custom class can reside in a classloader defined by nested elements of this task. -Jaikiran On 13/03/18 3:36 PM, Stefan Bodewig wrote: On 2018-03-13, Jaikiran Pai wrote:

User implementations of custom interfaces can have access to Task instance?

2018-03-13 Thread Jaikiran Pai
ave access to this, then I will just go ahead and expose it without worrying about it. P.S: I realize in fork mode, the Task instance won't be available and I'll be taking that into account, but this question is more a general guideline I'm looking for.

Ivy old docs removed - documentation now resides under asciidoc

2018-03-07 Thread Jaikiran Pai
the repo, is the place where documentation for the project resides. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

<    1   2   3   4   5   6   >