[GitHub] ant pull request #:

2018-12-16 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692461
  
In src/main/org/apache/tools/ant/types/ModuleVersion.java:
In src/main/org/apache/tools/ant/types/ModuleVersion.java on line 51:
no @param for number


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-16 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692367
  
Thanks, perhaps it's time for [multi-release 
jars](https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html)?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-15 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691241
  
Yes, that's the idea.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-15 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691133
  
`src/etc/poms/ant/pom.xml` should exclude the new tasks from compilation; 
Maven builds are Java 8 only.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #79: Make DataType and Reference generic

2018-11-19 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant/pull/79


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

2018-11-14 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant/pull/78


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #78: A new CharSet type to hold available Charset names

2018-11-12 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/78
  
License headers added. Yes, it should be used with `setEncoding` (or in 
some tasks `setCharset`). Now that I think about it image/imageio tasks have an 
"encoding" attribute which is a misnomer. I'd like to deprecate it in imageio 
and use a "format" instead (with a proper Enumerated Attribute to boot 😁).


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

2018-11-12 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant/pull/78#discussion_r232795363
  
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.tools.ant.BuildException;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+public class CharSetTest {
+@Test
+public void testCorrectNames() {
+String[] expected = {"UTF-8", "ISO-8859-1", "037", "us", "IBM500"};
+Arrays.stream(expected).forEach(new CharSet()::setValue);
+}
+
+@Test(expected = BuildException.class)
+public void testNonExistentNames() {
+String[] nonexistent = {"mojibake", "dummy"};
+Arrays.stream(nonexistent).forEach(new CharSet()::setValue);
--- End diff --

I was lazy... 😁 the tests are properly parameterised now


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #79: Make DataType and Reference generic

2018-11-06 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant/pull/79

Make DataType and Reference generic



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant checked-reference

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 92fa54249840615df5658c5eb4b27bdb0700810f
Author: twogee 
Date:   2018-08-26T05:42:26Z

Make DataType and Reference generic

commit 53dfa2cd3168cd3bba10ef4dd526add2b7169721
Author: twogee 
Date:   2018-11-07T06:48:44Z

Deprecate the old API




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

2018-11-06 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant/pull/78

A new CharSet type to hold available Charset names

I believe that might be useful when validating "encoding" (or "charset") 
attributes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant charset-type

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 033d68c7f6ecf382f84eec5ab0c2bb91eb9bd6fb
Author: twogee 
Date:   2018-11-06T21:27:55Z

A new CharSet type to hold available Charset names




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-11-01 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31140697
  
In 
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java:
In 
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java
 on line 255:
Field no longer used after refactoring?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-10-16 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/d100b900324ad91f3de6e8c323720e1676bbb28d#commitcomment-30927697
  
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java:
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java on 
line 129:
Lack of a diamond on RHS causes compiler warnings...


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-09-28 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/048015b7d891edd74c8d458aa582a504511872c6#commitcomment-30695466
  
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java:
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java on line 572:
Ironically, javadoc is wrong; see the 
[nightly](https://builds.apache.org/view/All/job/Ant_Nightly/988/warnings5Result/NORMAL/)



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #61: Use japicmp to check binary compatibility

2018-08-29 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/61


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #61: Use japicmp to check binary compatibility

2018-08-29 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/61
  
japicmp 0.13.0 is out with the ability to break incompatible Ant builds.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order

2018-08-14 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/63


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #63: Replace JAI with ImageIO

2018-08-12 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant/pull/63


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

2018-08-07 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
Thank you, the fix is in master now. Please rebase to verify and close the 
PR.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

2018-08-07 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
`singletonList()` for single-element lists is the pattern used across Ivy 
tests. Thriftiness is a virtue, despite what people may say 😄


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

2018-08-07 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
The disk is full again 😦Anyway, in case there is only one element, 
`Collections.singletonList()` is preferable.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

2018-08-06 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
Sorting is a problem, in `rootModuleConfs` field of `IvyNodeUsage` by the 
looks of it.
```
assertTrue(Arrays.asList("myconf1", 
"myconf2").containsAll(Arrays.asList(

crp.getDependency(mod22).getConfigurations(crp.getConfiguration();
```
does the bill, not sure if that's good enough, though.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #74: Fix IVY-982 by removing negated entries from wildcard bin

2018-08-06 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/74
  
@aprelev Unfortunately, the fix fails on Java 7 but not the later versions 
(reproduced on macOS here, too). Do you need assistance to investigate further?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: IVY-1104 Include attributes qualifiers in the XML report

2018-08-06 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Because it's merged in ASF Git, not in Github. Github is merely a mirror of 
ASF.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function

2018-08-06 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/71
  
@aanno could you please rebase and push the branch in order to close the PR?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: IVY-1104 Include attributes qualifiers in the XML report

2018-08-04 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
I suppose the PR will close if you rebase and push your master.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: IVY-1104 Include attributes qualifiers in the XML report

2018-08-04 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Thanks, the fix should be on master now.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...

2018-08-03 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/73#discussion_r207669472
  
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -193,16 +193,8 @@ public void startElement(String uri, String localName, 
String qName,
 String branch = attributes.getValue("branch");
 String revision = attributes.getValue("revision");
 Map extraAttributes = new 
HashMap<>();
--- End diff --

Is this Map used?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: IVY-1104 Enable XML report parser to produce qualified ex...

2018-08-02 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
No dispute here; however, that may need some adjustment to XSL, which 
transforms XML report to HTML.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: IVY-1104 Enable XML report parser to produce qualified ex...

2018-08-02 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Besides, `extra-` has to be kept for backwards compatibility.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: IVY-1104 Enable XML report parser to produce qualified ex...

2018-08-02 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
`'-'` cannot be escaped since the spec does not permit `&#

[GitHub] ant-ivy issue #73: IVY-1104 Enable XML report parser to produce qualified ex...

2018-08-02 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Keeping `':'` would require XML report to deal with all those pesky 
namespaces, because it must be a valid XML.

Using a simple `'-'` as a separator may cause trouble if somebody decides 
to use a namespace prefix with `'-'`. That's why I insist on something less 
likely to be used.  I hope dev list would comment, too.

+1 for placing codec routines into `ExtendableItemHelper`.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Sorry, my reasoning took the wrong turn, must be the heat 😦Yes, passing 
qualified attributes to XmlReportWriter is the way to go.

I wonder what was the reason for using "extra-" hack? I assume it was 
conceived as a way to avoid dealing with with random namespaces in the XML 
report. If it makes sense to continue with that, a way to encode the namespace 
prefix must be figured out.

That means one should look at the permitted characters in the [XML 
Specification](https://www.w3.org/TR/xml11/#NT-NameChar) and try to figure out 
a separator such that from a name constructed as  
"extra-" a namespace prefix and a 
name could be extracted unambiguously.

I propose using something like ".-_-." as a separator since it is unlikely 
to occur in any namespace prefixes for extra attributes describing Ivy 
artifacts (if somebody does that, it must be on purpose and thus an attempt to 
shoot oneself in the foot). Or should we rather deal with namespaces in XML 
reports?

P.S. You're right about the Jira issue, please add it to the name of the PR 
(and eventually to the commit name). 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Gradle seemed to have [different 
ideas](https://github.com/gradle/gradle/issues/954) about Ivy XML namespaces 
(not to be confused with Ivy 
[namespaces](http://ant.apache.org/ivy/history/2.5.0-rc1/settings/namespaces.html)
 😉); perhaps we should keep the parser namespace-unaware and simply check 
for presence of `':'` in the attribute names of the artifact descriptors?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
@aprelev the latter, you can push a new commit. What I meant is that 
hardcoding "e:" is probably a bad idea, one may choose a different namespace 
prefix; rather, we should be enforcing use of namespace URL for extra 
attributes.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
@aprelev Rather than hardcoding prefix, shouldn't we retrieve it by URL 
"http://ant.apache.org/ivy/extra;?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-30 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
Thanks for reviewing. I hope my last refactoring clarifies the point about 
the string field in the Text class (or the string attribute in the text 
element).


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-28 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
I will do move `addRectangle` and `addText` to `Draw`, it makes no sense to 
have them in an abstract class. The manual needs correction regarding 
`ImageOperation`, both for image and imageio tasks: it should not be mentioned 
at all. Even if imageoperation could be used as a nested tag, it will only 
cause instantiation exception. Besides, text has a wrong attribute, it's 
"string", not "text"; so it makes sense to redraw both class diagrams 😉 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-19 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
Looks like disk is full in CI server...


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-18 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
Looking at the class diagram, I wonder why `addRectangle()` is in 
TransformOperation rather than only in Draw?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-17 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
I decided to redraw the class diagram as GraphML (continuing Ivy tradition 
of using yEd), because it's quite informative.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-11 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
I could almost reuse the class diagram in the documentation if it wasn't 
referring to PlanarImage... so I have to draw a new one unless the original UML 
is available somewhere (a long shot, I know...)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #63: Replace JAI with ImageIO

2018-07-11 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant/pull/63#discussion_r201826479
  
--- Diff: build.xml ---
@@ -277,13 +277,20 @@
 
   
 
+  
+
+  
+  
+
+  
+
   
 
   
 
   
 
-  
+  
--- End diff --

Thanks, Stefan, on to the documentation...


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-10 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
"imageio" is fine by me, then we skip a potential debacle about naming of 
java-jai.jar 😉
Whenever JAI is laid to rest, "image" can be reclaimed as an alias.
FWIW Java 8 is an LTS release, but hopefully not the last one.

So, it's refactoring, fixing build.xml, writing the documentation and 
putting a note about JAI in Image task manual -- did I miss something?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #63: Replace JAI with ImageIO

2018-07-10 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant/pull/63
  
JAI is dead. It depends on internal classes that are no longer there in 
Java 9. I propose dropping JAI API support completely, just like apt or javah. 
I don't like the like the idea of shipping dead code for the sake of BWC. If 
someone would like to use JAI on Java 8, there is an option of using an older 
ant-jai.jar; else, 
[jai-imageio-core](https://jai-imageio.github.io/jai-imageio-core/) implements 
the lacking functionality (TIFF support). Also, there are 
[TwelveMonkeys](https://haraldk.github.io/TwelveMonkeys/) for even more 
functionality.

The task is not deprecated in documentation because it works on Java 8 as 
is; perhaps the situation with JAI should be explained once there's an 
agreement on how to proceed.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #63: Replace JAI with ImageIO

2018-07-06 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant/pull/63

Replace JAI with ImageIO

Undeprecate Image task in Java 9+. No documentation yet; only the code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant image-with-imageio

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #63


commit 7930191ba5300eeccd6a021b9ae6f7e616482ffe
Author: twogee 
Date:   2018-07-06T19:03:13Z

Replace JAI with ImageIO




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-07-03 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29585155
  
In manual/install.html:
In manual/install.html on line 931:
Sorry about nitpicking: I would prefer a space between Java and the version.
java.activation.jmod is still there in Java 10, but must be activated by a 
command-line option.
It will be gone completely in Java 11, I suppose.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-06-25 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/ca98cc50364f694e1642f84a0c43d0134098ed30#commitcomment-29484065
  
In manual/credits.html:
In manual/credits.html on line 49:
Shouldn't that be grave?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-antlibs-antunit pull request #:

2018-06-22 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant-antlibs-antunit/commit/f66f1178dcb42af44f4008493262782afe7c9f4d#commitcomment-29461462
  
In README:
In README on line 23:
BTW, JUnit 4 would require Java 5, too.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-antlibs-antunit pull request #:

2018-06-22 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant-antlibs-antunit/commit/f66f1178dcb42af44f4008493262782afe7c9f4d#commitcomment-29461325
  
In README:
In README on line 23:
Really? 😮 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-05-12 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469
  
In 
src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java:
In 
src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java
 on line 77:
Please add 20 (package), too


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-27 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28765518
  
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on line 107:
Thanks for reviewing; hope the latest proposal is adequate.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-23 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691811
  
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on line 107:
First, the original code has swallowed three exceptions and re-thrown the 
others. Second, ExpectedException is not a one-off device; rather, it's a 
filter for anything that happens in the code below the point where it is 
declared. It's a "bollplank", if you excuse my Swedish 😉 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-22 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688738
  
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on line 107:
finally ensures all calls execute. This works by virtue of all thrown 
exceptions being identical. Try throwing something else and it explodes 😉 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-15 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590841
  
In 
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
In 
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java on 
line 117:
That would be an interesting test: if the task succeeds and the log says 
the task failed, or the task fails? No wonder it was ignored...


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-15 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28589786
  
In 
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
In 
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java on 
line 117:
The original code catches RuntimeException and examines it, just what the 
ExpectedException is supposed to do. How on Earth it was supposed to execute 
assertContains in the same try is beyond me. It looks like a reasonable 
post-mortem, though. And, I actually ran the test ;-)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #69: 2.4.x

2018-04-12 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/69
  
Check out the [nightlies](https://ant.apache.org/nightlies.html)
I was commenting here because @supertick is apparently pushing changes to 
2.4.x release branch, but the RC is from the master.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #69: 2.4.x

2018-04-12 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/69
  
@supertick FYI, Ivy 2.5.0 RC is on the way, @nlalevee has kindly taken the 
role of release manager. Your latest commits are not merged to master, though. 
If you are interested in using 2.5.0, please let us know.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-11 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525323
  
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java on line 962:
In Java 8+, that is...


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-11 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525288
  
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java on line 962:
StringBuilder is supposed to be null-safe, that is the whole idea with this 
refactoring.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-10 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28509355
  
In src/main/org/apache/tools/ant/util/LazyHashtable.java:
In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:
It does not, generics are erased from signature.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-10 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28507789
  
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java:
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 99:
I believe that it is the same test as the one continued in the loop.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428804
  
You're right, there is no concise way to do backwards foreach loops in 
Java. I will revert them later today.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-04-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/26c8789a5067809255040d3338235b5ae25a3898#commitcomment-28428779
  
Sorry about letting this through. getLocationURLs() should be annotated 
with `@SuppressWarnings("deprecated") `.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/71#discussion_r177857645
  
--- Diff: src/java/org/apache/ivy/Main.java ---
@@ -199,6 +201,10 @@ static CommandLineParser getParser() {
 new OptionBuilder("cp").arg("cp")
 .description("extra classpath to use when 
launching process").create())
 
+.addCategory("maven compatibility options")
+.addOption(new 
OptionBuilder("pomfile").arg("pomfile").countArgs(false)
+.description("makepom as standalone 
tasks").create())
--- End diff --

On the second thoughts, why not calling the option `makepom` 😉 ?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/71#discussion_r177696348
  
--- Diff: src/java/org/apache/ivy/Main.java ---
@@ -199,6 +201,10 @@ static CommandLineParser getParser() {
 new OptionBuilder("cp").arg("cp")
 .description("extra classpath to use when 
launching process").create())
 
+.addCategory("maven compatibility options")
+.addOption(new 
OptionBuilder("pomfile").arg("pomfile").countArgs(false)
+.description("makepom as standalone 
tasks").create())
--- End diff --

IMHO `pomfile` is confusing (cf use of `ivyfile` and `propertiesfile`). I'd 
suggest `writepom`or something like that.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #69: 2.4.x

2018-03-22 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/69
  
Issue tracker for the project is [JIRA](https://issues.apache.org/jira). 
Apache has own Git infrastructure, GitHub is use to increase exposure and as 
easy means to suggest code changes (rather than uploading patches).

Please check the [latest](https://ant.apache.org/nightlies.html) Ivy build. 
I cannot verify your report right now, but the value of types should be split 
[correctly](https://github.com/apache/ant-ivy/blob/master/src/java/org/apache/ivy/util/filter/FilterHelper.java#L37)
 in master.



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #70: IVY-1321 Make Main.run() public

2018-03-21 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/70


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-21 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/70
  
Thanks for bearing with me 😉please see the revised commit.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/70
  
@supertick if you're fine with this PR, please close #69. I will merge this 
one later.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/70
  
I'm a bit surprised that StackOverflow does not refer to Apache 
[Confluence](https://cwiki.apache.org/confluence/display/IVY/Programmatic+use+of+Ivy)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #70: Make Main.run() usable programmatically

2018-03-19 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/70
  
Actually, you should be able to do

```
try {
ResolveReport  report = Main.run(args, false);
// iterate through the report
} catch (Exception e) {
// do something to handle error
}
```

But, I was hasty and the tests still fail. I'll try to rectify that later 
today.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #69: 2.4.x

2018-03-19 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/69
  
I suggest closing this PR. The main problem here is that programmatic use 
should not be adressed by adding CLI options which make no sense. Also, if 
resolve() ends with errors, it's best to throw an exception encapsulating 
whatever relevant information is available, rather than blithely carrying on.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #70: Make Main.run() usable programmatically

2018-03-19 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/70
  
This addresses IVY-1321 and IVY-1578


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #70: Make Main.run() usable programmatically

2018-03-19 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/70

Make Main.run() usable programmatically

Inspired by #69 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy ivy-1321

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70


commit ab638a8f5bb74d83299d006fcc0f041c21338610
Author: twogee <g.grigelionis@...>
Date:   2018-03-20T00:00:13Z

Make Main.run() usable programmatically




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #69: 2.4.x

2018-03-19 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/69
  
Could you please provide a unit test to demonstrate what is wrong with 
[IVY-1576 
fix](https://github.com/apache/ant-ivy/commit/3b17df0ab67a1f14794bc6c60b735f3354caec9e)?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-17 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/a312b6728acb7a8d1f8765899615205b3042cb7e#commitcomment-28138020
  
@jaikiran would it be possible to add a `classpath` attribute?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-03-17 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/64
  
@AurelienLourot we moved the discussion to 
[JIRA](https://issues.apache.org/jira/browse/IVY-1280)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-03-15 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/64
  
I would like to add the preemptive authentication flag to the newly minted 
`TimeoutConstrainedURLHandler` to avoid BWC issues.  Any objections, @jaikiran ?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-03-15 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/67


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #61: Use japicmp to check binary compatibility

2018-03-12 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/61
  
japicmp 0.11.1 is out...


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #:

2018-03-06 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant-ivy/commit/8ed4a9bea706320d97ce2fd3e6545d7ebdf8a49b#commitcomment-27956300
  
I believe we're using asciidoc now?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27929054
  
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java on 
line 476:
I meant "instead of `try { ...; fail ... } catch { ... }`"; you can still 
put expected exception rule inside an `if {} else {}` or use assume to get rid 
of that if/else.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/e06168ca78b819a21924f3716b99e3621b4855ef#commitcomment-27927813
  
It's not quite appropriate here, but we need a new release of Ivy... :cry: 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27927763
  
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java on 
line 476:
This the old way to do it, ExpectedException should be used instead.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-03-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/68
  
Yes, it is. See the list of bug reports above. I'd say we have another 
blocker, speaking of releases.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-03-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/68
  
What you download is `lwjgl-3.1.2-natives-macos.jar`; the dependency 
`lwjgl-3.1.2.jar` gets lost.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-03-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/68
  
You get the correct name using pattern 
`"artifact]-[revision](-[classifier]).[ext]"` 😉 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-03-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/68
  
This is another case of 
[IVY-1576](https://issues.apache.org/jira/browse/IVY-1576); maybe related to 
[IVY-1484](https://issues.apache.org/jira/browse/IVY-1484) and 
[IVY-1407](https://issues.apache.org/jira/browse/IVY-1407) and 
[IVY-1244](https://issues.apache.org/jira/browse/IVY-1244).


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-03-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/68
  
Oh, I see. We're looking at the same result, except you somehow keep an 
older version of junit (in my case JUnit 3 is evicted). The bug is (as you 
stated) that only platform-specific wjgl jars are downloaded. Somehow the 
presence of classifier makes Ivy ignore the artifact withouth them.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #68: Why no new Ivy version yet?

2018-03-01 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/68
  
What's missing?

```
$ java -jar build/artifact/jars/ivy.jar -dependency io.playn 
playn-java-lwjgl 2.0
:: loading settings :: url = 
jar:file:/Users/gintas/Projects/ant-ivy-asf/build/artifact/jars/ivy.jar!/org/apache/ivy/core/settings/ivysettings.xml
:: resolving dependencies :: io.playn#playn-java-lwjgl-caller;working
confs: [default]
found io.playn#playn-java-lwjgl;2.0 in public
found io.playn#playn-java-base;2.0 in public
found io.playn#playn-core;2.0 in public
found com.samskivert#pythagoras;1.4.3 in public
found com.threerings#react;1.5.3 in public
found com.googlecode.soundlibs#mp3spi;1.9.5-1 in public
found com.googlecode.soundlibs#jlayer;1.0.1-1 in public
found com.googlecode.soundlibs#tritonus-share;0.3.7-1 in public
found org.java-websocket#Java-WebSocket;1.3.0 in public
found org.lwjgl#lwjgl;3.1.2 in public
found org.lwjgl#lwjgl-opengl;3.1.2 in public
found org.lwjgl#lwjgl-glfw;3.1.2 in public
found junit#junit;4.12 in default
found org.hamcrest#hamcrest-core;1.3 in default

```


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivyde pull request #:

2018-03-01 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant-ivyde/commit/fc68846bbd7b18da1bb303db5e8a54f93692a2bd#commitcomment-27860034
  
Thanks :+1: 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivyde/pull/7
  
Sorry about a loose remark and for pursuing the deprecations 
[overagressively](https://github.com/apache/ant-ivyde/commit/d2983ea950fc93daa2db8bb6ef17958450fd34e3).
What I would appreciate is force push after rebase that would trigger a new 
Jenkins build. I don't know if there is a better way of doing that.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivyde/pull/7
  
Could you please rebase on the latest master?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivyde/pull/7
  
There is a 
[regression](https://github.com/apache/ant-ivy/commit/ae27582d1ba0cb6c2b18d30a81cb1b82033069c3)
 in URLHandler to be dealt with

```
[pde-build] [javac] schemaStream = 
URLHandlerRegistry.getDefault().openStream(schema, null);
[pde-build] [javac]
^^
[pde-build] [javac] The method openStream(URL) in the type URLHandler 
is not applicable for the arguments (URL, null)
```



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #63: IVY-1486 respect exclude regardless of order

2018-02-27 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/63
  
A new version using `Deque` and providing a backwards compatible method. 
Any concurrency concerns?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-27 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r171054211
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

Ah, I get it... the way things work, ant-junit4 must declare a dependency 
on ant-junit


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-27 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r171053071
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

Good catch, thanks. BTW, run this way Ant core seems unable to simply find 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask on a classpath; why is 
that? does it need some hint from the launcher?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #:

2018-02-27 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant-ivy/commit/1a19f2f836cd33a25d458ed8ba9bbb3c7ce4ff96#commitcomment-27816643
  
Could we do release and sign in one go by adding distributions to ivy.xml 
and using a separate filesystem resolver to copy and sign the distributions? 
Not to mention that there will be one less dependency (drop Commons OpenPGP)?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168964592
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

Yes. Invocation of Ant runs Ivy's build.xml; it's a fancy way of 
bootstrapping an Ivy build, by the looks of it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168963965
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

If Ant (launcher and core) is fetched as a dependency, then ant-junit must 
be retrieved as a dependency, too, in order to run unit tests. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



  1   2   3   >