[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/8 IVY-1522 Windows OS file path resolution fix The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This commit includes a new test method to verify

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174686 Thanks for testing this. I'll see if I can borrow a Windows OS to come up with a proper fix and test for this. Closing this for now. --- If your project is set up for

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread nlalevee
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174610 It seems to break badly Ivy on Windows. I tried to launch the test with a fresh checkout of your PR, and Ivy could not even resolve dependencies. Here are the

[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...

2015-08-30 Thread nlalevee
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/6#issuecomment-136152918 I have implemented it with two properties, ivy.maven.sources.lookup and ivy.maven.javadoc.lookup, which defaults to true Thanks for the PR --- If your project is

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread benmccann
Github user benmccann commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-136156878 Thanks!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread nlalevee
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-136139712 Merged. Thank you for the pull request. Sorry for the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-136157678 Thanks @nlalevee for merging this. Glad to see the contribution being accepted. Will send out PRs for other issues that I have started looking into. --- If your

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...

2015-08-26 Thread jsuereth
Github user jsuereth commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/6#discussion_r37987168 --- Diff: src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java --- @@ -306,6 +306,15 @@ private void

[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...

2015-08-26 Thread jsuereth
Github user jsuereth commented on the pull request: https://github.com/apache/ant-ivy/pull/6#issuecomment-135037966 One naming comment, then LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...

2015-08-26 Thread jsuereth
Github user jsuereth commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/6#discussion_r37987042 --- Diff: src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java --- @@ -306,6 +306,15 @@ private void

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-21 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-133562903 Haven't heard any inputs on the mailing list nor here. Not sure how active the project is. --- If your project is set up for it, you can reply to this email and have

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-11 Thread benmccann
Github user benmccann commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-130121102 Ping. Please review! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-07-28 Thread jsuereth
Github user jsuereth commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-125626169 FYI - We ran this on sbt/ivy and it looks great! I backported to Ivy 2.3 and it'll be available to sbt users shortly. Great work on teh fix! Also, nice catch on the

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-07-25 Thread benmccann
Github user benmccann commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-124876383 Just a reminder to please review this pull request. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-07-19 Thread benmccann
Github user benmccann commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-122768112 Awesome. Thank you so much for this fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] ant-ivy pull request: PomModuleDescriptorParser disabled handle so...

2015-07-15 Thread qxo
GitHub user qxo opened a pull request: https://github.com/apache/ant-ivy/pull/6 PomModuleDescriptorParser disabled handle source and javadoc artifact for speed up … PomModuleDescriptorParser disabled handle source and javadoc artifact by set disabledForSourcesAndJavadoc=true,

[GitHub] ant-ivy pull request: Lets ssh-based resolvers use an ~/.ssh/confi...

2015-01-11 Thread nlalevee
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/3#issuecomment-69492990 merged. Thanks for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] ant-ivy pull request: The default subject is `bintray`, not 'jcent...

2015-01-11 Thread nlalevee
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/5#issuecomment-69492417 merged. Thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] ant-ivy pull request: The default subject is `bintray`, not 'jcent...

2014-12-28 Thread jbaruch
GitHub user jbaruch opened a pull request: https://github.com/apache/ant-ivy/pull/5 The default subject is `bintray`, not 'jcenter` The code is good, typo is in the doc only. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ant-ivy pull request: Optimization: limit the revision numbers sca...

2014-12-26 Thread ernisv
GitHub user ernisv opened a pull request: https://github.com/apache/ant-ivy/pull/4 Optimization: limit the revision numbers scanned if revision prefix is specified I was investigating slow performance of ivy:buildnumber task. Turned out it was slow because descriptor was optional

[GitHub] ant-ivy pull request: Lets ssh-based resolvers use an ~/.ssh/confi...

2014-11-27 Thread cstanfill
GitHub user cstanfill opened a pull request: https://github.com/apache/ant-ivy/pull/3 Lets ssh-based resolvers use an ~/.ssh/config file to find username/hostname/keyfile options I haven't tested it for sftp, but it should theoretically work just as well as it does for the ssh

[GitHub] ant-ivy pull request: IVYDE-372: fix ClassCastException: System pr...

2014-10-15 Thread cpfeiffer
Github user cpfeiffer closed the pull request at: https://github.com/apache/ant-ivy/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request: IVYDE-372: fix ClassCastException: System pr...

2014-10-15 Thread cpfeiffer
Github user cpfeiffer commented on the pull request: https://github.com/apache/ant-ivy/pull/1#issuecomment-59255988 Already merged as https://github.com/apache/ant-ivy/commit/81fec3193ad12a0f78eb021c4a1548484595860b --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy pull request: IVY-1491 create POM with /xsd/maven-4.0.0.xs...

2014-10-05 Thread hboutemy
GitHub user hboutemy opened a pull request: https://github.com/apache/ant-ivy/pull/2 IVY-1491 create POM with /xsd/maven-4.0.0.xsd schema reference see https://issues.apache.org/jira/browse/IVY-1491 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ant-ivy pull request: IVYDE-372: fix ClassCastException: System pr...

2014-09-24 Thread cpfeiffer
GitHub user cpfeiffer opened a pull request: https://github.com/apache/ant-ivy/pull/1 IVYDE-372: fix ClassCastException: System properties may not be strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/cpfeiffer/ant-ivy

<    1   2   3