[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/60#discussion_r136417644
  
--- Diff: build-release.xml ---
@@ -179,11 +180,11 @@
 
 
 
-
+
 
--- End diff --

Very well, here's the output from 1.5.4:

```
.../ant-ivy/build-release.xml:202: org.jruby.exceptions.RaiseException: 
(LoadError) no such file to load -- asciidoctor
at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1040)
at 
RUBY.require(/Users/gintas/.ivy2/cache/org.asciidoctor/asciidoctor-ant/jars/asciidoctor-ant-1.5.4.jar!/META-INF/jruby.home/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:54)
at 

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread jaikiran
Github user jaikiran commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/60#discussion_r136327295
  
--- Diff: build-release.xml ---
@@ -179,11 +180,11 @@
 
 
 
-
+
 
--- End diff --

Instead of downgrading the version, I think we should try and figure out 
whatever the issue is with 1.5.4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-30 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/60

use Unicode glyphs or SVG data URLs instead of bitmaps

I put this up for review in case I missed some page that used the removed 
icons.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60


commit 49e89fb3f5249e8dd45581a5b14a2ebd7f9ea2b8
Author: twogee 
Date:   2017-08-30T18:20:16Z

use Unicode glyphs or SVG data URLs instead of bitmaps




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org