[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-03-15 Thread twogee
Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/67


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-27 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r171054211
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

Ah, I get it... the way things work, ant-junit4 must declare a dependency 
on ant-junit


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-27 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r171053071
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

Good catch, thanks. BTW, run this way Ant core seems unable to simply find 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask on a classpath; why is 
that? does it need some hint from the launcher?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168989393
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

strange, thanks. As Ivy uses junit4 you will also need ant-junit4 in this 
case.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168964592
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

Yes. Invocation of Ant runs Ivy's build.xml; it's a fancy way of 
bootstrapping an Ivy build, by the looks of it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168964407
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

to run which unit tests? Ivy's?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread twogee
Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168963965
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

If Ant (launcher and core) is fetched as a dependency, then ant-junit must 
be retrieved as a dependency, too, in order to run unit tests. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/67#discussion_r168961676
  
--- Diff: ivy.xml ---
@@ -61,6 +61,7 @@
 
 
 
+
--- End diff --

why has this dependency been added? I don't see it used.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-02 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/67

IVY-1483 Invoke Ant through Ivy;

like this: `java -jar ivy.jar -properties version.properties -main 
org.apache.tools.ant.Main`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy ivy-1483

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit 46ee20b19721362a4b1b43f413d1d6d1967df5a4
Author: twogee 
Date:   2018-02-02T22:37:11Z

IVY-1483 Invoke Ant through Ivy;
like this: java -jar ivy.jar -properties version.properties -main 
org.apache.tools.ant.Main




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org