[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-15 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/80
  
Many thanks again, @craigpell . I've merged this but would like to resolve 
the discussion about the log output.

With b74d5b366 I've committed a branch (logoutput-jmod-link) where I use 
`LogOutputStream` in `link` - I'm not sure why one would suppress the output at 
all, but I've never worked with the tool. A similar approach (or one that does 
away with the `ByteArrayOutputStream`s completely and removes the output from 
the exception and simply channels the output to Ant's log unconditionally) 
would work for `jmod` as well.

/cc @jaikiran 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-12 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/80
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/97/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-12 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/80
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/103/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-12 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/80
  
BSD is perfectly fine, thanks.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-11 Thread craigpell
Github user craigpell commented on the issue:

https://github.com/apache/ant/pull/80
  
All done, except that I’m finding there aren’t many man pages on my 
Linux system which aren’t GPL.  I’ve found a few which are under a BSD 
license;  is that acceptable?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-09 Thread bodewig
Github user bodewig commented on the issue:

https://github.com/apache/ant/pull/80
  
This looks great Craig, many thanks!

I've got a short list of wishes, though:

* please use a manual page that is not covered by the GPL inside of the 
tests - this is me probably being overly cautious but we really don't want to 
ship anything under the GPL as part of our releases
* add yourself to `CONTRIBUTORS` and `contributors.xml`
* add a blurb to `WHATSNEW`
* add `@since` markers (with 1.10.6) to the new tasks and the new type - 
and do so to the manual pages as well.

I can do all or some of them myself if you prefer me to do it. In that case 
I'd ask you to confirm you want to be addressed as "Craig Pell" in the 
contributors files.

Many thanks again.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/80
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/95/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/80
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/101/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-06 Thread jaikiran
Github user jaikiran commented on the issue:

https://github.com/apache/ant/pull/80
  
this is ok to test


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/80
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/80
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org