RE: Resource.getURL() - example

2006-09-29 Thread Stephen McConnell
-Original Message- From: Matt Benson [mailto:[EMAIL PROTECTED] My current impression is that, partially contingent on Stephen's willingness to field questions, ;) the protocol-based solution is preferable, or at least worth _proving_ unsuitable. Matt: My schedule is free over

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Antoine Levy-Lambert
Hello Peter, I would like simply to understand why you did this change. What does this bring us ? A class that does not have an execute method is semantically not a task. So I would also say that such a class should not extend Task. Can we find a way to get whatever you want to achieve by

DO NOT REPLY [Bug 40632] - spawned process through exec task blocks parent exec task

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40632. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

AW: AW: svn commit: r450609 - /ant/core/trunk/src/main/org/apache/tools/ant/util/ConcatResourceInputStream.java

2006-09-29 Thread Antoine Levy-Lambert
Hi, I agree with Jan. I do not understand ultra compact syntax. I do not know operators precedence by heart. What I do not master at all are bitwise operations with | Regards, Antoine Original-Nachricht Datum: Thu, 28 Sep 2006 16:50:18 +0200 Von: [EMAIL PROTECTED] An:

svn commit: r451160 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java

2006-09-29 Thread antoine
Author: antoine Date: Fri Sep 29 01:32:48 2006 New Revision: 451160 URL: http://svn.apache.org/viewvc?view=revrev=451160 Log: remove finalize method, suggested by Peter Reilly Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/resources/URLResource.java Modified:

Re: svn commit: r450863 - in /ant/core/trunk: CONTRIBUTORS WHATSNEW contributors.xml src/main/org/apache/tools/ant/types/resources/URLResource.java

2006-09-29 Thread Antoine Levy-Lambert
Hello Peter, thanks for your suggestion, I have just committed the change. Regards, Antoine Original-Nachricht Datum: Thu, 28 Sep 2006 15:41:39 +0100 Von: Peter Reilly [EMAIL PROTECTED] An: Ant Developers List dev@ant.apache.org Betreff: Re: svn commit: r450863 - in

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Peter Reilly
On 9/29/06, Antoine Levy-Lambert [EMAIL PROTECTED] wrote: Hello Peter, I would like simply to understand why you did this change. What does this bring us ? A class that does not have an execute method is semantically not a task. So I would also say that such a class should not extend Task.

Re: AW: Hi I need some help

2006-09-29 Thread Antoine Levy-Lambert
Hello Michael, due to problems with the URLResource class maybe your junitreports were not generated. Update your source code from the subversion repository by running svn update and rebuild ant. I advise you run the tests this way : 1) rebuild ant just type ant on the command line; or

Re: AW: Hi I need some help

2006-09-29 Thread Antoine Levy-Lambert
Hi, Sorry there was a typo in my last email. the define to use to keep the tests going is -Dtest.haltonfailure=false let us know if some tests are still failing. If tests are failing you can enter bug reports about that in Bugzilla. I would create one bug report per failing test. Be sure in

DO NOT REPLY [Bug 40632] - spawned process through exec task blocks parent exec task

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40632. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Antoine Levy-Lambert
Hello Peter, Original-Nachricht Datum: Fri, 29 Sep 2006 09:44:44 +0100 Von: Peter Reilly [EMAIL PROTECTED] An: Ant Developers List dev@ant.apache.org Betreff: Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/

Re: Resource.getURL() - example

2006-09-29 Thread Steve Loughran
Stephen McConnell wrote: -Original Message- From: Scott Stirling [mailto:[EMAIL PROTECTED] [snip] All of these protocols include support for the establishment of a locally cached file that is a copy of the remote resource (partly driven by the need to handle the relationship

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Antoine Levy-Lambert
Hi, one of the ideas which is nearly always guiding me when I program is that if you depict pears as oranges in your code it is generating a bad smell and might fail on you later. maybe we need a generic way to adapt a condition to become a task, for instance conditionadapter if and

DO NOT REPLY [Bug 40638] New: - Allow comments in PatternSet includesfile and excludesfile

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40638. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Peter Reilly
On 9/29/06, Antoine Levy-Lambert [EMAIL PROTECTED] wrote: Hello Peter, Original-Nachricht Datum: Fri, 29 Sep 2006 09:44:44 +0100 Von: Peter Reilly [EMAIL PROTECTED] An: Ant Developers List dev@ant.apache.org Betreff: Re: svn commit: r451000 - in /ant/core/trunk/src:

DO NOT REPLY [Bug 40632] - spawned process through exec task blocks parent exec task

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40632. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40638] - Allow comments in PatternSet includesfile and excludesfile

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40638. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: Resource.getURL() - example

2006-09-29 Thread Matt Benson
FYI all, this AM I did think of another point which heavily favors application-level resolution: we have already set a precedent for this with our handling of the antlib: pseudo-protocol. -Matt - Original Message From: Matt Benson [EMAIL PROTECTED] To: Ant Developers List

Re: AW: svn commit: r450609 - /ant/core/trunk/src/main/org/apache/tools/ant/util/ConcatResourceInputStream.java

2006-09-29 Thread Alexey Solofnenko
For what it worth - I think new code is readable and easy to understand, but that maybe Jython training... - Alexey. On 9/29/06, Antoine Levy-Lambert [EMAIL PROTECTED] wrote: Hi, I agree with Jan. I do not understand ultra compact syntax. I do not know operators precedence by heart. What I

Re: Resource.getURL() - example

2006-09-29 Thread Peter Reilly
On 9/29/06, Matt Benson [EMAIL PROTECTED] wrote: FYI all, this AM I did think of another point which heavily favors application-level resolution: we have already set a precedent for this with our handling of the antlib: pseudo-protocol. Spring also does application-level resolution: see:

VOTE: deferring resolving of references

2006-09-29 Thread Peter Reilly
Hi, I started a thead last week that did not end in a conclusion. should we defer resolving references until runtime: original message Currently in ant, there is two steps in processing a project build file, a parsing step and an execution step. In the parsing step a DOM like structure of

Re: Resource.getURL() - example

2006-09-29 Thread Matt Benson
Good point; I don't have to follow your link... I use classpath:... often enough. :) I must admit to having partaken of the Spring kool-aid... - Original Message From: Peter Reilly [EMAIL PROTECTED] To: Ant Developers List dev@ant.apache.org Sent: Friday, September 29, 2006 10:12:51

Re: VOTE: deferring resolving of references

2006-09-29 Thread Alexey Solofnenko
+1. This is one of illogical places left in ANT. - Alexey. On 9/29/06, Peter Reilly [EMAIL PROTECTED] wrote: Hi, I started a thead last week that did not end in a conclusion. should we defer resolving references until runtime: original message Currently in ant, there is two steps in

DO NOT REPLY [Bug 40632] - spawned process through exec task blocks parent exec task

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40632. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40641] New: - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: VOTE: deferring resolving of references

2006-09-29 Thread Matt Benson
+1 -Matt - Original Message From: Peter Reilly [EMAIL PROTECTED] To: Ant Developers List dev@ant.apache.org Sent: Friday, September 29, 2006 10:23:22 AM Subject: VOTE: deferring resolving of references Hi, I started a thead last week that did not end in a conclusion. should we defer

Re: VOTE: deferring resolving of references

2006-09-29 Thread Peter Reilly
Impact: It is a one-line change. Influence release of 1.7: I do not think so. (I think that we need to release an ant 1.7beta3 soon, freeze commits after that (or branch) and try to get as many users to try it out.) There are BC issues: some scripts may depend on references defined in tasks that

DO NOT REPLY [Bug 40642] New: - [PATCH] Ant.java support for command line options in a subbuild

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40642. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40643] New: - Allow dependency injection on child tasks

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40643. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: VOTE: deferring resolving of references

2006-09-29 Thread Martijn Kruithof
Peter Reilly wrote: Impact: It is a one-line change. Influence release of 1.7: I do not think so. (I think that we need to release an ant 1.7beta3 soon, freeze commits after that (or branch) and try to get as many users to try it out.) There are BC issues: some scripts may depend on references

DO NOT REPLY [Bug 40641] - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: deferring resolving of references

2006-09-29 Thread Antoine Levy-Lambert
Hi, +1 from me Antoine - Original Message - From: Peter Reilly [EMAIL PROTECTED] To: Ant Developers List dev@ant.apache.org Sent: Friday, September 29, 2006 5:23 PM Subject: VOTE: deferring resolving of references Hi, I started a thead last week that did not end in a conclusion.

DO NOT REPLY [Bug 40641] - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40641] - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Matt Benson
Peter said: In ant 1.8, all conditions will be resolved by using void add(Condition x), so tasks that want to have nested conditions just need to extend Task and implement add(Condition x). Wait... how? With componentdef? -Matt Peter

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Peter Reilly
On 9/29/06, Matt Benson [EMAIL PROTECTED] wrote: Peter said: In ant 1.8, all conditions will be resolved by using void add(Condition x), so tasks that want to have nested conditions just need to extend Task and implement add(Condition x). Wait... how? With componentdef? Perhaps, the

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Peter Reilly
On 9/29/06, Peter Reilly [EMAIL PROTECTED] wrote: On 9/29/06, Matt Benson [EMAIL PROTECTED] wrote: Peter said: In ant 1.8, all conditions will be resolved by using void add(Condition x), so tasks that want to have nested conditions just need to extend Task and implement

DO NOT REPLY [Bug 40641] - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: svn commit: r451000 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread Matt Benson
I asked because AFAIK we still haven't come to a decision regarding my look it up from the antlib DynamicElement hack in ConditionBase. -Matt - Original Message From: Peter Reilly [EMAIL PROTECTED] To: Ant Developers List dev@ant.apache.org Sent: Friday, September 29, 2006 12:30:52 PM

RE: Resource.getURL() - example

2006-09-29 Thread Stephen McConnell
-Original Message- From: Scott Stirling [mailto:[EMAIL PROTECTED] But when you encapsulate artifact location resolution into Java protocol handlers (which is what I think you're doing), you've made the build into something that, while, OK, not a black box, requires an

nodeps jar

2006-09-29 Thread Matt Benson
I'm curious why the launcher classes are in this jar. Do they really need to be? Additionally, any arguments against moving (while retaining API BC) some of the always-available optional tasks e.g. echoproperties to oata.taskdefs? -Matt

RE: Resource.getURL() - example

2006-09-29 Thread Stephen McConnell
-Original Message- From: Steve Loughran [mailto:[EMAIL PROTECTED] If we retrofit stuff into Java, with Java URL handling, then some URL like a reference to a file on the classpath, it would have to be turned into a string that included a classloader reference:

Re: Resource.getURL() - example

2006-09-29 Thread Stefan Bodewig
On Thu, 28 Sep 2006, Matt Benson [EMAIL PROTECTED] wrote: My current impression is that, partially contingent on Stephen's willingness to field questions, ;) the protocol-based solution is preferable, or at least worth _proving_ unsuitable. In any event, I'd like for us to reach a decision

svn commit: r451444 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/condition/ tests/junit/org/apache/tools/ant/

2006-09-29 Thread peterreilly
Author: peterreilly Date: Fri Sep 29 14:16:20 2006 New Revision: 451444 URL: http://svn.apache.org/viewvc?view=revrev=451444 Log: revert making ConditionBase a Task after discussion on [EMAIL PROTECTED] Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ConditionTask.java

svn commit: r451476 - in /ant/core/trunk/src: etc/testcases/core/unknownelement.xml tests/junit/org/apache/tools/ant/UnknownElementTest.java

2006-09-29 Thread peterreilly
Author: peterreilly Date: Fri Sep 29 15:17:24 2006 New Revision: 451476 URL: http://svn.apache.org/viewvc?view=revrev=451476 Log: test for unknownelement.maybecondifure Added: ant/core/trunk/src/etc/testcases/core/unknownelement.xml

svn commit: r451479 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/UnknownElement.java

2006-09-29 Thread peterreilly
Author: peterreilly Date: Fri Sep 29 15:23:38 2006 New Revision: 451479 URL: http://svn.apache.org/viewvc?view=revrev=451479 Log: UnknownElement.maybeconfigure was 'always configure': Bugzilla 40641 Modified: ant/core/trunk/WHATSNEW

DO NOT REPLY [Bug 40641] - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 40641] - UnknownElement.maybeConfigure() is really always configure

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40641. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: VOTE: deferring resolving of references

2006-09-29 Thread Dominique Devienne
On 9/29/06, Martijn Kruithof [EMAIL PROTECTED] wrote: Peter Reilly wrote: Impact: It is a one-line change. Influence release of 1.7: I do not think so. In that case +1 +1. --DD - To unsubscribe, e-mail: [EMAIL PROTECTED]

svn commit: r451487 - /ant/core/trunk/docs/manual/install.html

2006-09-29 Thread peterreilly
Author: peterreilly Date: Fri Sep 29 15:49:08 2006 New Revision: 451487 URL: http://svn.apache.org/viewvc?view=revrev=451487 Log: add a comment about /etc/ant.conf and about quotes and / in ANT_HOME,CLASSPATH and JAVA_HOME Modified: ant/core/trunk/docs/manual/install.html Modified:

DO NOT REPLY [Bug 40624] - Documentation misleading about use of ANT_HOME

2006-09-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=40624. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.