Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Dominique Devienne
2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: Note: I'll commit the unit test and doc I have wrote about this task. I don't want to enforce anything, just share the work I have done. It is still up to debate and can still be reverted. Well, process-wise we tend to discuss things out

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Stefan Bodewig
On 2010-11-09, hi...@apache.org wrote: Add a task to bind a target to an extension point. Might be controversial. What is the use-case? public void setTargets(String target) { String[] inputs = target.split(,); Wouldn't a nested element like ant's nested target be the better

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Nicolas Lalevée
Le 9 nov. 2010 à 13:39, Stefan Bodewig a écrit : On 2010-11-09, hi...@apache.org wrote: Add a task to bind a target to an extension point. Might be controversial. What is the use-case? It is helping when some build files are shared between projects. The use case is that I have some

Re: svn commit: r1032990 - in /ant/core/trunk: WHATSNEW docs/manual/tasklist.html src/main/org/apache/tools/ant/taskdefs/BindTargets.java src/main/org/apache/tools/ant/taskdefs/defaults.properties src

2010-11-09 Thread Dominique Devienne
On Tue, Nov 9, 2010 at 8:14 AM, hi...@apache.org wrote: +  target name=binded %s/binded/bound/g - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Matt Benson
On Nov 9, 2010, at 9:12 AM, Dominique Devienne wrote: 2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: Note: I'll commit the unit test and doc I have wrote about this task. I don't want to enforce anything, just share the work I have done. It is still up to debate and can still be

Re: svn commit: r1032931 - /ant/core/trunk/src/main/org/apache/tools/ant/Main.java

2010-11-09 Thread Matt Benson
On Nov 9, 2010, at 9:16 AM, Dominique Devienne wrote: On Tue, Nov 9, 2010 at 5:35 AM, hi...@apache.org wrote: +msg.append( depends of: ); That doesn't sound correct somehow. depends on ? dependent of/on ? Could native speakers chime in please? Thanks, --DD I

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Matt Benson
On Nov 9, 2010, at 9:12 AM, Dominique Devienne wrote: 2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: Note: I'll commit the unit test and doc I have wrote about this task. I don't want to enforce anything, just share the work I have done. It is still up to debate and can still be

Re: svn commit: r1032931 - /ant/core/trunk/src/main/org/apache/tools/ant/Main.java

2010-11-09 Thread Dominique Devienne
On Tue, Nov 9, 2010 at 5:35 AM, hi...@apache.org wrote: +                    msg.append(   depends of: ); That doesn't sound correct somehow. depends on ? dependent of/on ? Could native speakers chime in please? Thanks, --DD

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Nicolas Lalevée
Le 9 nov. 2010 à 16:27, Matt Benson a écrit : On Nov 9, 2010, at 9:12 AM, Dominique Devienne wrote: 2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: Note: I'll commit the unit test and doc I have wrote about this task. I don't want to enforce anything, just share the work I have

Re: svn commit: r1032990 - in /ant/core/trunk: WHATSNEW docs/manual/tasklist.html src/main/org/apache/tools/ant/taskdefs/BindTargets.java src/main/org/apache/tools/ant/taskdefs/defaults.properties src

2010-11-09 Thread Nicolas Lalevée
Le 9 nov. 2010 à 16:19, Dominique Devienne a écrit : On Tue, Nov 9, 2010 at 8:14 AM, hi...@apache.org wrote: + target name=binded %s/binded/bound/g argh, good catch. thanks. Nicolas - To unsubscribe, e-mail:

Re: svn commit: r1032931 - /ant/core/trunk/src/main/org/apache/tools/ant/Main.java

2010-11-09 Thread Nicolas Lalevée
Le 9 nov. 2010 à 16:23, Matt Benson a écrit : On Nov 9, 2010, at 9:16 AM, Dominique Devienne wrote: On Tue, Nov 9, 2010 at 5:35 AM, hi...@apache.org wrote: +msg.append( depends of: ); That doesn't sound correct somehow. depends on ? dependent of/on ? Could

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Dominique Devienne
2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: That's what I thought, this proposed task being quite trivial and having no side effect. Obviously for larger patch or behavior change I would come first to the ML, like I did for the project helpers for instance. Fair enough. A follow

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Nicolas Lalevée
Le 9 nov. 2010 à 17:34, Dominique Devienne a écrit : 2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: That's what I thought, this proposed task being quite trivial and having no side effect. Obviously for larger patch or behavior change I would come first to the ML, like I did for

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Nicolas Lalevée
Le 9 nov. 2010 à 17:39, Dominique Devienne a écrit : On Tue, Nov 9, 2010 at 10:34 AM, Dominique Devienne ddevie...@gmail.com wrote: The reason I'm a little reluctant on bindtargets is that it's a task that affects the dependency graph of targets, but bypassing the normal means to do that,

Re: svn commit: r1032922 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/BindTargets.java

2010-11-09 Thread Dominique Devienne
2010/11/9 Nicolas Lalevée nicolas.lale...@hibnet.org: From the doc you just checked in, I now read: +pThe bindtargets task may only be used as a top-level task. This means that +it may not be used in a target./p So maybe I was wrong. I didn't see the code enforcing that though? What

Re: issues with ant

2010-11-09 Thread Stefan Bodewig
On 2010-11-09, Ludmila Shikhvarg wrote: I've discovered some ant's problem during gump testing with jdk7 Thank you for reporting them. It might be a good idea to open bugzilla issues for them. 1. The projects below failed to compile with jdk7 (1.7.0): junit, test-junit ... [javac] javac: