Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/47
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/44
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/46
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/47
Similar to #44 we cannot change a public API and thus will not merge this
request.
In this particular case we even once changed it and had to revert the field
to be non-final as we broike the Ec
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/47
Add the "final" modifier to a public static field.
This static field public but not final, and could be changed by malicious
code or by accident from another package. The field could be made final t
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/46
Remove the redundant nullcheck of non-null values.
These statements contain redundant check of known non-null values against
the constant null.
http://findbugs.sourceforge.net/bugDescripti
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/45
Consider returning a zero length array rather than null.
It is often a better design to return a length zero array rather than a
null reference to indicate that there are no results (i.e., an empty
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/44
We've got pretty strict API backwards compatibilty rules, so we cannot
change the visibility of any elements that have been part of a release already
---
---
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/44
Remove the 'protected' modifier to make fields package protected.
The three mutable static fields could be changed by malicious code or by
accident. These fields could be made package protected to a