Re: [VOTE] Release Apache Ant 1.10.9 based on RC1

2020-09-29 Thread Stefan Bodewig
On 2020-09-29, Martijn Kruithof wrote: > - Fixed 2 typo's found (committed to master) Thank you. Fortunately it is easy to fix the online version of the manual, I'll make sure to include your changes to master when publishing the 1.10.9 manual. > - should reference to Rhino being available in j

RE: [VOTE] Release Apache Ant 1.10.9 based on RC1

2020-09-29 Thread Martijn Kruithof
Performed manual review only +1 But: - Fixed 2 typo's found (committed to master) - should reference to Rhino being available in java 7 runtime be removed from the manual (script.html) and should the system requirements in install be updated to reflect 1.10 series requires jdk 8? (preparing pul

[GitHub] [ant] jmkf merged pull request #136: Fixing new typos in running.html

2020-09-29 Thread GitBox
jmkf merged pull request #136: URL: https://github.com/apache/ant/pull/136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [ant] jmkf opened a new pull request #136: Fixing new typos in running.html

2020-09-29 Thread GitBox
jmkf opened a new pull request #136: URL: https://github.com/apache/ant/pull/136 While reviewing changeset 1.10.8 -> head This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [VOTE] Release Apache Ant 1.10.9 based on RC1

2020-09-29 Thread Jaikiran Pai
+1. - Downloaded apache-ant-1.10.9-bin.tar.gz - Checked the NOTICE file - Check some of the manuals in the downloaded binary - Built some internal projects using this new version All went fine. -Jaikiran On 27/09/20 3:58 pm, Stefan Bodewig wrote: > Hi all > > as mentioned in my last mail the

Re: Now Enabling Nashorn Compatibility

2020-09-29 Thread Jaikiran Pai
Hello Stefan, I went through these commits and they look fine to me. I think it's OK to set the system property to enable the compatibility. -Jaikiran On 26/09/20 12:51 am, Stefan Bodewig wrote: > Hi all > > things weren't as easy as I had hoped. You cannot enable Nashorn > compatibility via jav