Github user nlalevee commented on the issue:
https://github.com/apache/ant/pull/39
LGTM
+1 for merge
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/59
Yep, I fixed the configuration, I tried to launch a rebuild for this PR,
but it seems that rebuild on Jenkins doesn't take into account the PR, so I
aborted it.
---
If your project is set u
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/57
@twogee, you have looked into the open sources softwares that use Ivy, but
Ivy is under the ASL, not the GPL, it might be used in some closed, commercial
products :)
So we cannot know for sure
Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23071422
Probably. And rather than asking for it, it is often better to suggest a
patch.
---
If your project is set up for it, you can
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivyde/pull/6
Merged. The feature is now in master and will be available with the next
release.
Thank you very much Alexander!
---
If your project is set up for it, you can reply to this email and have
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/50
I have messed up a little bit the merge, I have merged the wrong branch,
but in the end everything is now merged, so we are now OK.
Thanks for the patch.
---
If your project is set up for it
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/36
The build-release.xml seems to be largely modified because of some space at
the end of xml tags. Could we avoid that ? It is painful to review and seems
useless.
---
If your project is set up for
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/33
In french we have "ssi" which is a contraction of "si et seulement si"
which has a mathematical meaning about absolute equivalence between two
propositions.
I bet that in
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/32
The job was configure to use the default Ant, which I don't know which is
exactly. So I have changed the conf to use Ant 1.9.9 (the same version that the
one declared in the ivy.xml of Ivy).
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
@twogee to properly add you to the list of contributors, do you confirm you
are
Gintautas Grigelionis ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
merged. Thank both of you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/30
I don't find the fix fully satisfying because it doesn't address the
fragile static set of circularDependencyId, it might produce some side effect
errors in the future. At least we shou
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/22
after many runs on my machine, I think I have found the actual issue. If
testRemoveDuplicates is run after testRemoveDuplicates2, then it fails. It
seems due to the fact that
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
So let's get out of scope of this PR the support of weird characters in
version, organisation or module name. Especially since the set of supported
characters depends on the filesystem, whi
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
I agree with you both.
Ivy has never specified a version scheme, and it is kind of its strength,
it can be compatible with a lot of use case. We should continue to do so.
But we shouldn&#
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/20
I have increased the timeout to 20m
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/pull/8#issuecomment-136174610
It seems to break badly Ivy on Windows. I tried to launch the test with a
fresh checkout of your PR, and Ivy could not even resolve dependencies.
Here are the
Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/pull/6#issuecomment-136152918
I have implemented it with two properties, ivy.maven.sources.lookup and
ivy.maven.javadoc.lookup, which defaults to true
Thanks for the PR
---
If your project is
Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/pull/7#issuecomment-136139712
Merged. Thank you for the pull request. Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/pull/3#issuecomment-69492990
merged. Thanks for the patch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nlalevee commented on the pull request:
https://github.com/apache/ant-ivy/pull/5#issuecomment-69492417
merged. Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
21 matches
Mail list logo
