[GitHub] [ant] twogee commented on issue #110: Backport magic names

2019-11-06 Thread GitBox
twogee commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-550197106 I believe that the proposed changes have a merit, and I split the commit to reduce the scope. This is an

[GitHub] [ant] twogee commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
twogee commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549706237 I'd like to keep the PR open and see if it generates more interest, if you don't mind. This is an

[GitHub] [ant] twogee commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
twogee commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549702330 The rationale for revision of MagicNames/MagicTestNames is threefold: - make the use of special property names/constants explicit; - establish a single