Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Merged that, thanks.
Hint for future PRs: smaller are better (easier to review)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
I mean, why use an NPE when one can have an assertion that fails? It's a
cleaner approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
That's exactly why I introduced assertNotNull :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Nop ... yes. You're right with 'null instanceof SomeClass'==true.
But the two assertions are different:
moduleId = null;
assertFalse(moduleId.equals(null);; --> this will throw a
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Sorry for getting carried away with diamonds ð... I put back
`assertFalse(moduleId.equals(null));`
but that assertion is equivalent to
`assertFalse(null instanceOf ModuleId)`
which
