[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-03-01 Thread jonl-percsolutions-com
Github user jonl-percsolutions-com commented on the issue: https://github.com/apache/ant-ivyde/pull/7 @jaikiran Your fix is much better. I did not understand enough about the code to see whether or not it was intentional for those to be MenuManager objects or not. I have updated to

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivyde/pull/7 @jonl-percsolutions-com Thank you for reporting the issue and then raising this PR. I looked at the changes in this PR and it looks like this change will silently ignore items that aren't of type

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivyde/pull/7 Sorry about a loose remark and for pursuing the deprecations [overagressively](https://github.com/apache/ant-ivyde/commit/d2983ea950fc93daa2db8bb6ef17958450fd34e3). What I would appreciate is

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivyde/pull/7 >> There is a regression in URLHandler to be dealt with Actually, that's not a regression. It's a fix to a regression that I introduced in one of the snapshots. 2.4.x had `openStream`

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread jonl-percsolutions-com
Github user jonl-percsolutions-com commented on the issue: https://github.com/apache/ant-ivyde/pull/7 I believe I did it correctly and it is now rebased. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivyde/pull/7 Could you please rebase on the latest master? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional

[GitHub] ant-ivyde issue #7: Fix IVYDE-386

2018-02-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivyde/pull/7 There is a [regression](https://github.com/apache/ant-ivy/commit/ae27582d1ba0cb6c2b18d30a81cb1b82033069c3) in URLHandler to be dealt with ``` [pde-build] [javac] schemaStream =