Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

Strangely the test passes when I run it manually on the VM running Gump. I'll look into it further but am running out of time for now. Stefan On 2017-12-13, Jaikiran Pai wrote: > Do let me know if there's anything I can do to help investigate > this. I'm curious myself to see what's causing this

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

Do let me know if there's anything I can do to help investigate this. I'm curious myself to see what's causing this. -Jaikiran On 13/12/17 2:56 AM, Stefan Bodewig wrote: On 2017-12-12, Stefan Bodewig wrote: On 2017-12-12, Jaikiran Pai wrote: So the one final test that's still failing is th

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

On 2017-12-12, Stefan Bodewig wrote: > On 2017-12-12, Jaikiran Pai wrote: >> So the one final test that's still failing is this one[1]. It's >> failing consistently only on Jenkins, that too with only Java 8 >> (jdk1.8.0_131). I have tried reproducing that one locally with that >> exact Java vers

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

On 2017-12-12, Jaikiran Pai wrote: > So the one final test that's still failing is this one[1]. It's > failing consistently only on Jenkins, that too with only Java 8 > (jdk1.8.0_131). I have tried reproducing that one locally with that > exact Java version and even the latest Java 8 and haven't b

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

So the one final test that's still failing is this one[1]. It's failing consistently only on Jenkins, that too with only Java 8 (jdk1.8.0_131). I have tried reproducing that one locally with that exact Java version and even the latest Java 8 and haven't been able to reproduce it. Before I try a

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

On 2017-12-12, Jaikiran Pai wrote: >>> So I have now pushed a fix[1] on top of my previous changes, which >>> should accommodate both these use cases (and continue to use Java 7 >>> APIs for symlinking). >> This is very useful, many thanks. We may want to modify the manual so it >> becomes clear t

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

So I have now pushed a fix[1] on top of my previous changes, which should accommodate both these use cases (and continue to use Java 7 APIs for symlinking). This is very useful, many thanks. We may want to modify the manual so it becomes clear that overwrite will replace regular files as well.

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

On 2017-12-12, Jaikiran Pai wrote: > I went back and read up both these bugzilla reports again and I now > realize that supporting one doesn't necessarily mean not supporting > the other. BZ-43426 is about letting existing file be overwritten > (irrespective of the type of the file) if the overwri

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

I went back and read up both these bugzilla reports again and I now realize that supporting one doesn't necessarily mean not supporting the other. BZ-43426 is about letting existing file be overwritten (irrespective of the type of the file) if the overwrite flag is true. BZ-58683 is about not o

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

[@Steve I'm trying to drag you in as you've been the one who brought in the change that gets contested by https://bz.apache.org/bugzilla/show_bug.cgi?id=58683 and maybe you recall the details better than we do.] On 2017-12-10, Jaikiran Pai wrote: > On 10/12/17 3:09 PM, Stefan Bodewig wrote: >> On

Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

On 10/12/17 3:09 PM, Stefan Bodewig wrote: On 2017-12-10, Jaikiran Pai wrote: I'll investigate why this is failing (local tests pass for me) and fix it. Target testCreateOverFile in the antunit test explicitly tries to replace a file with a link, doing exactly what the bugzilla report says i

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

You are right, that indeed was the issue (for one of that failing test). I have pushed a commit with this change to fix that one. -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla/sh

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

On 2017-12-10, Stefan Bodewig wrote: > testCreateDoubleHanging is related to > https://bz.apache.org/bugzilla/show_bug.cgi?id=38199 judging from the > history. Here the link points to a non-existent file and Files.exists > returns false in Java8. fixed by @@ -37,6 +37,7 @@ import java.io.IOExcep

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

On 2017-12-10, Jaikiran Pai wrote: > I'll investigate why this is failing (local tests pass for me) and fix it. Are you using Java9 locally? The test only fail for Java8 in Jenkins, this could explain the difference. The antunit tests fail for me with Java 8 as well, while the JUnit test passes.

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

I'll investigate why this is failing (local tests pass for me) and fix it. -Jaikiran On 10/12/17 2:29 PM, Apache Jenkins Server wrote: See -