Re: PR-33: problems

2017-05-29 Thread Matt Sicker
ules will be > painful considering the wide API Ivy is exposing. > > Nicolas > > > > > > > > > Jan > > > >> -Ursprüngliche Nachricht- > >> Von: J Pai [mailto:jai.forums2...@gmail.com] > >> Gesendet: Montag, 29. Mai 2017 10

Re: PR-33: problems

2017-05-29 Thread Nicolas Lalevée
chricht- >> Von: J Pai [mailto:jai.forums2...@gmail.com] >> Gesendet: Montag, 29. Mai 2017 10:26 >> An: Ant Developers List >> Betreff: Re: PR-33: problems >> >> IMO, for each of these public classes/methods/fields that we are fixing >> for typos, we should m

Re: PR-33: problems

2017-05-29 Thread Nicolas Lalevée
igelio...@gmail.com] >> Gesendet: Montag, 29. Mai 2017 11:00 >> An: Ant Developers List >> Betreff: Re: PR-33: problems >> >> If it's acceptable I'll complement the PR addressing all the points. >> >> Gintas >> >> Den 29 maj 2017 10:13 skrev &qu

Re: PR-33: problems

2017-05-29 Thread Gintautas Grigelionis
If it's acceptable I'll complement the PR addressing all the points. Gintas Den 29 maj 2017 10:13 skrev "Jan Matèrne" : I did a review of https://github.com/apache/ant-ivy/pull/33 Here are the points I have problems with, so I want

Re: PR-33: problems

2017-05-29 Thread J Pai
IMO, for each of these public classes/methods/fields that we are fixing for typos, we should mark them @Deprecated (and add a @deprecated javadoc too and point to the new field/method/class) and introduce the rightly named class/method/field. For methods it’s straightforward, the deprecated