Re: cvs commit: ant/src/main/org/apache/tools/ant/util OutputStreamFunneler.java

2005-01-24 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > Matt Benson wrote: [SNIP] > > > >Just curious, why bother making a private inner > class > >final? > > > > > To stop checkstyle from whining! > The construtor was private and in this case > checkstyle whines that the > class should > be final as it

Re: cvs commit: ant/src/main/org/apache/tools/ant/util OutputStreamFunneler.java

2005-01-24 Thread Peter Reilly
Matt Benson wrote: --- [EMAIL PROTECTED] wrote: peterreilly2005/01/24 07:30:32 Modified:src/main/org/apache/tools/ant/util OutputStreamFunneler.java [SNIP] -private class Funnel extends OutputStream { +private final class Funnel extends OutputStream { Just curi

Re: cvs commit: ant/src/main/org/apache/tools/ant/util OutputStreamFunneler.java

2005-01-24 Thread Matt Benson
--- [EMAIL PROTECTED] wrote: > peterreilly2005/01/24 07:30:32 > > Modified:src/main/org/apache/tools/ant/util > OutputStreamFunneler.java [SNIP] > > -private class Funnel extends OutputStream { > +private final class Funnel extends > OutputStream { Just curious, why bo