[GitHub] ant-ivy pull request #51: Fix some string comparisons with ==

2017-07-06 Thread chinhodado 
GitHub user chinhodado opened a pull request:

https://github.com/apache/ant-ivy/pull/51

Fix some string comparisons with ==



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chinhodado/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit 6544faf31651216a0a9188a6b3223b2412ecc68d
Author: Trung Do 
Date:   2017-07-06T23:31:36Z

Fix some string comparisons with ==




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [2/2] ant-ivy git commit: Generate automatically the copyright year in the doc

2017-07-06 Thread Nicolas Lalevée 
Templates updated. I used the same range as the one in the NOTICE file.

Nicolas

> Le 6 juil. 2017 à 12:38, Gintautas Grigelionis  a 
> écrit :
> 
> I put 2007 in javadoc :-)
> 
> Gintas
> 
> 2017-07-06 12:01 GMT+02:00 Matèrne, Jan (RZF, Ref 410) <
> jan.mate...@fv.nrw.de>:
> 
>> Haven't searched for the 'right' year.
>> 2008 was the year from an early 2.0.0-beta-Release.
>> But I think you got my point. ;)
>> 
>> Jan
>> 
>> 
>> -Ursprüngliche Nachricht-
>> Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com]
>> Gesendet: Donnerstag, 6. Juli 2017 10:15
>> An: Ant Developers List
>> Betreff: Re: [2/2] ant-ivy git commit: Generate automatically the
>> copyright year in the doc
>> 
>> I believe Ivy graduated in 2007?
>> 
>> Gintas
>> 
>> 2017-07-06 8:10 GMT+02:00 Matèrne, Jan (RZF, Ref 410) <
>> jan.mate...@fv.nrw.de
>>> :
>> 
>>> AFAIK in other locations we use a range of time.
>>> Should that be used here too?
>>> 
>>>  | Copyright  2008 -
>>>  = " " + Time.now.year.to_s + " "
>>>  | The Apache Software Foundation, Licensed under the a href="
>>> http://www.apache.org/licenses/; Apache License, Version 2.0.
>>> 
>>> 
>>> Jan
>>> 
>>> -Ursprüngliche Nachricht-
>>> Von: hi...@apache.org [mailto:hi...@apache.org]
>>> Gesendet: Mittwoch, 5. Juli 2017 22:15
>>> An: notificati...@ant.apache.org
>>> Betreff: [2/2] ant-ivy git commit: Generate automatically the copyright
>>> year in the doc
>>> 
>>> Generate automatically the copyright year in the doc
>>> 
>>> 
>>> Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/a12daf30
>>> Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/a12daf30
>>> Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/a12daf30
>>> 
>>> Branch: refs/heads/master
>>> Commit: a12daf3088cd295e30e36ce1c48416b3308e0943
>>> Parents: fc6305a
>>> Author: Nicolas Laleve??e 
>>> Authored: Wed Jul 5 22:13:46 2017 +0200
>>> Committer: Nicolas Laleve??e 
>>> Committed: Wed Jul 5 22:13:46 2017 +0200
>>> 
>>> --
>>> asciidoc/templates/book/document.html.slim | 4 +++-
>>> asciidoc/templates/document.html.slim  | 4 +++-
>>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>> --
>>> 
>>> 
>>> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
>>> a12daf30/asciidoc/templates/book/document.html.slim
>>> --
>>> diff --git a/asciidoc/templates/book/document.html.slim
>>> b/asciidoc/templates/book/document.html.slim
>>> index 126676e..8541fcf 100644
>>> --- a/asciidoc/templates/book/document.html.slim
>>> +++ b/asciidoc/templates/book/document.html.slim
>>> @@ -42,7 +42,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
>>>   div id="footer-message" class="footer"
>>> hr/
>>> i
>>> -  | Copyright  2017 The Apache Software Foundation,
>>> Licensed under the
>>> +  | Copyright 
>>> +  = " " + Time.now.year.to_s + " "
>>> +  | The Apache Software Foundation, Licensed under the
>>>   a href="http://www.apache.org/licenses/; Apache License,
>>> Version 2.0
>>>   | .
>>> br/
>>> 
>>> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
>>> a12daf30/asciidoc/templates/document.html.slim
>>> --
>>> diff --git a/asciidoc/templates/document.html.slim
>>> b/asciidoc/templates/document.html.slim
>>> index 5a8bd92..776221a 100644
>>> --- a/asciidoc/templates/document.html.slim
>>> +++ b/asciidoc/templates/document.html.slim
>>> @@ -79,7 +79,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
>>>   div id="footer-message" class="footer"
>>> hr/
>>> i
>>> -  | Copyright  2017 The Apache Software Foundation,
>>> Licensed under the
>>> +  | Copyright 
>>> +  = " " + Time.now.year.to_s + " "
>>> +  | The Apache Software Foundation, Licensed under the
>>>   a href="http://www.apache.org/licenses/; Apache License,
>>> Version 2.0
>>>   | .
>>> br/
>>> 
>>> 
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>>> For additional commands, e-mail: dev-h...@ant.apache.org
>>> 
>>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [2/2] ant-ivy git commit: Generate automatically the copyright year in the doc

2017-07-06 Thread Gintautas Grigelionis 
I put 2007 in javadoc :-)

Gintas

2017-07-06 12:01 GMT+02:00 Matèrne, Jan (RZF, Ref 410) <
jan.mate...@fv.nrw.de>:

> Haven't searched for the 'right' year.
> 2008 was the year from an early 2.0.0-beta-Release.
> But I think you got my point. ;)
>
> Jan
>
>
> -Ursprüngliche Nachricht-
> Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com]
> Gesendet: Donnerstag, 6. Juli 2017 10:15
> An: Ant Developers List
> Betreff: Re: [2/2] ant-ivy git commit: Generate automatically the
> copyright year in the doc
>
> I believe Ivy graduated in 2007?
>
> Gintas
>
> 2017-07-06 8:10 GMT+02:00 Matèrne, Jan (RZF, Ref 410) <
> jan.mate...@fv.nrw.de
> >:
>
> > AFAIK in other locations we use a range of time.
> > Should that be used here too?
> >
> >   | Copyright  2008 -
> >   = " " + Time.now.year.to_s + " "
> >   | The Apache Software Foundation, Licensed under the a href="
> > http://www.apache.org/licenses/; Apache License, Version 2.0.
> >
> >
> > Jan
> >
> > -Ursprüngliche Nachricht-
> > Von: hi...@apache.org [mailto:hi...@apache.org]
> > Gesendet: Mittwoch, 5. Juli 2017 22:15
> > An: notificati...@ant.apache.org
> > Betreff: [2/2] ant-ivy git commit: Generate automatically the copyright
> > year in the doc
> >
> > Generate automatically the copyright year in the doc
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/a12daf30
> > Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/a12daf30
> > Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/a12daf30
> >
> > Branch: refs/heads/master
> > Commit: a12daf3088cd295e30e36ce1c48416b3308e0943
> > Parents: fc6305a
> > Author: Nicolas Laleve??e 
> > Authored: Wed Jul 5 22:13:46 2017 +0200
> > Committer: Nicolas Laleve??e 
> > Committed: Wed Jul 5 22:13:46 2017 +0200
> >
> > --
> >  asciidoc/templates/book/document.html.slim | 4 +++-
> >  asciidoc/templates/document.html.slim  | 4 +++-
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > --
> >
> >
> > http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
> > a12daf30/asciidoc/templates/book/document.html.slim
> > --
> > diff --git a/asciidoc/templates/book/document.html.slim
> > b/asciidoc/templates/book/document.html.slim
> > index 126676e..8541fcf 100644
> > --- a/asciidoc/templates/book/document.html.slim
> > +++ b/asciidoc/templates/book/document.html.slim
> > @@ -42,7 +42,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
> >div id="footer-message" class="footer"
> >  hr/
> >  i
> > -  | Copyright  2017 The Apache Software Foundation,
> > Licensed under the
> > +  | Copyright 
> > +  = " " + Time.now.year.to_s + " "
> > +  | The Apache Software Foundation, Licensed under the
> >a href="http://www.apache.org/licenses/; Apache License,
> > Version 2.0
> >| .
> >  br/
> >
> > http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
> > a12daf30/asciidoc/templates/document.html.slim
> > --
> > diff --git a/asciidoc/templates/document.html.slim
> > b/asciidoc/templates/document.html.slim
> > index 5a8bd92..776221a 100644
> > --- a/asciidoc/templates/document.html.slim
> > +++ b/asciidoc/templates/document.html.slim
> > @@ -79,7 +79,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
> >div id="footer-message" class="footer"
> >  hr/
> >  i
> > -  | Copyright  2017 The Apache Software Foundation,
> > Licensed under the
> > +  | Copyright 
> > +  = " " + Time.now.year.to_s + " "
> > +  | The Apache Software Foundation, Licensed under the
> >a href="http://www.apache.org/licenses/; Apache License,
> > Version 2.0
> >| .
> >  br/
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> > For additional commands, e-mail: dev-h...@ant.apache.org
> >
> >
>

AW: [2/2] ant-ivy git commit: Generate automatically the copyright year in the doc

2017-07-06 Thread RZF, Ref 410 
Haven't searched for the 'right' year.
2008 was the year from an early 2.0.0-beta-Release.
But I think you got my point. ;)

Jan


-Ursprüngliche Nachricht-
Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com] 
Gesendet: Donnerstag, 6. Juli 2017 10:15
An: Ant Developers List
Betreff: Re: [2/2] ant-ivy git commit: Generate automatically the copyright 
year in the doc

I believe Ivy graduated in 2007?

Gintas

2017-07-06 8:10 GMT+02:00 Matèrne, Jan (RZF, Ref 410) :

> AFAIK in other locations we use a range of time.
> Should that be used here too?
>
>   | Copyright  2008 -
>   = " " + Time.now.year.to_s + " "
>   | The Apache Software Foundation, Licensed under the a href="
> http://www.apache.org/licenses/; Apache License, Version 2.0.
>
>
> Jan
>
> -Ursprüngliche Nachricht-
> Von: hi...@apache.org [mailto:hi...@apache.org]
> Gesendet: Mittwoch, 5. Juli 2017 22:15
> An: notificati...@ant.apache.org
> Betreff: [2/2] ant-ivy git commit: Generate automatically the copyright
> year in the doc
>
> Generate automatically the copyright year in the doc
>
>
> Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
> Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/a12daf30
> Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/a12daf30
> Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/a12daf30
>
> Branch: refs/heads/master
> Commit: a12daf3088cd295e30e36ce1c48416b3308e0943
> Parents: fc6305a
> Author: Nicolas Laleve??e 
> Authored: Wed Jul 5 22:13:46 2017 +0200
> Committer: Nicolas Laleve??e 
> Committed: Wed Jul 5 22:13:46 2017 +0200
>
> --
>  asciidoc/templates/book/document.html.slim | 4 +++-
>  asciidoc/templates/document.html.slim  | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
> a12daf30/asciidoc/templates/book/document.html.slim
> --
> diff --git a/asciidoc/templates/book/document.html.slim
> b/asciidoc/templates/book/document.html.slim
> index 126676e..8541fcf 100644
> --- a/asciidoc/templates/book/document.html.slim
> +++ b/asciidoc/templates/book/document.html.slim
> @@ -42,7 +42,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
>div id="footer-message" class="footer"
>  hr/
>  i
> -  | Copyright  2017 The Apache Software Foundation,
> Licensed under the
> +  | Copyright 
> +  = " " + Time.now.year.to_s + " "
> +  | The Apache Software Foundation, Licensed under the
>a href="http://www.apache.org/licenses/; Apache License,
> Version 2.0
>| .
>  br/
>
> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
> a12daf30/asciidoc/templates/document.html.slim
> --
> diff --git a/asciidoc/templates/document.html.slim
> b/asciidoc/templates/document.html.slim
> index 5a8bd92..776221a 100644
> --- a/asciidoc/templates/document.html.slim
> +++ b/asciidoc/templates/document.html.slim
> @@ -79,7 +79,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
>div id="footer-message" class="footer"
>  hr/
>  i
> -  | Copyright  2017 The Apache Software Foundation,
> Licensed under the
> +  | Copyright 
> +  = " " + Time.now.year.to_s + " "
> +  | The Apache Software Foundation, Licensed under the
>a href="http://www.apache.org/licenses/; Apache License,
> Version 2.0
>| .
>  br/
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>

Re: [2/2] ant-ivy git commit: Generate automatically the copyright year in the doc

2017-07-06 Thread Gintautas Grigelionis 
I believe Ivy graduated in 2007?

Gintas

2017-07-06 8:10 GMT+02:00 Matèrne, Jan (RZF, Ref 410) :

> AFAIK in other locations we use a range of time.
> Should that be used here too?
>
>   | Copyright  2008 -
>   = " " + Time.now.year.to_s + " "
>   | The Apache Software Foundation, Licensed under the a href="
> http://www.apache.org/licenses/; Apache License, Version 2.0.
>
>
> Jan
>
> -Ursprüngliche Nachricht-
> Von: hi...@apache.org [mailto:hi...@apache.org]
> Gesendet: Mittwoch, 5. Juli 2017 22:15
> An: notificati...@ant.apache.org
> Betreff: [2/2] ant-ivy git commit: Generate automatically the copyright
> year in the doc
>
> Generate automatically the copyright year in the doc
>
>
> Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
> Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/a12daf30
> Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/a12daf30
> Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/a12daf30
>
> Branch: refs/heads/master
> Commit: a12daf3088cd295e30e36ce1c48416b3308e0943
> Parents: fc6305a
> Author: Nicolas Laleve??e 
> Authored: Wed Jul 5 22:13:46 2017 +0200
> Committer: Nicolas Laleve??e 
> Committed: Wed Jul 5 22:13:46 2017 +0200
>
> --
>  asciidoc/templates/book/document.html.slim | 4 +++-
>  asciidoc/templates/document.html.slim  | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
> a12daf30/asciidoc/templates/book/document.html.slim
> --
> diff --git a/asciidoc/templates/book/document.html.slim
> b/asciidoc/templates/book/document.html.slim
> index 126676e..8541fcf 100644
> --- a/asciidoc/templates/book/document.html.slim
> +++ b/asciidoc/templates/book/document.html.slim
> @@ -42,7 +42,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
>div id="footer-message" class="footer"
>  hr/
>  i
> -  | Copyright  2017 The Apache Software Foundation,
> Licensed under the
> +  | Copyright 
> +  = " " + Time.now.year.to_s + " "
> +  | The Apache Software Foundation, Licensed under the
>a href="http://www.apache.org/licenses/; Apache License,
> Version 2.0
>| .
>  br/
>
> http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/
> a12daf30/asciidoc/templates/document.html.slim
> --
> diff --git a/asciidoc/templates/document.html.slim
> b/asciidoc/templates/document.html.slim
> index 5a8bd92..776221a 100644
> --- a/asciidoc/templates/document.html.slim
> +++ b/asciidoc/templates/document.html.slim
> @@ -79,7 +79,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
>div id="footer-message" class="footer"
>  hr/
>  i
> -  | Copyright  2017 The Apache Software Foundation,
> Licensed under the
> +  | Copyright 
> +  = " " + Time.now.year.to_s + " "
> +  | The Apache Software Foundation, Licensed under the
>a href="http://www.apache.org/licenses/; Apache License,
> Version 2.0
>| .
>  br/
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>

AW: [2/2] ant-ivy git commit: Generate automatically the copyright year in the doc

2017-07-06 Thread RZF, Ref 410 
AFAIK in other locations we use a range of time.
Should that be used here too?

  | Copyright  2008 - 
  = " " + Time.now.year.to_s + " "
  | The Apache Software Foundation, Licensed under the a 
href="http://www.apache.org/licenses/; Apache License, Version 2.0.


Jan

-Ursprüngliche Nachricht-
Von: hi...@apache.org [mailto:hi...@apache.org] 
Gesendet: Mittwoch, 5. Juli 2017 22:15
An: notificati...@ant.apache.org
Betreff: [2/2] ant-ivy git commit: Generate automatically the copyright year in 
the doc

Generate automatically the copyright year in the doc


Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/a12daf30
Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/a12daf30
Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/a12daf30

Branch: refs/heads/master
Commit: a12daf3088cd295e30e36ce1c48416b3308e0943
Parents: fc6305a
Author: Nicolas Laleve??e 
Authored: Wed Jul 5 22:13:46 2017 +0200
Committer: Nicolas Laleve??e 
Committed: Wed Jul 5 22:13:46 2017 +0200

--
 asciidoc/templates/book/document.html.slim | 4 +++-
 asciidoc/templates/document.html.slim  | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/a12daf30/asciidoc/templates/book/document.html.slim
--
diff --git a/asciidoc/templates/book/document.html.slim 
b/asciidoc/templates/book/document.html.slim
index 126676e..8541fcf 100644
--- a/asciidoc/templates/book/document.html.slim
+++ b/asciidoc/templates/book/document.html.slim
@@ -42,7 +42,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
   div id="footer-message" class="footer"
 hr/
 i
-  | Copyright  2017 The Apache Software Foundation, Licensed 
under the
+  | Copyright 
+  = " " + Time.now.year.to_s + " "
+  | The Apache Software Foundation, Licensed under the
   a href="http://www.apache.org/licenses/; Apache License, Version 2.0
   | .
 br/

http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/a12daf30/asciidoc/templates/document.html.slim
--
diff --git a/asciidoc/templates/document.html.slim 
b/asciidoc/templates/document.html.slim
index 5a8bd92..776221a 100644
--- a/asciidoc/templates/document.html.slim
+++ b/asciidoc/templates/document.html.slim
@@ -79,7 +79,9 @@ html lang=(attr :lang, 'en' unless attr? :nolang)
   div id="footer-message" class="footer"
 hr/
 i
-  | Copyright  2017 The Apache Software Foundation, Licensed 
under the
+  | Copyright 
+  = " " + Time.now.year.to_s + " "
+  | The Apache Software Foundation, Licensed under the
   a href="http://www.apache.org/licenses/; Apache License, Version 2.0
   | .
 br/


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org