my €.02 : currently, all resolvers only have artifact patterns as child
elements, so I'd rather have the timeouts as attributes that might use
references, similarly to cache managers or latest strategies. That would
imply a global default that may be overridden individually.
Gintas
2017-07-14
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/52
I committed proposed changes w/o contains(). Please let me know if should
amend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127480601
--- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java ---
@@ -306,7 +306,7 @@ public boolean isClosedRange() {
return
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127475255
--- Diff:
src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java ---
@@ -148,7 +142,7 @@ public void put(File source, String destination,
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127474316
--- Diff:
src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java ---
@@ -148,7 +142,7 @@ public void put(File source, String destination,
https://issues.apache.org/jira/browse/IVY-735 is a feature request where
the users have asked for relevant timeouts while dealing with downloads.
A few weeks back we had a very brief discussion in an unrelated mail
where it was proposed that we allow configuring these timeout all the
way from
https://issues.apache.org/jira/browse/IVY-735 is a feature request where the
users have asked for relevant timeouts while dealing with downloads. A few
weeks back we had a very brief discussion in an unrelated mail where it was
proposed that we allow configuring these timeout all the way from
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/52
Thanks! I will revert the changes regarding the checked exceptions as
suggested in a separate commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127408025
--- Diff:
src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java ---
@@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/52
I've reviewed this PR and apart from the review comments noted, the rest of
the changes look fine. Please only include any review comments related changes
to this PR, from now on. Else it's going
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127398802
--- Diff: src/java/org/apache/ivy/util/url/HttpClientHandler.java ---
@@ -177,7 +177,7 @@ public URLInfo getURLInfo(URL url, int timeout) {
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127398451
--- Diff:
src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java ---
@@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127397658
--- Diff: src/java/org/apache/ivy/plugins/repository/ssh/SshCache.java ---
@@ -263,9 +263,8 @@ public void clearSession(Session session) {
*
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127397389
--- Diff:
src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java ---
@@ -148,7 +142,7 @@ public void put(File source, String destination,
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127396424
--- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java ---
@@ -306,7 +306,7 @@ public boolean isClosedRange() {
return
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127396341
--- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java
---
@@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127396320
--- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java
---
@@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127395825
--- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java
---
@@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) {
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127395788
--- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java
---
@@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) {
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/52#discussion_r127395633
--- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java ---
@@ -19,12 +19,11 @@
import java.io.IOException;
import
20 matches
Mail list logo
