Re: Proposed changes for IVY-735 - Ability to specify timeouts

The support for this feature is now available. Given that this is kind of a core and relatively big change, I decided to open a PR[1] so that some of us can take a look to make sure the changes make sense. The description in the PR plus the documentation in the commit explains how this works,

Re: Opportunities for cohesion improvement and refatoring.

Hi thank you, Gintautas. Yes, using a tool to verify the API hasn't changed will probably help. Over in Commons we run this as a regular part of the release process - it is even more important for things that are meant to be re-usable components, of course. I'm afraid that won't be enough,

[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers

GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/54 IVY-735 Support timeouts on resolvers The commit in this PR adds support for specifying connection and read timeouts for resolvers, so that users have control over how the resolvers behave when

Re: Opportunities for cohesion improvement and refatoring.

Thanks, Stefan. You're right about the semantics; I did not mean the API compatibility analysis to give a complete answer, rather a hint about the amount of (potential) breakage. Based on that, a decision can be taken whether it can be accepted, mitigated or a completely new version is a must. If

Re: Opportunities for cohesion improvement and refatoring.

Yes, using the tool might be a good first indicator. I didn't mean to imply you called the tools a complete answer, just wanted to clarify my own words :-) Stefan On 2017-07-21, Gintautas Grigelionis wrote: > Thanks, Stefan. You're right about the semantics; I did not mean the API >

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT; would that require an additional timeout attribute? --- If your project is set up for it, you can reply to this email and

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 The PR contains additional changes to HttpClientHandler, introducing HttpConnectionManagerParams, which is not available in Commons HTTP Client version 2 (over 10 years old and virtually gone). It

Re: Opportunities for cohesion improvement and refatoring.

Hi everyone. I will prepare the suggestions for changes. Regarding the discussion above, the following classes are the best choices: Javadoc, FTPTask, FileUtils ok? 2017-07-21 12:10 GMT-03:00 Stefan Bodewig : > Yes, using the tool might be a good first indicator. > > I

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 JSch Session has a single (connection) timeout. There is a GitHub project to mock ssh/sftp server based on Mina at https://github.com/shamsoftware/sham-ssh --- If your project is set up for it,