[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task
Github user jnsnkrllive commented on a diff in the pull request:
https://github.com/apache/ant/pull/64#discussion_r202096699
--- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
@@ -413,6 +429,16 @@ public void execute() throws BuildException {
sb.append("\" ");
}
+if (useExtension) {
+sb.append("-ext ");
--- End diff --
Good question. I did some testing and here's what I found:
keytool would fail if we pass "-ext" without a name.
`keytool -genkey -alias "keystorename" -keystore "keystorename" -storepass
"secret" -keypass "secret" -ext`
> Command option -ext needs an argument.
However, we won't ever append "-ext" without also appending a name too.
Currently the only way to append "-ext" is when useExtension is true, which
only happens if the sname attribute is included in the definition AND the java
version is 1.7 or higher.
keytool works fine if the saname attribute is not included in the
definition. "useExtension" would be false (because "setSaname" would never get
called) and it'd skip over the code block beginning on line 432.
However, keytool throws an exception if saname="" is used in the definition
`[genkey] keytool error: java.lang.Exception: Illegal item in san=`
This definition of the task doesn't meet the requirements specified by
keytool. Should ant handle this differently or defer to keytool for handing the
invalid use? It doesn't look like we are doing any special validation on the
other arguments (e.g. "sigalg" which is just a string in this Task but keytool
only accepts certain values for that string).
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #63: Replace JAI with ImageIO
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/63 or live without any UML diagram :-) - no, I don't think we've got anything but the image. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/64#discussion_r202054728
--- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
@@ -413,6 +429,16 @@ public void execute() throws BuildException {
sb.append("\" ");
}
+if (useExtension) {
+sb.append("-ext ");
--- End diff --
Should this be appended only if `saname` is not null? I haven't given it a
try but does the keytool work fine if we end up passing "-ext" without any
extension name value?
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/64 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/64/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/64 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/70/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/64 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Ant 1.10.5 based on RC1
+1 > Le 10 juil. 2018 à 11:55, Stefan Bodewig a écrit : > > Hi all > > I've created a new release candidate for 1.10.5 with a few bug fixes and > and the "single source executable" feature for Java11. > > git tag: ANT_1.10.5_RC1 > on commit: c0848d2c6 > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > revision: 28015 > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant-1035/org/apache/ant/ > > This Vote will be open at least for 72 hours and close no earlier than > 2018-07-13 10:00UTC. > > Cheers > >Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Ant 1.9.13 based on RC1
+1 > Le 10 juil. 2018 à 11:56, Stefan Bodewig a écrit : > > Hi all > > I've created a new release candidate for 1.9.13 with a few bug fixes. > > git tag: ANT_1.9.13_RC1 > on commit: e7a4d8683 > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > revision: 28014 > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant-1034/org/apache/ant/ > > This Vote will be open at least for 72 hours and close no earlier than > 2018-07-13 10:00UTC. > > Cheers > >Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Ant 1.10.5 based on RC1
+1 (non-binding) I ran the Groovy test suite against the candidate jars and everything passed. There are over 100 tests related to AntBuilder and the groovy, groovyc, groovydoc ant tasks. Cheers, Paul. On Tue, Jul 10, 2018 at 7:55 PM Stefan Bodewig wrote: > Hi all > > I've created a new release candidate for 1.10.5 with a few bug fixes and > and the "single source executable" feature for Java11. > > git tag: ANT_1.10.5_RC1 > on commit: c0848d2c6 > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > revision: 28015 > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant-1035/org/apache/ant/ > > This Vote will be open at least for 72 hours and close no earlier than > 2018-07-13 10:00UTC. > > Cheers > > Stefan > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
