[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...

[aprelev]

Github user aprelev commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/73#discussion_r207675516
  
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -193,16 +193,8 @@ public void startElement(String uri, String localName, 
String qName,
 String branch = attributes.getValue("branch");
 String revision = attributes.getValue("revision");
 Map extraAttributes = new 
HashMap<>();
--- End diff --

It was, until I reused code for attributes extraction from 
`ExtendableItemHelper`. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...

[twogee]

Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant-ivy/pull/73#discussion_r207669472
  
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -193,16 +193,8 @@ public void startElement(String uri, String localName, 
String qName,
 String branch = attributes.getValue("branch");
 String revision = attributes.getValue("revision");
 Map extraAttributes = new 
HashMap<>();
--- End diff --

Is this Map used?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #73: IVY-1104 Include attributes qualifiers in the XML report

[aprelev]

Github user aprelev commented on the issue:

https://github.com/apache/ant-ivy/pull/73
  
Okay, I've implemented robust ASN.1-like encoding as
```
prefix* qualifierLength separator qualifier* separator* name
```
such as `extra-3.foo-bar` for `foo:bar`, and `extra-0.foo` for `foo`, which 
is up for review.

P.S. Also, point me in the right direction regarding XSLT.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org