[GitHub] [ant] mguillem commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
mguillem commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549413724 The failed test doesn't seem to be related to this PR. Is it possible that it is an issue in the CI system?

[GitHub] [ant] jaikiran commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
jaikiran commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549415291 @mguillem You can ignore that failure. That test is known to fail from time to time. This PR looks OK to me and if no one

[GitHub] [ant-ivy] twogee commented on issue #90: Java 8

2019-11-04 Thread GitBox
twogee commented on issue #90: Java 8 URL: https://github.com/apache/ant-ivy/pull/90#issuecomment-549552112 Looks like JDK must be updated in Jenkins... This is an automated message from the Apache Git Service. To respond to

[GitHub] [ant] asf-ci commented on issue #109: Backport magic names

2019-11-04 Thread GitBox
asf-ci commented on issue #109: Backport magic names URL: https://github.com/apache/ant/pull/109#issuecomment-549673127 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/141/

[GitHub] [ant] jaikiran commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
jaikiran commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549675188 What's the context behind proposing these changes to 1.9.x branch? This is an automated message

[GitHub] [ant] asf-ci commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
asf-ci commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549675066 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/142/

[GitHub] [ant-ivy] jaikiran commented on issue #90: Java 8

2019-11-04 Thread GitBox
jaikiran commented on issue #90: Java 8 URL: https://github.com/apache/ant-ivy/pull/90#issuecomment-549651024 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [ant] jaikiran commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
jaikiran commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549653706 @mguillem I've merged your patch. Thank you for contributing this. I forgot to include a comment in the git commit message

[GitHub] [ant] asf-ci commented on issue #109: Backport magic names

2019-11-04 Thread GitBox
asf-ci commented on issue #109: Backport magic names URL: https://github.com/apache/ant/pull/109#issuecomment-549673732 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/147/

[GitHub] [ant] twogee opened a new pull request #110: Backport magic names

2019-11-04 Thread GitBox
twogee opened a new pull request #110: Backport magic names URL: https://github.com/apache/ant/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [ant] twogee closed pull request #109: Backport magic names

2019-11-04 Thread GitBox
twogee closed pull request #109: Backport magic names URL: https://github.com/apache/ant/pull/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ant] twogee opened a new pull request #109: Backport magic names

2019-11-04 Thread GitBox
twogee opened a new pull request #109: Backport magic names URL: https://github.com/apache/ant/pull/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [ant] mguillem commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
mguillem commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549682482 @jaikiran thanks for quickly applying my PR. Closing. This

[GitHub] [ant] mguillem closed pull request #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
mguillem closed pull request #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [ant] asf-ci commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
asf-ci commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549675920 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/148/

[GitHub] [ant] twogee edited a comment on issue #110: Backport magic names

2019-11-04 Thread GitBox
twogee edited a comment on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549702330 The rationale for revision of MagicNames/MagicTestNames is threefold: - make the use of special property names/constants explicit; - establish a single

[GitHub] [ant] twogee commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
twogee commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549702330 The rationale for revision of MagicNames/MagicTestNames is threefold: - make the use of special property names/constants explicit; - establish a single

[GitHub] [ant] jaikiran commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
jaikiran commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549703246 1.9.x branch is meant only for very limited changes. We don't have any plans to introduce changes like these in that branch.

[GitHub] [ant] twogee commented on issue #110: Backport magic names

2019-11-04 Thread GitBox
twogee commented on issue #110: Backport magic names URL: https://github.com/apache/ant/pull/110#issuecomment-549706237 I'd like to keep the PR open and see if it generates more interest, if you don't mind. This is an

[GitHub] [ant] asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549320692 Refer to this link for build results (access rights to CI server needed):

[GitHub] [ant] asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549312827 Can one of the admins verify this patch? This is an automated

[GitHub] [ant] asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549312829 Can one of the admins verify this patch? This is an automated

[GitHub] [ant] bodewig commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
bodewig commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549317753 this is ok to test This is an automated message from the

[GitHub] [ant] asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll

2019-11-04 Thread GitBox
asf-ci commented on issue #108: junitlaucher legacy-xml: don't loose exception from @BeforeAll URL: https://github.com/apache/ant/pull/108#issuecomment-549321120 Refer to this link for build results (access rights to CI server needed):