arturobernalg commented on a change in pull request #158:
URL: https://github.com/apache/ant/pull/158#discussion_r716154780
##
File path: src/tests/junit/org/apache/tools/ant/util/DeweyDecimalTest.java
##
@@ -107,10 +107,10 @@ public void isGreaterThanOrEqual() {
@Test
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
arturobernalg commented on a change in pull request #157:
URL: https://github.com/apache/ant/pull/157#discussion_r716156789
##
File path: src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
##
@@ -94,9 +94,8 @@ private int moveArgFileEligibleOptionsToEnd(String[
arturobernalg commented on a change in pull request #155:
URL: https://github.com/apache/ant/pull/155#discussion_r716157501
##
File path: src/main/org/apache/tools/ant/taskdefs/XmlProperty.java
##
@@ -404,17 +404,14 @@ public Object processNode(Node node, String prefix,
Object
bodewig merged pull request #158:
URL: https://github.com/apache/ant/pull/158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig commented on pull request #158:
URL: https://github.com/apache/ant/pull/158#issuecomment-927263448
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
bodewig merged pull request #157:
URL: https://github.com/apache/ant/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig commented on pull request #157:
URL: https://github.com/apache/ant/pull/157#issuecomment-927263551
Thank you @arturobernalg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bodewig merged pull request #155:
URL: https://github.com/apache/ant/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig merged pull request #156:
URL: https://github.com/apache/ant/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig commented on pull request #160:
URL: https://github.com/apache/ant/pull/160#issuecomment-927281071
Thank you @arturobernalg. I must admit at least I am not a friend of a pull
request that touches 41 unrelated files.
Some of your changes I'm not really happy with. Broadly
bodewig commented on pull request #138:
URL: https://github.com/apache/ant/pull/138#issuecomment-927281536
@twogee the switch to jakarta.mail is not backwards compatible. I don't
think we can do it that way at all. Rather we'll need to introduce a new type
of Mailer and an additional jar w
On 19/09/21 3:30 pm, Stefan Bodewig wrote:
On 2021-09-16, Stefan Bodewig wrote:
On 2021-09-15, Jaikiran Pai wrote:
I wanted to look into and sort out
https://bz.apache.org/bugzilla/show_bug.cgi?id=65424 in this release
too, but it looks like I may not be able to do that and I'm not sure
how
arturobernalg commented on pull request #160:
URL: https://github.com/apache/ant/pull/160#issuecomment-927323463
HI @bodewig
Thank you for your response. Sorry for the 41 files. I'll close the PR and
create another one keeping in mind your remarks.
TY
--
This is an automated messa
arturobernalg closed pull request #160:
URL: https://github.com/apache/ant/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
15 matches
Mail list logo