[GitHub] [ant] jaikiran commented on pull request #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox
jaikiran commented on PR #195: URL: https://github.com/apache/ant/pull/195#issuecomment-1318135936 > I'll also check why my testing of my previous commit didn't catch the 1.8 version issue For the record - one of the test jobs did catch this issue for 1.8 version, I just hadn't

[GitHub] [ant] jaikiran merged pull request #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox
jaikiran merged PR #195: URL: https://github.com/apache/ant/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] [ant] jaikiran commented on pull request #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox
jaikiran commented on PR #195: URL: https://github.com/apache/ant/pull/195#issuecomment-1317878895 Thank you @keithc-ca for this change. I will run some CI test before merging (I'll also check why my testing of my previous commit didn't catch the 1.8 version issue). -- This is an

[GitHub] [ant] keithc-ca opened a new pull request, #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox
keithc-ca opened a new pull request, #195: URL: https://github.com/apache/ant/pull/195 The existing use of `tr` doesn't distinguish between Java 8 and Java 18; see https://github.com/apache/ant/commit/bbe6859b2f57a2c9dcb51e269527f3c18a74aa1d#commitcomment-90131350 - this fixes that. --

Release Ant 1.10.13?

2022-11-16 Thread Jaikiran Pai
Hello everyone, We last released Ant more than a year back. During that period we have had some good amount of bug fixes and changes that have gone in. Plus, Java 18 and beyond was released in the meantime where setting the security manager isn't allowed by default (Ant sets it). Users can