DO NOT REPLY [Bug 18637] New: - defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637

defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

   Summary: defaultexcludes not works with zip,tar,jar tasks or bag
with CVS directories
   Product: Ant
   Version: 1.5.3
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


try to zip something with CVS directories, archive does not contain them.


cvs commit: ant/xdocs/stylesheets templates.vm

2003-04-03 Thread conor
conor   2003/04/02 20:13:49

  Modified:docs index.html page.css
   xdocs/stylesheets templates.vm
  Log:
  More CSS based layout
  
  Revision  ChangesPath
  1.273 +6 -6  ant/docs/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/ant/docs/index.html,v
  retrieving revision 1.272
  retrieving revision 1.273
  diff -u -w -u -r1.272 -r1.273
  --- index.html3 Apr 2003 04:00:18 -   1.272
  +++ index.html3 Apr 2003 04:13:48 -   1.273
  @@ -81,10 +81,10 @@
 div class=menucontainer
   div class=menu
 ul
  -  lifont color=#CFDCEDApache Ant/font
  +  li class=menuheaderApache Ant
 ul
   li
  -  span class=selfont 
color=#ffcc00Welcome/font/span
  +  span class=selWelcome/span
 /li
   li
   a href=./license.htmlLicense/a
  @@ -94,7 +94,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDDocumentation/font
  +  li class=menuheaderDocumentation
 ul
   li
   a href=./manual/index.htmlManual/a
  @@ -116,7 +116,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDDownload/font
  +  li class=menuheaderDownload
 ul
   li
   a 
href=http://ant.apache.org/bindownload.cgi;Binary Distributions/a
  @@ -126,7 +126,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDGet Involved/font
  +  li class=menuheaderGet Involved
 ul
   li
   a href=./mail.htmlMailing Lists/a
  @@ -142,7 +142,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDProject Management/font
  +  li class=menuheaderProject Management
 ul
   li
   a 
href=./contributors.htmlContributors/a
  
  
  
  1.7   +8 -0  ant/docs/page.css
  
  Index: page.css
  ===
  RCS file: /home/cvs/ant/docs/page.css,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -w -u -r1.6 -r1.7
  --- page.css  3 Apr 2003 04:00:19 -   1.6
  +++ page.css  3 Apr 2003 04:13:48 -   1.7
  @@ -33,6 +33,14 @@
   .menu ul ul li .sel { list-style-image: url('images/current.gif'); 
font-weight : normal; }
   .menu ul ul li  { list-style-image: url('images/page.gif'); font-weight : 
normal; }
   
  +.menuheader {
  +color: #CFDCED;
  +}
  +
  +.sel {
  +color: #ffcc00;
  +}
  +
   .tab { font-size : 85%; border: 0 }
   .tab a:link {   text-decoration : none;  }
   .tab a:visited { text-decoration : none; color: #2A4A6D }
  
  
  
  1.22  +2 -2  ant/xdocs/stylesheets/templates.vm
  
  Index: templates.vm
  ===
  RCS file: /home/cvs/ant/xdocs/stylesheets/templates.vm,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -w -u -r1.21 -r1.22
  --- templates.vm  3 Apr 2003 04:00:22 -   1.21
  +++ templates.vm  3 Apr 2003 04:13:48 -   1.22
  @@ -220,14 +220,14 @@
   div class=menu
 ul
 #foreach ( $menu in $menus )
  -lifont color=$blue1$menu.getAttributeValue(name)/font
  +li class=menuheader$menu.getAttributeValue(name)
 ul
   #foreach ( $item in $menu.getChildren() )
 #set ($name = $item.getAttributeValue(name))
 #set ($current = 
$root.getChild(properties).getChild(title).getText() )
   li
 #if ( $current.trim().equals( $name ) )
  -span class=selfont color=$active$name/font/span
  +span class=sel$name/span
 #else
   #projectanchor($name $item.getAttributeValue(href))
 #end
  
  
  


cvs commit: ant/docs/projects/antidote design.html index.html module.html

2003-04-03 Thread conor
conor   2003/04/02 20:14:44

  Modified:docs ant15_todo.html antnews.html bindownload.html
contributors.html cvs.html external.html faq.html
guidelines.html legal.html license.html mail.html
mission.html problems.html projects.html
resources.html srcdownload.html
   docs/projects index.html
   docs/projects/antidote design.html index.html module.html
  Log:
  Regen all files
  
  Revision  ChangesPath
  1.36  +5 -5  ant/docs/ant15_todo.html
  
  Index: ant15_todo.html
  ===
  RCS file: /home/cvs/ant/docs/ant15_todo.html,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -w -u -r1.35 -r1.36
  --- ant15_todo.html   3 Apr 2003 04:00:17 -   1.35
  +++ ant15_todo.html   3 Apr 2003 04:14:40 -   1.36
  @@ -79,7 +79,7 @@
 div class=menucontainer
   div class=menu
 ul
  -  lifont color=#CFDCEDApache Ant/font
  +  li class=menuheaderApache Ant
 ul
   li
   a href=./index.htmlWelcome/a
  @@ -92,7 +92,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDDocumentation/font
  +  li class=menuheaderDocumentation
 ul
   li
   a href=./manual/index.htmlManual/a
  @@ -114,7 +114,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDDownload/font
  +  li class=menuheaderDownload
 ul
   li
   a 
href=http://ant.apache.org/bindownload.cgi;Binary Distributions/a
  @@ -124,7 +124,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDGet Involved/font
  +  li class=menuheaderGet Involved
 ul
   li
   a href=./mail.htmlMailing Lists/a
  @@ -140,7 +140,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDProject Management/font
  +  li class=menuheaderProject Management
 ul
   li
   a 
href=./contributors.htmlContributors/a
  
  
  
  1.64  +6 -6  ant/docs/antnews.html
  
  Index: antnews.html
  ===
  RCS file: /home/cvs/ant/docs/antnews.html,v
  retrieving revision 1.63
  retrieving revision 1.64
  diff -u -w -u -r1.63 -r1.64
  --- antnews.html  3 Apr 2003 04:00:18 -   1.63
  +++ antnews.html  3 Apr 2003 04:14:41 -   1.64
  @@ -83,7 +83,7 @@
 div class=menucontainer
   div class=menu
 ul
  -  lifont color=#CFDCEDApache Ant/font
  +  li class=menuheaderApache Ant
 ul
   li
   a href=./index.htmlWelcome/a
  @@ -92,11 +92,11 @@
   a href=./license.htmlLicense/a
   /li
   li
  -  span class=selfont 
color=#ffcc00News/font/span
  +  span class=selNews/span
 /li
 /ul
   /li
  -  lifont color=#CFDCEDDocumentation/font
  +  li class=menuheaderDocumentation
 ul
   li
   a href=./manual/index.htmlManual/a
  @@ -118,7 +118,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDDownload/font
  +  li class=menuheaderDownload
 ul
   li
   a 
href=http://ant.apache.org/bindownload.cgi;Binary Distributions/a
  @@ -128,7 +128,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDGet Involved/font
  +  li class=menuheaderGet Involved
 ul
   li
   a href=./mail.htmlMailing Lists/a
  @@ -144,7 +144,7 @@
   /li
 /ul
   /li
  -  lifont color=#CFDCEDProject Management/font
  +  li class=menuheaderProject Management
 ul
   li
   a 
href=./contributors.htmlContributors/a
  
  
  
  1.24  

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs JarTest.java

2003-04-03 Thread bodewig
bodewig 2003/04/02 22:06:01

  Modified:src/testcases/org/apache/tools/ant/taskdefs JarTest.java
  Log:
  Demonstrate bug 16972
  
  Revision  ChangesPath
  1.22  +1 -1  
ant/src/testcases/org/apache/tools/ant/taskdefs/JarTest.java
  
  Index: JarTest.java
  ===
  RCS file: 
/home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/JarTest.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- JarTest.java  2 Apr 2003 16:20:13 -   1.21
  +++ JarTest.java  3 Apr 2003 06:06:00 -   1.22
  @@ -256,7 +256,7 @@
   }
   
   // bugzilla report 16972
  -public void XtestRootFilesInIndex() throws IOException {
  +public void testRootFilesInIndex() throws IOException {
   ZipFile archive = null;
   try {
   executeTarget(testIndexTests);
  
  
  


Re: Using files in classpath in task file=

2003-04-03 Thread Stefan Bodewig
On Wed, 02 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote:

 If I had it in jars I could ship it automatically with the jar that
 has the task that generated index.xml, so I can easily do something
 like:
 
   xslt in=index.xml out=index.html
 style=resource:/a/style.xsl/

I see.  What I don't see is how we could use an URI here without
breaking backwards compatibility.

In XSLTProcess we get the style parameter via setStyle(File), this
obviously cannot be called with anything else but a file object.  If
we wanted general URIs, we'd have to change the signature and break
custom tasks that inherit from or delegate to instances of
XSLTProcess.  No way.

I'd rather propose to add an alternative attribute styleURI or
something to XSLTProcess.

 Be able to specify a URL for every task that needs a file, and that
 thus uses the above fileutils method.

Again, not without changing the tasks to use something else, not File,
in their setter method and thus severely breaking backwards
compatibility.

 Or maybe KISS and just add a getStyleResource(String
 styleResource). It solves the immediate issue and doesn't open other
 potential problems.

Seems the better way to me - at least until we are prepared to break
API compatibility on almost all tasks at once 8-)

Stefan


cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Jar.java

2003-04-03 Thread bodewig
bodewig 2003/04/02 22:41:51

  Modified:.WHATSNEW
   src/main/org/apache/tools/ant/taskdefs Jar.java
  Log:
  Improve standards compliance of created index.
  
  PR: 16972
  
  Revision  ChangesPath
  1.387 +3 -0  ant/WHATSNEW
  
  Index: WHATSNEW
  ===
  RCS file: /home/cvs/ant/WHATSNEW,v
  retrieving revision 1.386
  retrieving revision 1.387
  diff -u -r1.386 -r1.387
  --- WHATSNEW  2 Apr 2003 16:01:15 -   1.386
  +++ WHATSNEW  3 Apr 2003 06:41:50 -   1.387
  @@ -84,6 +84,9 @@
   
   * jar index=on could include multiple index lists.  Bugzilla 10262.
   
  +* The index created by jar didn't conform to the spec as it didn't
  +  include the top-level entries.  Bugzilla Report 16972.
  +
   Other changes:
   --
   * Shipped XML parser is now Xerces 2.4.0
  
  
  
  1.74  +28 -7 ant/src/main/org/apache/tools/ant/taskdefs/Jar.java
  
  Index: Jar.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Jar.java,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- Jar.java  2 Apr 2003 16:01:15 -   1.73
  +++ Jar.java  3 Apr 2003 06:41:51 -   1.74
  @@ -67,6 +67,7 @@
   import java.io.PrintWriter;
   import java.io.Reader;
   import java.util.Enumeration;
  +import java.util.Vector;
   import java.util.zip.ZipEntry;
   import java.util.zip.ZipFile;
   import org.apache.tools.ant.BuildException;
  @@ -145,12 +146,24 @@
*/
   private boolean createEmpty = false;
   
  +/**
  + * Stores all files that are in the root of the archive (i.e. that
  + * have a name that doesn't contain a slash) so they can get
  + * listed in the index.
  + *
  + * Will not be filled unless the user has asked for an index.
  + *
  + * @since Ant 1.6
  + */
  +private Vector rootEntries;
  +
   /** constructor */
   public Jar() {
   super();
   archiveType = jar;
   emptyBehavior = create;
   setEncoding(UTF8);
  +rootEntries = new Vector();
   }
   
   /**
  @@ -458,6 +471,11 @@
   writer.println(dir);
   }
   
  +enum = rootEntries.elements();
  +while (enum.hasMoreElements()) {
  +writer.println(enum.nextElement());
  +}
  +
   writer.flush();
   ByteArrayInputStream bais =
   new ByteArrayInputStream(baos.toByteArray());
  @@ -480,6 +498,9 @@
   +  files include a META-INF/INDEX.LIST which will
   +  be replaced by a newly generated one., 
Project.MSG_WARN);
   } else {
  +if (index  vPath.indexOf(/) == -1) {
  +rootEntries.addElement(vPath);
  +}
   super.zipFile(is, zOut, vPath, lastModified, fromArchive, mode);
   }
   }
  @@ -663,13 +684,13 @@
   super.cleanUp();
   
   // we want to save this info if we are going to make another pass
  -if (! doubleFilePass || (doubleFilePass  ! skipWriting))
  -{
  -manifest = null;
  -configuredManifest = savedConfiguredManifest;
  -filesetManifest = null;
  -originalManifest = null;
  -}
  +if (! doubleFilePass || (doubleFilePass  ! skipWriting)) {
  +manifest = null;
  +configuredManifest = savedConfiguredManifest;
  +filesetManifest = null;
  +originalManifest = null;
  +}
  +rootEntries.removeAllElements();
   }
   
   /**
  
  
  


DO NOT REPLY [Bug 16972] - Jar task incorrectly builds INDEX.LIST entries.

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16972.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16972

Jar task incorrectly builds INDEX.LIST entries.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 06:43 ---
should be fixed in nightly buil,d 2003-04-04.


DO NOT REPLY [Bug 18637] - defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637

defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 07:09 ---
And it shouldn't.

I'm not sure I understand your report, could you please exapnd a little?


DO NOT REPLY [Bug 17807] - antlr test fails

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17807.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17807

antlr test fails





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 07:16 ---
So test8 fails for you because there ain't no exception at all.

Again, is this CVS HEAD?  Are you absolutely sure 8-)  You may need to bootstrap
Ant.  What you see is supposed to be fixed with revision 1.21 of ANTLR.java.


DO NOT REPLY [Bug 18605] - XML parser factory nas not been configured correctly

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18605.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18605

XML parser factory nas not been configured correctly





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 07:39 ---
Thanks. 

I have tried with Java 1.2 and It works OK.


DO NOT REPLY [Bug 14849] - JProbe tasks: executables cannot be found with JProbe 4.0.1

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14849.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14849

JProbe tasks: executables cannot be found with JProbe 4.0.1





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 08:20 ---
as for the executables, you're right, they are now in jprobe.home/bin

coverage.jar is now in jprobe.home/lib/coverage.jar .

Best regards,
Jan


DO NOT REPLY [Bug 18642] New: - StackOverflow when antcall calls a target which uses input

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642

StackOverflow when antcall calls a target which uses input

   Summary: StackOverflow when antcall calls a target which uses
input
   Product: Ant
   Version: 1.6Alpha (nightly)
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Given the buildfile

?xml version=1.0 encoding=ISO-8859-1?
project name=antutil default=show
target name=test1
antcall target=test2/
/target

target name=test2
input/
/target
/project

a StackOverflow will encounter if target test1 is invoked. Invoking test2 
works:

c:\temp\ant test1

test1:

test2:


BUILD FAILED
java.lang.StackOverflowError
at java.lang.Thread.currentThread(Native Method)
at org.apache.tools.ant.Project.demuxInput(Project.java:1330)
at org.apache.tools.ant.taskdefs.Ant.handleInput(Ant.java:307)
at org.apache.tools.ant.taskdefs.CallTarget.handleInput
(CallTarget.java:197)
at org.apache.tools.ant.UnknownElement.handleInput
(UnknownElement.java:168)
at org.apache.tools.ant.Project.demuxInput(Project.java:1334)
at org.apache.tools.ant.DemuxInputStream.read(DemuxInputStream.java:98)
at org.apache.tools.ant.Project.defaultInput(Project.java:1312)
at org.apache.tools.ant.Task.handleInput(Task.java:330)
at org.apache.tools.ant.UnknownElement.handleInput
(UnknownElement.java:168)
at org.apache.tools.ant.Project.demuxInput(Project.java:1334)
at org.apache.tools.ant.taskdefs.Ant.handleInput(Ant.java:307)
...


Encountered with Apache Ant version 1.6alpha compiled on February 27 2003.
Testing with Nightly Build.

...

Yes, verified on Apache Ant version 1.6alpha compiled on April 2 2003.


DO NOT REPLY [Bug 14849] - JProbe tasks: executables cannot be found with JProbe 4.0.1

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14849.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14849

JProbe tasks: executables cannot be found with JProbe 4.0.1

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 08:51 ---
OK, I've added another assumption, namely that the executables are .exe and not
.bat or something else on Windows.

Could you please either build the CVS HEAD version of Ant (or try nightly build
2003-04-04) to confirm that it works for you now?

I'll ask on the dev list to find people running older JProbe versions that I
haven't broken anything.


Need JProbe testers

2003-04-03 Thread Stefan Bodewig
Hi,

I've modified the JProbe tasks in a way that they now should
autodetect and even work with JProbe 4.x.

As I don't run any version of JProbe, I'd like to have people who
currently run the JProbe tasks successfully (with older version of
JProbe) to either bootstrap the CVS HEAD version of Ant or try the
nightly build 2003-04-04 (not the not yet published -04-03, my commit
won't be in there) to confirm that I haven't broken any existing
functionality.

Many thanks

Stefan


DO NOT REPLY [Bug 18648] New: - zip still creates invalid file (NOT FIXED IN 1.5.3Beta1)

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18648.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18648

zip still creates invalid file (NOT FIXED IN 1.5.3Beta1)

   Summary: zip still creates invalid file (NOT FIXED IN
1.5.3Beta1)
   Product: Ant
   Version: 1.5.3
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Version 1.5.2 was broken regarding zip files. Version 1.5.3Beta1 fixed only 
part of the problem.

When creating zip files, the files are created with invalid size. WinZip does 
not show it, but the WinZip command line does. The WinZip command line can be 
downloaded at: http://www.winzip.com/wzcline.htm. Just download ans see.

More information is below.

thanks,
  Doron.


The version:
  D:\Development\song\dev\songant -version
  Apache Ant version 1.5.3Beta1 compiled on March 24 2003

The zip command:
  zip destfile=JavaGA_Source_${song.timeStamp}.zip basedir=${tempdir} 
includes=**/


When unzipping:


D:\kkwzunzip -D JavaGA_Source_20030402183401.zip
WinZip(R) Command Line Support Add-On Version 1.0 (Build 3181)
Copyright (c) WinZip Computing, Inc. 1991-2000 - All Rights Reserved

Zip file: JavaGA_Source_20030402183401.zip

...
unzipping doc/Java GA Library Block Diagram 2003-03-24.doc
Warning: the size of the extracted file (25600) does not match the uncompressed 
size (0) recorded in the zip file
unzipping doc/Java GA Library implementation 2003-03-24.doc
Warning: the size of the extracted file (51200) does not match the uncompressed 
size (0) recorded in the zip file
unzipping src/cmp.bat
Warning: the size of the extracted file (50) does not match the uncompressed 
size (0) recorded in the zip file
unzipping src/com/schema/ga/Analyzer.java
Warning: the size of the extracted file (1366) does not match the uncompressed 
size (0) recorded in the zip file
unzipping src/com/schema/ga/analyzers/AnalyzerBase.java
Warning: the size of the extracted file (913) does not match the uncompressed 
size (0) recorded in the zip file
unzipping src/com/schema/ga/analyzers/Standard.java
Warning: the size of the extracted file (2307) does not match the uncompressed 
size (0) recorded in the zip file
unzipping src/com/schema/ga/Crossover.java
...


DO NOT REPLY [Bug 18637] - defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637

defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 10:01 ---
Directory for example ant CVS snapshot:
...
build.xml
check.xml
CVS
docs
docs.xml
...
ant task
zip destfile=ant.zip basedir=ant defaultexcludes=false/
resulting archive does not contain CVS directory !!!

posible fix in class org.apache.tools.ant.taskdefs.Zip
in function executeMain()
if (baseDir != null) {
FileSet fs = (FileSet) getImplicitFileSet().clone();
fs.setDefaultexcludes(useDefaultExcludes);  //Add this string
fs.setDir(baseDir);
vfss.addElement(fs);
}
This is solution only for zip task the same problem exists for tar, jar tasks
(and may be others)


DO NOT REPLY [Bug 18642] - StackOverflow when antcall calls a target which uses input

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642

StackOverflow when antcall calls a target which uses input





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 10:06 ---
relevant part of the stack trace:

at org.apache.tools.ant.Project.getThreadTask(Project.java:2148)
at org.apache.tools.ant.Project.demuxInput(Project.java:1330)
at org.apache.tools.ant.taskdefs.Ant.handleInput(Ant.java:307)
at 
org.apache.tools.ant.taskdefs.CallTarget.handleInput(CallTarget.java:197)
at 
org.apache.tools.ant.UnknownElement.handleInput(UnknownElement.java:171)
at org.apache.tools.ant.Project.demuxInput(Project.java:1334)
at org.apache.tools.ant.DemuxInputStream.read(DemuxInputStream.java:98)
at org.apache.tools.ant.Project.defaultInput(Project.java:1312)
at org.apache.tools.ant.Task.handleInput(Task.java:330)
at 
org.apache.tools.ant.UnknownElement.handleInput(UnknownElement.java:171)
at org.apache.tools.ant.Project.demuxInput(Project.java:1334)


DO NOT REPLY [Bug 18637] - defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637

defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
   Target Milestone|--- |1.6


defaultexcludes in MatchingTask

2003-04-03 Thread Stefan Bodewig
Can anybody imagine/remember why MatchingTask#setDefaultExcludes does
not set the corresponding value on the implicit fileset but defers
that to getDirectoryScanner()?

Stefan


DO NOT REPLY [Bug 18637] - defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637

defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 10:11 ---
OK, I see the problem.

As a workaround, don't use basedir but a nested fileset and set the 
defaultexcludes
on the nested fileset.


DO NOT REPLY [Bug 18642] - StackOverflow when antcall calls a target which uses input

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642

StackOverflow when antcall calls a target which uses input

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 11:06 ---
I'll check this out.


DO NOT REPLY [Bug 18648] - zip still creates invalid file (NOT FIXED IN 1.5.3Beta1)

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18648.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18648

zip still creates invalid file (NOT FIXED IN 1.5.3Beta1)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 11:34 ---
I can confirm the report of Doron Rajwan.


I also have narrowed the problem a bit.


The error message does not show up when one uses the compress=false attribute 
when building the zip file.


When compress=true (the default) the following lines of code are not called 
in 
Zip.java#zipFile(InputStream in, ZipOutputStream zOut, String vPath,


   long lastModified, File fromArchive, int mode) 


ze.setSize(size);


ze.setCrc(cal.getValue());


DO NOT REPLY [Bug 18648] - zip still creates invalid file (NOT FIXED IN 1.5.3Beta1)

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18648.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18648

zip still creates invalid file (NOT FIXED IN 1.5.3Beta1)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 11:43 ---
But they get called in ZipOutputStream#closeEntry.

Like I said, it is leagl to set size and compressed size to zero in the LFH for
compressed files and we simply do so.


DO NOT REPLY [Bug 18656] New: - Rename recursively

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18656.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18656

Rename recursively

   Summary: Rename recursively
   Product: Ant
   Version: 1.5.1
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The problem I see is how to rename files and directories recursively that match 
with a pattern.
Rename task is deprecated. I've tried to use move with mapper but when find a 
file or directory, make another one with the correct name but empty (and 
keeping the original).


DO NOT REPLY [Bug 18402] - add support for a new target attribute finally

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18402.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18402

add support for a new target attribute finally





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 14:00 ---
Have you take a look at the trycatch/ task in antcontrib?
I think it allows you to write exactly what you want with clear semantics.

target name=mytask depends=init 
  trycatch
try /try
finally
  antcall target=cleanup/ 
/finally
  trycatch
/target

Are you proposing something with a meaning different than this one?


DO NOT REPLY [Bug 17807] - antlr test fails

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17807.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17807

antlr test fails





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 14:15 ---
Sorry, it was my fault. After bootstrapping again, the testcase passed.


DO NOT REPLY [Bug 15729] - StarTeam rootLocalFolder should be java.io.File

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15729.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15729

StarTeam rootLocalFolder should be java.io.File





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 14:26 ---
My two cents:

Anything in ANT that is suppose to point to a file or directory is by 
convention assumed to be relative to ${basedir} (unless you specify a full 
path). By having the parameter be of type File, ANT takes care of this 
transparently.

Using CWD for relative files means that buildfiles cannot be used correctly
when called ant from one another.

It seem not only worth, but a bug not to work that way.


jdepend error

2003-04-03 Thread Conor MacNeill
The version of jdepend I have hanging around for building Ant is not 
compatible with the recent changes

home/conor/development/apache/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java:450:
 
cannot resolve symbol
symbol  : method setFilter (jdepend.framework.PackageFilter)
location: class jdepend.textui.JDepend
jdepend.setFilter(new jdepend.framework.PackageFilter(v));
   ^

Just FYI ...

Conor

-- 
Conor MacNeill
Blog: http://codefeed.com/blog/


Re: jdepend error

2003-04-03 Thread Stefan Bodewig
On Fri, 4 Apr 2003, Conor MacNeill [EMAIL PROTECTED]
wrote:

 The version of jdepend I have hanging around for building Ant is not
 compatible with the recent changes

Any chance to find out which version that is?

I'll throw in a little reflection around this (the manual still claims
support for JDepend = 1.2 and we don't need to break it if a
workaround is possible).

Thanks

Stefan


cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-04-03 Thread conor
conor   2003/04/03 06:44:02

  Modified:src/main/org/apache/tools/ant Project.java
   src/main/org/apache/tools/ant/taskdefs Ant.java
  Log:
  Fix up handling of input in nested builds.
  
  PR:   18642
  
  Revision  ChangesPath
  1.133 +13 -2 ant/src/main/org/apache/tools/ant/Project.java
  
  Index: Project.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/Project.java,v
  retrieving revision 1.132
  retrieving revision 1.133
  diff -u -w -u -r1.132 -r1.133
  --- Project.java  17 Feb 2003 14:12:10 -  1.132
  +++ Project.java  3 Apr 2003 14:44:01 -   1.133
  @@ -56,6 +56,7 @@
   
   import java.io.File;
   import java.io.IOException;
  +import java.io.EOFException;
   import java.io.InputStream;
   import java.lang.reflect.Modifier;
   import java.util.Enumeration;
  @@ -241,6 +242,16 @@
   }
   
   /**
  + * Get this project's input stream
  + *
  + * @return the InputStream instance in use by this Porject instance to 
  + * read input
  + */
  +public InputStream getDefaultInputStream() {
  +return defaultInputStream;
  +}
  +
  +/**
* Retrieves the current input handler.
*
* @return the InputHandler instance currently in place for the project 
  @@ -1309,7 +1320,7 @@
   if (defaultInputStream != null) {
   return defaultInputStream.read(buffer, offset, length);
   } else {
  -return System.in.read(buffer, offset, length);
  +throw new EOFException(No input provided for project);
   }
   }
   
  
  
  
  1.76  +1 -0  ant/src/main/org/apache/tools/ant/taskdefs/Ant.java
  
  Index: Ant.java
  ===
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Ant.java,v
  retrieving revision 1.75
  retrieving revision 1.76
  diff -u -w -u -r1.75 -r1.76
  --- Ant.java  10 Feb 2003 14:13:34 -  1.75
  +++ Ant.java  3 Apr 2003 14:44:02 -   1.76
  @@ -150,6 +150,7 @@
*/
   public void init() {
   newProject = new Project();
  +
newProject.setDefaultInputStream(getProject().getDefaultInputStream());
   newProject.setJavaVersionProperty();
   newProject.addTaskDefinition(property,
(Class) 
getProject().getTaskDefinitions()
  
  
  


DO NOT REPLY [Bug 18642] - StackOverflow when antcall calls a target which uses input

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18642

StackOverflow when antcall calls a target which uses input

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 14:46 ---
Good catch - thanks.

Fixed in CVS now.


DO NOT REPLY [Bug 12024] - [PATCH] Enable junit to inherit Ant properties as system properties

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12024.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12024

[PATCH] Enable junit to inherit Ant properties as system properties





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 14:52 ---
Created an attachment (id=5626)
Zip of latest 3 sources for junitx


DO NOT REPLY [Bug 18256] - ant.bat wrong syntax building classpath

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18256.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18256

ant.bat wrong syntax building classpath





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 15:03 ---
This is not a classloader issue. Classloaders do not have any issues with 
spaces. 

This line, however,

D:\Program Files\j2sdk1.4.1_01\bin\java.exe -classpath D:\Program Files\...

is a problem. It is running Ant with a classpath of D:\Program and trying to
execute the class starting with Files\... That is definitely a windows command
line issue. 

I'm pretty sure the doubling of quotes you report is not possible with the stock
ant.bat file - based on these two lines

if exist %JAVA_HOME%\lib\tools.jar set
LOCALCLASSPATH=%JAVA_HOME%\lib\tools.jar;%LOCALCLASSPATH%

and

%_JAVACMD% %ANT_OPTS% -classpath %LOCALCLASSPATH%

So, can you please double check that you have restored ant.bat. If you still
have problems, please zip up the complete echo output and we'll see what is 
next.

Thanks


Re: jdepend error

2003-04-03 Thread Conor MacNeill
On Fri, 4 Apr 2003 12:38 am, Stefan Bodewig wrote:
 On Fri, 4 Apr 2003, Conor MacNeill [EMAIL PROTECTED]

 wrote:
  The version of jdepend I have hanging around for building Ant is not
  compatible with the recent changes

 Any chance to find out which version that is?

Not really - just jdepend.jar. It's been on my system for a while though.


 I'll throw in a little reflection around this (the manual still claims
 support for JDepend = 1.2 and we don't need to break it if a
 workaround is possible).


+1

-- 
Conor MacNeill
Blog: http://codefeed.com/blog/


cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend JDependTask.java

2003-04-03 Thread bodewig
bodewig 2003/04/03 07:49:48

  Modified:docs/manual/OptionalTasks jdepend.html
   src/main/org/apache/tools/ant/taskdefs/optional/jdepend
JDependTask.java
  Log:
  Apply some reflection to become JDepend version independent
  
  Revision  ChangesPath
  1.10  +1 -1  ant/docs/manual/OptionalTasks/jdepend.html
  
  Index: jdepend.html
  ===
  RCS file: /home/cvs/ant/docs/manual/OptionalTasks/jdepend.html,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- jdepend.html  2 Apr 2003 12:00:27 -   1.9
  +++ jdepend.html  3 Apr 2003 15:49:47 -   1.10
  @@ -93,7 +93,7 @@
   the paths of compiled class code to analyze; the lt;sourcespathgt;
   variable is still available in case you are using an earlier version
   of JDepend.  The lt;excludegt; element can be used to set packages
  -to ignore./p
  +to ignore (requires JDepend 2.5 or above)./p
   
   h3Examples/h3
   
  
  
  
  1.19  +48 -17
ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java
  
  Index: JDependTask.java
  ===
  RCS file: 
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/jdepend/JDependTask.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- JDependTask.java  2 Apr 2003 12:00:27 -   1.18
  +++ JDependTask.java  3 Apr 2003 15:49:48 -   1.19
  @@ -58,6 +58,8 @@
   import java.io.FileWriter;
   import java.io.IOException;
   import java.io.PrintWriter;
  +import java.lang.reflect.Constructor;
  +import java.lang.reflect.Method;
   import java.util.Vector;
   import org.apache.tools.ant.BuildException;
   import org.apache.tools.ant.PathTokenizer;
  @@ -104,19 +106,37 @@
   private String format = text;
   private PatternSet defaultPatterns = new PatternSet();
   
  -public JDependTask() {
  +private static Constructor packageFilterC;
  +private static Method setFilter;
   
  +static {
  +try {
  +Class packageFilter = 
  +Class.forName(jdepend.framework.PackageFilter);
  +packageFilterC = 
  +packageFilter.getConstructor(new Class[] 
{java.util.Collection.class});
  +setFilter = 
  +jdepend.textui.JDepend.class.getDeclaredMethod(setFilter,
  +   new Class[] 
{packageFilter});
  +} catch (Throwable t) {
  +if (setFilter == null) {
  +packageFilterC = null;
  +}
  +}
   }
   
  -/*
  -public void setTimeout(Integer value) {
  -_timeout = value;
  +public JDependTask() {
   }
   
  -public Integer getTimeout() {
  -return _timeout;
  -}
  -*/
  +/*
  +  public void setTimeout(Integer value) {
  +  _timeout = value;
  +  }
  +
  +  public Integer getTimeout() {
  +  return _timeout;
  +  }
  +*/
   
   /**
* The output file name.
  @@ -305,9 +325,9 @@
   if (text.equals(format)) {
   commandline.setClassname(jdepend.textui.JDepend);
   } else
  -if (xml.equals(format)) {
  -commandline.setClassname(jdepend.xmlui.JDepend);
  -}
  +if (xml.equals(format)) {
  +commandline.setClassname(jdepend.xmlui.JDepend);
  +}
   
   if (_jvm != null) {
   commandline.setVm(_jvm);
  @@ -443,11 +463,22 @@
   // This bit turns exclude child tags into patters to ignore
   String[] patterns = defaultPatterns.getExcludePatterns(getProject());
   if (patterns != null  patterns.length  0) {
  -Vector v = new Vector();
  -for (int i = 0; i  patterns.length; i++) {
  -v.addElement(patterns[i]);
  +if (setFilter != null) {
  +Vector v = new Vector();
  +for (int i = 0; i  patterns.length; i++) {
  +v.addElement(patterns[i]);
  +}
  +try {
  +Object o = packageFilterC.newInstance(new Object[] {v});
  +setFilter.invoke(jdepend, new Object[] {o});
  +} catch (Throwable e) {
  +log(excludes will be ignored as JDepend doesn't like 
me: 
  ++ e.getMessage(), Project.MSG_WARN);
  +}
  +} else {
  +log(Sorry, your version of JDepend doesn't support 
excludes,
  +Project.MSG_WARN);
   }
  -jdepend.setFilter(new jdepend.framework.PackageFilter(v));
   }
   
   jdepend.analyze();
  @@ -493,7 +524,7 @@
   // not necessary as JDepend would fail, but why loose some 

Re: jdepend error

2003-04-03 Thread Stefan Bodewig
On Fri, 4 Apr 2003, Conor MacNeill [EMAIL PROTECTED]
wrote:
 On Fri, 4 Apr 2003 12:38 am, Stefan Bodewig wrote:
 On Fri, 4 Apr 2003, Conor MacNeill [EMAIL PROTECTED]

 wrote:
  The version of jdepend I have hanging around for building Ant is
  not compatible with the recent changes

 Any chance to find out which version that is?
 
 Not really - just jdepend.jar.

OK.  JDepend's release history says, setFilter has been introduced in
2.5 - I've updated the manual to that effect.

Could you please compile the task and run some simple metrics?  Maybe
you could also use the nested exclude element and see whether it
works as intended (i.e. print a warning and go on creating the
report).

Thanks

Stefan


DO NOT REPLY [Bug 18613] - setproject not called for all created objects

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18613.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18613

setproject not called for all created objects





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 17:28 ---
On reviewing the patch I found the following issues:

1) if the object that setproject is called on is not a public scoped object
   but does contain a public setproject method, the setproject method
   method is not found by getmethod. To work around this, the
   Project.setProjectOnObject() method now checks it the object extends
   ProjectComponent and if so calls setProject on a casted object - this
   should make the code functionally backward compatible

2) The same issue occuried in ChainReaderHelper. Also in this class, the
   setProject needs to be called in more places so a new private method
   method was added. Also I removed a needless check on the type of
   object in the filterchain being a Reader and ChainableReader, the
   code uses the object as a factory to create a reader.

A new patch follows...


DO NOT REPLY [Bug 14868] - Failed Building ANT Distribution !

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14868.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14868

Failed Building ANT Distribution !





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 17:28 ---
Created an attachment (id=5627)
Updated patch


DO NOT REPLY [Bug 18613] - setproject not called for all created objects

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18613.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18613

setproject not called for all created objects





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 17:30 ---
Created an attachment (id=5628)
Updated patch


DO NOT REPLY [Bug 14868] - Failed Building ANT Distribution !

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14868.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14868

Failed Building ANT Distribution !





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 17:32 ---
Sorry wrong bug number for the patch
Peter. ;)


DO NOT REPLY [Bug 18664] New: - Patch JavaCC/JJTree version changes 3.0 vs 2.1

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664

Patch JavaCC/JJTree version changes 3.0 vs 2.1

   Summary: Patch JavaCC/JJTree version changes 3.0 vs 2.1
   Product: Ant
   Version: 1.6Alpha (nightly)
  Platform: All
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Patch package name change in JavaCC version 3.0

Thanks to Stefan's comment: 'The task already deals with JavaCC  2.0 and = 2.0
differently' and the fact that the archive name was changed to javacc.jar there
was no need for an extra attribute in the taskdefs. Thus only patch for the 
code.


DO NOT REPLY [Bug 18664] - Patch JavaCC/JJTree version changes 3.0 vs 2.1

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664

Patch JavaCC/JJTree version changes 3.0 vs 2.1





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 17:51 ---
Created an attachment (id=5629)
Taskdefs javacc and jjtree package name change


DO NOT REPLY [Bug 18602] - Enhancement JavaCC, JJTree and JJDoc

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18602.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18602

Enhancement JavaCC, JJTree and JJDoc





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 17:55 ---
Created an attachment (id=5630)
Patch for NEW taskdef jjdoc when enhancement bug 18664 is accepted


DO NOT REPLY [Bug 18506] - Determine projecthelp non-main targets from prefix in target name

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18506.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18506

Determine projecthelp non-main targets from prefix in target name





--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 18:16 ---
I just want to add that is you want to document your ANT code you are wellcome 
to use !-- Comments -- on the XML file. Description tags are provided
to have the content of what to display on the -projecthelp.


DO NOT REPLY [Bug 15351] - JAVA_HOME set to path with spaces causes ant.bat to fail

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15351.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15351

JAVA_HOME set to path with spaces causes ant.bat to fail

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 18:17 ---
*** Bug 18256 has been marked as a duplicate of this bug. ***


DO NOT REPLY [Bug 18669] New: - Ftp task

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18669.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18669

Ftp task

   Summary: Ftp task
   Product: Ant
   Version: 1.5.2
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Is there any possibility of adding ftp task to the ant utility.
It can be very handy for us to move files to and fro.


DO NOT REPLY [Bug 18669] - Ftp task

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18669.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18669

Ftp task

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2003-04-03 21:25 ---
there is an ftp task. consult the documentation


DO NOT REPLY [Bug 18670] New: - Checksum validation against property always fails

2003-04-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670

Checksum validation against property always fails

   Summary: Checksum validation against property always fails
   Product: Ant
   Version: 1.5.2
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Using Checksum with property=checksum and verifyproperty=verify always 
results in the property verify being written with false, even if checksum was 
just set with Checksum property=checksum (ie checksum is known to be correct).

verifyproperty works as expected when the desired checksum is in an external 
file.