Re: [PATCH] JUnitReport Patch
Andrus Adamchik wrote: I submitted a bug 18504 about JUnitReport being broken on JDK 1.4.1. It was closed with WONTFIX status, which I think happened partially due to Bugzilla mysteriously trimming half of my report text (I am not very experienced with Bugzilla, so who knows). Anyway, the description was mangled causing confusion. In the meantime Cayenne team member who gave me the original description fixed it in Ant and sent me a patch, attached to this message. All I can tell is that patched version completely fixes the problem and we already use it in Cayenne builds. Andrus Adamchik http://objectstyle.org/cayenne/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] if there is a workaround, reopen the bug and attach the patches. -steve
DO NOT REPLY [Bug 18504] - Junit report broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18504 Junit report broken --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 02:01 --- Created an attachment (id=5633) this is a bugfix for the bug in question
RE: sql triggers, stored procedures, packages, format preserved
I did find an issue that is preventing some packages from loading into
Oracle. I have attached a diff -u that fixes it (one line, pretty self
explanatory). Please commit it.
-Rob A
-Original Message-
From: Steve Loughran [mailto:[EMAIL PROTECTED]
Sent: Thursday, March 13, 2003 1:43 PM
To: Ant Developers List
Subject: Re: sql triggers, stored procedures, packages, format preserved
- Original Message -
From: Anderson, Rob H - VSCM [EMAIL PROTECTED]
To: 'Ant Developers List' [EMAIL PROTECTED]
Sent: Thursday, March 13, 2003 13:04
Subject: RE: sql triggers, stored procedures, packages, format preserved
Steve, My build process will rely heavily on this task to load packages,
procedures, triggers, view, types, and apply grants in Oracle9i. I agree
that some tests are needed and I will look into creating some. Thanks,
-Rob Anderson
It is in there, via an FTP to a unix box where patch works reliably. We need
expanded documentation and testing, now. The task could also do with a
switch to turn on property expansion.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: SQLExec.java
===
RCS file:
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/SQLExec.java,v
retrieving revision 1.51
diff -u -r1.51 SQLExec.java
--- SQLExec.java14 Mar 2003 09:24:41 - 1.51
+++ SQLExec.java4 Apr 2003 01:38:05 -
@@ -375,6 +375,7 @@
}
try {
statement = conn.createStatement();
+statement.setEscapeProcessing(false);
PrintStream out = System.out;
DO NOT REPLY [Bug 18504] - Junit report broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18504 Junit report broken [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 02:03 --- See recently attached patch for the fix. Note that this is not a Xalan-related issue, so upgrading Xalan will have no effect whatsovere. However this patch fixes the real issue (related to JDK bug) completely. See discussion at http://objectstyle.org/cayenne/lists/cayenne-devel/2003/03/0170.html
cvs commit: ant/xdocs/stylesheets templates.vm
conor 2003/04/03 20:19:50
Modified:docs index.html page.css
xdocs/stylesheets templates.vm
Log:
KHTML does not right align table cells
Revision ChangesPath
1.275 +1 -1 ant/docs/index.html
Index: index.html
===
RCS file: /home/cvs/ant/docs/index.html,v
retrieving revision 1.274
retrieving revision 1.275
diff -u -w -u -r1.274 -r1.275
--- index.html4 Apr 2003 03:58:09 - 1.274
+++ index.html4 Apr 2003 04:19:49 - 1.275
@@ -22,7 +22,7 @@
table width=100% border=0 cellspacing=0 cellpadding=0
tr
td align=leftimg border=0 alt=Apache Ant site
src=./images/group-logo.gif/td
-tdimg alt=Apache Ant logo border=0
src=./images/project-logo.gif/td
+td align=center width=100%img alt=Apache Ant logo
border=0 src=./images/project-logo.gif/td
td align=right
form target=_blank onsubmit=q.value = query.value + '
site:ant.apache.org' action=http://www.google.com/search; method=get
table summary=search border=0 cellspacing=0
cellpadding=0 bgcolor=#4C6C8F
1.9 +0 -1 ant/docs/page.css
Index: page.css
===
RCS file: /home/cvs/ant/docs/page.css,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -w -u -r1.8 -r1.9
--- page.css 4 Apr 2003 03:58:09 - 1.8
+++ page.css 4 Apr 2003 04:19:49 - 1.9
@@ -160,7 +160,6 @@
.logobar {
background-color: #294563;
-text-align: center;
padding-right: 10px;
margin: 0px;
}
1.24 +1 -1 ant/xdocs/stylesheets/templates.vm
Index: templates.vm
===
RCS file: /home/cvs/ant/xdocs/stylesheets/templates.vm,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -w -u -r1.23 -r1.24
--- templates.vm 4 Apr 2003 03:58:10 - 1.23
+++ templates.vm 4 Apr 2003 04:19:50 - 1.24
@@ -265,7 +265,7 @@
table width=100% border=0 cellspacing=0 cellpadding=0
tr
td align=leftimg border=0 alt=Apache Ant site
src=$relativePath/images/group-logo.gif/td
-tdimg alt=Apache Ant logo border=0
src=$relativePath/images/project-logo.gif/td
+td align=center width=100%img alt=Apache Ant logo
border=0 src=$relativePath/images/project-logo.gif/td
td align=right
form target=_blank onsubmit=q.value = query.value + '
site:ant.apache.org' action=http://www.google.com/search; method=get
table summary=search border=0 cellspacing=0
cellpadding=0 bgcolor=$blue2
DO NOT REPLY [Bug 16268] - ant.apache.org uses tables for formatting.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16268. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16268 ant.apache.org uses tables for formatting. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 04:23 --- Removed the bulk of formatting tables and replaced them with CSS based layout. Two tables remain - one for the logo bar and one for the search form (also in the logo bar). I can remove both of these on Mozilla but IE cannot cope with the input boxes and inserts a blank white line - ugly.
DO NOT REPLY [Bug 18664] - Patch JavaCC/JJTree version changes 3.0 vs 2.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664 Patch JavaCC/JJTree version changes 3.0 vs 2.1 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Target Milestone|--- |1.6
Re: cvs commit: ant/xdocs/stylesheets templates.vm
On 4 Apr 2003, [EMAIL PROTECTED] wrote: More CSS - less tables No question, it looks - umh - ugly on Netscape 4, don't know how much of a concern that has to be for us, though[1]. It works (the menu comes at the top, the content below) for links and lynx (text-only browsers that are used by tools that read webpage to blind users) which is important IMHO. Stefan Footnotes: [1] http://www.apache.org/~vgritsenko/stats/daily.html#User+Agents+Stats
DO NOT REPLY [Bug 15729] - StarTeam rootLocalFolder should be java.io.File
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15729. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15729 StarTeam rootLocalFolder should be java.io.File --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 06:24 --- Jose Alberto, not everything is resolved to basedir, unfortunately. Sometimes the code predates IntrospectionHelper, sometimes people just didn't know about the magic of File attributes. Whenever we change an attribute to resolve files relative to basedir and not the current working directory, we run the danger of breaking backwards compatibility. As an example, several Jakarta builds got broken when style's stylesheet attribute was changed. I had to revert to the tactics we use now - which pretty much is option (2) from my last comment. Consistency is good. Breaking backwards compatibility for consistency's sake is not.
Re: cvs commit: ant/xdocs/stylesheets templates.vm
On Fri, 4 Apr 2003 03:53 pm, Stefan Bodewig wrote: No question, it looks - umh - ugly on Netscape 4, don't know how much of a concern that has to be for us, though[1]. Probably not much of a concern. I've tested with a few browsers Mozilla 1.2/1.3 on Linux Konqueror on Linux IE6 on Windows All look OK to me. I'm interested in knowing if anyone has problems in other combinations. It works (the menu comes at the top, the content below) for links and lynx (text-only browsers that are used by tools that read webpage to blind users) which is important IMHO. Yes, I've been reading Mark Pilgrim's accessibility stuff. -- Conor MacNeill Blog: http://codefeed.com/blog/
Re: Fwd: [Xdoclet-user] multiple jsptaglib nested tag in webdoclet
On Thu, 3 Apr 2003, Erik Hatcher [EMAIL PROTECTED] wrote: Any ideas on the differences between using taskdef under project or under a target? Several, and they vary with the Ant version in use. With Ant 1.5.x, the main difference is that taskdefs defined at the project level will get evaluated immediately, so Ant creates the real task objects and real nested elements at parser time. If you put the taskdef into a target, things go the UnknownElement route first. This causes several differences. With CVS HEAD, things have become different, and taskdef is supposed to work consistently now (unchecked 8-) - as all tasks will be UnknowElement until used now. With Ant 1.4, nested child elements didn't work properly in one of the two cases, can't exactly remember which. Stefan
RE: cvs commit: ant/xdocs/stylesheets templates.vm
Hi Conor and Stefan! No question, it looks - umh - ugly on Netscape 4, don't know how much of a concern that has to be for us, though[1]. Probably not much of a concern. I've tested with a few browsers Mozilla 1.2/1.3 on Linux Konqueror on Linux Whew, and it looks much nicer as the original Forrest Skin with Konqueror! Well done Conor! IE6 on Windows I agree that Netscape 4 is not that important anymore! Additionally I know many NS4 users who already moved to Phoenix! It works (the menu comes at the top, the content below) for links and lynx (text-only browsers that are used by tools that read webpage to blind users) which is important IMHO. Yes, I've been reading Mark Pilgrim's accessibility stuff. I've tested with LynxView! Looks good to me! Here is the link: http://www.delorie.com/web/lynxview.cgi?url=http://ant.apache.org/ Greetingx, Christoph
Re: updated sql documentation....
On Thu, 3 Apr 2003, Rob H. Anderson [EMAIL PROTECTED] wrote: Attached is the updated sql documentation that I promised. Didn't make it to the list, sorry. Stefan
DO NOT REPLY [Bug 18504] - Junit report broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18504. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18504 Junit report broken [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Status|REOPENED|NEW Target Milestone|--- |1.6
RE: updated sql documentation....
I hate it when that happens. How about now? -Rob A -Original Message- From: Stefan Bodewig [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2003 11:19 PM To: [EMAIL PROTECTED] Subject: Re: updated sql documentation On Thu, 3 Apr 2003, Rob H. Anderson [EMAIL PROTECTED] wrote: Attached is the updated sql documentation that I promised. Didn't make it to the list, sorry. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Index: sql.html === RCS file: /home/cvspublic/ant/docs/manual/CoreTasks/sql.html,v retrieving revision 1.18 diff -u -r1.18 sql.html --- sql.html18 Dec 2002 17:27:00 - 1.18 +++ sql.html4 Apr 2003 01:46:21 - @@ -132,6 +132,13 @@ td width=10% valign=topNo (defaul:normal)/td /tr +tr + td width=12% valign=topkeepformat/td + td width=78% valign=topControl whether the format of the sql will be preserved.br +Usefull when loading packages and procedures. + td width=10% valign=topNo (defaul=false)/td +/tr + /table h3Parameters specified as nested elements/h3
Where are we WRT the JDK decision?
When I fixed the JDepend task, I made it depend on JDK 1.2 - which is fine as JDepend has the same dependency. I'll shortly commit the JUnit Report patches and those contain workarounds for the famous StringBuffer#toString memory leak[1] in JDK 1.4.1. Unfortunately the workaround is to use StringBuffer#substring which is not part of JDK 1.1. IIUC we don't have a 1.1 compatibility requirement for CVS HEAD any longer, so that is fine. I'll grep through the sources to see whether I find more cases of StringBuffer#toString used on shared StringBuffers (its my understanding that it doesn't do too much harm if the StringBuffer gets recycled at some point) and will apply the same workaround there. We won't be able to fix the problem in the 1.5 branch, though. Stefan Footnotes: [1] http://developer.java.sun.com/developer/bugParade/bugs/4724129.html
cvs commit: ant/src/main/org/apache/tools/ant/util DOMElementWriter.java
bodewig 2003/04/04 00:36:22
Modified:src/main/org/apache/tools/ant/taskdefs/optional/junit
XMLJUnitResultFormatter.java
XMLResultAggregator.java XalanExecutor.java
src/main/org/apache/tools/ant/util DOMElementWriter.java
Log:
Speed up junitreport by buffering output.
Vastly reduce memory requirements of DOMElementWriter on JDK 1.4.1 by
using the workaround for JDK 1.4.1's StringBuffer#toString memory leak
(JDC BugParade Bug 4724129).
PR: 18504
Submitted by: Andrus Adamchik mensk at users dot sourceforge dot net
Revision ChangesPath
1.28 +2 -1
ant/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java
Index: XMLJUnitResultFormatter.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- XMLJUnitResultFormatter.java 28 Mar 2003 12:20:51 - 1.27
+++ XMLJUnitResultFormatter.java 4 Apr 2003 08:36:22 - 1.28
@@ -54,6 +54,7 @@
package org.apache.tools.ant.taskdefs.optional.junit;
+import java.io.BufferedWriter;
import java.io.IOException;
import java.io.OutputStream;
import java.io.OutputStreamWriter;
@@ -165,7 +166,7 @@
if (out != null) {
Writer wri = null;
try {
-wri = new OutputStreamWriter(out, UTF8);
+wri = new BufferedWriter(new OutputStreamWriter(out,
UTF8));
wri.write(?xml version=\1.0\ encoding=\UTF-8\ ?\n);
(new DOMElementWriter()).write(rootElement, wri, 0, );
wri.flush();
1.22 +3 -2
ant/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java
Index: XMLResultAggregator.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- XMLResultAggregator.java 10 Feb 2003 14:14:16 - 1.21
+++ XMLResultAggregator.java 4 Apr 2003 08:36:22 - 1.22
@@ -1,7 +1,7 @@
/*
* The Apache Software License, Version 1.1
*
- * Copyright (c) 2001-2002 The Apache Software Foundation. All rights
+ * Copyright (c) 2001-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -53,6 +53,7 @@
*/
package org.apache.tools.ant.taskdefs.optional.junit;
+import java.io.BufferedOutputStream;
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
@@ -228,7 +229,7 @@
OutputStream out = null;
PrintWriter wri = null;
try {
-out = new FileOutputStream(file);
+out = new BufferedOutputStream(new FileOutputStream(file));
wri = new PrintWriter(new OutputStreamWriter(out, UTF8));
wri.write(?xml version=\1.0\ encoding=\UTF-8\ ?\n);
(new DOMElementWriter()).write(doc.getDocumentElement(), wri, 0,
);
1.9 +3 -2
ant/src/main/org/apache/tools/ant/taskdefs/optional/junit/XalanExecutor.java
Index: XalanExecutor.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/junit/XalanExecutor.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- XalanExecutor.java10 Feb 2003 14:14:16 - 1.8
+++ XalanExecutor.java4 Apr 2003 08:36:22 - 1.9
@@ -53,6 +53,7 @@
*/
package org.apache.tools.ant.taskdefs.optional.junit;
+import java.io.BufferedOutputStream;
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.FileOutputStream;
@@ -81,12 +82,12 @@
/** get the appropriate stream based on the format (frames/noframes) */
protected OutputStream getOutputStream() throws IOException {
-if (caller.FRAMES.equals(caller.format)){
+if (AggregateTransformer.FRAMES.equals(caller.format)){
// dummy output for the framed report
// it's all done by extension...
return new ByteArrayOutputStream();
} else {
-return new FileOutputStream(new File(caller.toDir,
junit-noframes.html));
+return new BufferedOutputStream(new FileOutputStream(new
File(caller.toDir, junit-noframes.html)));
}
}
1.17 +5 -4
ant/src/main/org/apache/tools/ant/util/DOMElementWriter.java
Index: DOMElementWriter.java
Re: updated sql documentation....
On Fri, 4 Apr 2003, Rob H. Anderson [EMAIL PROTECTED] wrote: How about now? Got it. Stefan
cvs commit: ant/docs/manual/CoreTasks sql.html
bodewig 2003/04/04 00:50:08 Modified:docs/manual/CoreTasks sql.html Log: Sync docs with new functionality. Submitted by: Rob Anderson Anderson dot Rob at vectorscm dot com Revision ChangesPath 1.19 +8 -1 ant/docs/manual/CoreTasks/sql.html Index: sql.html === RCS file: /home/cvs/ant/docs/manual/CoreTasks/sql.html,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- sql.html 18 Dec 2002 17:27:00 - 1.18 +++ sql.html 4 Apr 2003 08:50:07 - 1.19 @@ -132,6 +132,13 @@ td width=10% valign=topNo (defaul:normal)/td /tr +tr + td width=12% valign=topkeepformat/td + td width=78% valign=topControl whether the format of the sql will be preserved.br +Usefull when loading packages and procedures. + td width=10% valign=topNo (defaul=false)/td +/tr + /table h3Parameters specified as nested elements/h3 @@ -295,7 +302,7 @@ /pre/blockquote hr -p align=centerCopyright copy; 2000-2002 Apache Software Foundation. All rights +p align=centerCopyright copy; 2000-2003 Apache Software Foundation. All rights Reserved./p /body /html
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/javacc JJTree.java JavaCC.java
bodewig 2003/04/04 01:08:52
Modified:.WHATSNEW
src/main/org/apache/tools/ant/taskdefs/optional/javacc
JJTree.java JavaCC.java
Log:
Make javacc and jjtree work with JavaCC version 3.x.
PR: 18664
Submitted by: Jene Jasper jjasper at abz dot nl
Revision ChangesPath
1.389 +2 -0 ant/WHATSNEW
Index: WHATSNEW
===
RCS file: /home/cvs/ant/WHATSNEW,v
retrieving revision 1.388
retrieving revision 1.389
diff -u -r1.388 -r1.389
--- WHATSNEW 3 Apr 2003 08:48:47 - 1.388
+++ WHATSNEW 4 Apr 2003 09:08:51 - 1.389
@@ -218,6 +218,8 @@
* The JProbe tasks now also work with JProbe 4.x. Bugzilla Report 14849.
+* javacc and jjtree will now autodetect JavaCC 3.x and can use it.
+
Changes from Ant 1.5.2 to Ant 1.5.3
===
1.20 +9 -7
ant/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JJTree.java
Index: JJTree.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JJTree.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- JJTree.java 18 Feb 2003 12:46:27 - 1.19
+++ JJTree.java 4 Apr 2003 09:08:52 - 1.20
@@ -202,7 +202,6 @@
public JJTree() {
cmdl.setVm(JavaEnvUtils.getJreExecutable(java));
-cmdl.setClassname(COM.sun.labs.jjtree.Main);
}
public void execute() throws BuildException {
@@ -218,30 +217,33 @@
if (target == null || !target.isFile()) {
throw new BuildException(Invalid target: + target);
}
-
+
// use the directory containing the target as the output directory
if (outputDirectory == null) {
outputDirectory = new File(target.getParent());
-}
+}
if (!outputDirectory.isDirectory()) {
-throw new BuildException('outputdirectory' + outputDirectory
+throw new BuildException('outputdirectory' + outputDirectory
+ is not a directory.);
}
// convert backslashes to slashes, otherwise jjtree will put this as
// comments and this seems to confuse javacc
-cmdl.createArgument().setValue(-OUTPUT_DIRECTORY:
+cmdl.createArgument().setValue(-OUTPUT_DIRECTORY:
+ outputDirectory.getAbsolutePath().replace('\\', '/'));
-
+
String targetName = target.getName();
final File javaFile = new File(outputDirectory,
targetName.substring(0, targetName.indexOf(.jjt)) + .jj);
-if (javaFile.exists()
+if (javaFile.exists()
target.lastModified() javaFile.lastModified()) {
log(Target is already built - skipping ( + target + ),
Project.MSG_VERBOSE);
return;
}
cmdl.createArgument().setValue(target.getAbsolutePath());
+
+cmdl.setClassname(JavaCC.getMainClass(javaccHome,
+ JavaCC.TASKDEF_TYPE_JJTREE));
final Path classpath = cmdl.createClasspath(getProject());
final File javaccJar = JavaCC.getArchiveFile(javaccHome);
1.22 +115 -16
ant/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JavaCC.java
Index: JavaCC.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/javacc/JavaCC.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- JavaCC.java 18 Feb 2003 12:46:27 - 1.21
+++ JavaCC.java 4 Apr 2003 09:08:52 - 1.22
@@ -106,6 +106,23 @@
private CommandlineJava cmdl = new CommandlineJava();
+protected static final int TASKDEF_TYPE_JAVACC = 1;
+protected static final int TASKDEF_TYPE_JJTREE = 2;
+protected static final int TASKDEF_TYPE_JJDOC = 3;
+
+protected static final String[] ARCHIVE_LOCATIONS =
+new String[] {JavaCC.zip, bin/lib/JavaCC.zip,
+ bin/lib/javacc.jar};
+
+protected static final String COM_PACKAGE = COM.sun.labs.;
+protected static final String COM_JAVACC_CLASS = javacc.Main;
+protected static final String COM_JJTREE_CLASS = jjtree.Main;
+protected static final String COM_JJDOC_CLASS = jjdoc.JJDocMain;
+
+protected static final String ORG_PACKAGE = org.netbeans.javacc.;
+protected static final String ORG_JAVACC_CLASS = parser.Main;
+protected static final String ORG_JJTREE_CLASS = COM_JJTREE_CLASS;
+protected static final String ORG_JJDOC_CLASS =
DO NOT REPLY [Bug 12511] - concat directive must have a newline
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12511. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12511 concat directive must have a newline --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 09:19 --- Ok I have including the patch. It is part of an update to the enchanced concat. The patch implements following attributes * outputencoding * fixlastline * eol and *encoding on header and footer nested elements There is test cases for the outputencoding and fixlastline. The test case for outputencoding depends on the files used in the copy tests. A new method setWriter has been added. This is to allow concat to be used as a nested element (as part of a filter chain). The idea here is to remove header and footer as nested elements of concat, and add them as nested elements of filterchain (so they can be used with concat, loadfile and copy). example: concat some files filterchain headerThis is the header/header footerpath path=footer.txt/footer /filterchain /concat Peter.
DO NOT REPLY [Bug 18664] - Patch JavaCC/JJTree version changes 3.0 vs 2.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18664 Patch JavaCC/JJTree version changes 3.0 vs 2.1 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 09:33 --- Applied, thanks. Will be in nightly build 2003-04-05.
Re: sql triggers, stored procedures, packages, format preserved
On Thu, 3 Apr 2003, Rob H. Anderson [EMAIL PROTECTED] wrote: one line, pretty self explanatory self explaining? Yes. I'm just not sure whether we want to do that unconditionally. Stefan
Re: Patch JavaCC - KEEP_LINE_COLUMN, JJTree - OUTPUT_FILE and new tas kdef JJDoc
On Fri, 4 Apr 2003, Jene Jasper [EMAIL PROTECTED] wrote: Would it be useful if I add an updated patch.txt to bug 18602 for JavaCC.java and JJTree.java after the changes are available in a nightly build ?? Maybe, but I don't think that merging them will be a big deal anyway. Stefan
Re: Where are we WRT the JDK decision?
On Fri, 4 Apr 2003 06:28 pm, Stefan Bodewig wrote: IIUC we don't have a 1.1 compatibility requirement for CVS HEAD any longer, so that is fine. This is the case - I just need to write up an email about it which I'll try to do tonight. Conor -- Conor MacNeill Blog: http://codefeed.com/blog/
Re: [Xdoclet-user] multiple jsptaglib nested tag in webdoclet
Stefan, Thanks for those details. Erik On Friday, April 4, 2003, at 01:41 AM, Stefan Bodewig wrote: On Thu, 3 Apr 2003, Erik Hatcher [EMAIL PROTECTED] wrote: Any ideas on the differences between using taskdef under project or under a target? Several, and they vary with the Ant version in use. With Ant 1.5.x, the main difference is that taskdefs defined at the project level will get evaluated immediately, so Ant creates the real task objects and real nested elements at parser time. If you put the taskdef into a target, things go the UnknownElement route first. This causes several differences. With CVS HEAD, things have become different, and taskdef is supposed to work consistently now (unchecked 8-) - as all tasks will be UnknowElement until used now. With Ant 1.4, nested child elements didn't work properly in one of the two cases, can't exactly remember which. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18667] - javah module no longer works with Java 1.4.2
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18667. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18667 javah module no longer works with Java 1.4.2 [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Blocker OS/Version|All |Linux Priority|Other |High Platform|All |PC Version|1.5 |1.5.1 --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 11:11 --- I have a similar problem using Ant 1.5.1 on Linux with Java 1.4.2 beta. java.lang.NoSuchMethodError: com.sun.tools.javah.Main.init([Ljava/lang/String; )V at org.apache.tools.ant.taskdefs.optional.Javah.doClassicCompile(Javah. java:348) at org.apache.tools.ant.taskdefs.optional.Javah.execute(Javah.java:318) at org.apache.tools.ant.Task.perform(Task.java:319) at org.apache.tools.ant.Target.execute(Target.java:309) at org.apache.tools.ant.Target.performTasks(Target.java:336) at org.apache.tools.ant.Project.executeTarget(Project.java:1306) at org.apache.tools.ant.Project.executeTargets(Project.java:1250) at org.apache.tools.ant.Main.runBuild(Main.java:610) at org.apache.tools.ant.Main.start(Main.java:196) at org.apache.tools.ant.Main.main(Main.java:235)
Re: cvs commit: ant/xdocs/stylesheets templates.vm
BTW, it looks nice in Safari as well, which probably makes up a considerable part of the Unknowns in http://www.apache.org/~vgritsenko/stats/daily.html#User+Agents+Stats Stefan
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce P4Fstat.java
bodewig 2003/04/04 05:02:40 Modified:src/main/org/apache/tools/ant/taskdefs/optional/perforce P4Fstat.java Log: Remove stray CRs Revision ChangesPath 1.4 +213 -212 ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Fstat.java Index: P4Fstat.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Fstat.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- P4Fstat.java 10 Feb 2003 14:14:19 - 1.3 +++ P4Fstat.java 4 Apr 2003 13:02:40 - 1.4 @@ -1,214 +1,215 @@ -/* - * The Apache Software License, Version 1.1 - * - * Copyright (c) 2003 The Apache Software Foundation. All rights - * reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * 1. Redistributions of source code must retain the above copyright - *notice, this list of conditions and the following disclaimer. - * - * 2. Redistributions in binary form must reproduce the above copyright - *notice, this list of conditions and the following disclaimer in - *the documentation and/or other materials provided with the - *distribution. - * - * 3. The end-user documentation included with the redistribution, if - *any, must include the following acknowlegement: - * This product includes software developed by the - *Apache Software Foundation (http://www.apache.org/). - *Alternately, this acknowlegement may appear in the software itself, - *if and wherever such third-party acknowlegements normally appear. - * - * 4. The names Ant and Apache Software - *Foundation must not be used to endorse or promote products derived - *from this software without prior written permission. For written - *permission, please contact [EMAIL PROTECTED] - * - * 5. Products derived from this software may not be called Apache - *nor may Apache appear in their names without prior written - *permission of the Apache Group. - * - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED - * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR - * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF - * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND - * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, - * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT - * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - * - * - * This software consists of voluntary contributions made by many - * individuals on behalf of the Apache Software Foundation. For more - * information on the Apache Software Foundation, please see - * http://www.apache.org/. - */ -/* - * Portions of this software are based upon public domain software - * originally written at the National Center for Supercomputing Applications, - * University of Illinois, Urbana-Champaign. - */ - -package org.apache.tools.ant.taskdefs.optional.perforce; - - -import java.io.File; -import java.util.Vector; -import java.util.ArrayList; - -import org.apache.tools.ant.BuildException; -import org.apache.tools.ant.DirectoryScanner; -import org.apache.tools.ant.Project; -import org.apache.tools.ant.types.FileSet; - -/** - * P4Fstat - find out which files are under Perforce control and which are not. - * - * brbExample Usage:/bbr - * pre - * lt;project name=quot;p4fstatquot; default=quot;p4fstatquot; basedir=quot;C:\dev\gnuquot;gt; - * lt;target name=quot;p4fstatquot; gt; - * lt;p4fstat showfilter=quot;allquot;gt; - * lt;fileset dir=quot;depotquot; includes=quot;**\/*quot;/gt; - * lt;/p4fstatgt; - * lt;/targetgt; - * lt;/projectgt; - * /pre - * - * @author A HREF=mailto:[EMAIL PROTECTED]Miha/A - * @author A HREF=mailto:[EMAIL PROTECTED]Les Hughes/A +/* + * The Apache Software License, Version 1.1 + * + * Copyright (c) 2003 The Apache Software Foundation. All rights + * reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of
DO NOT REPLY [Bug 18708] New: - outputproperty attribute of exec
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18708. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18708 outputproperty attribute of exec Summary: outputproperty attribute of exec Product: Ant Version: 1.5.1 Platform: Sun OS/Version: Solaris Status: NEW Severity: Normal Priority: Other Component: Build Process AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi. I'm trying to use the outputproperty attribute of exec but it seems to do nothing. This is what I'm trying to do: exec executable=/usr/bin/ls outputproperty=object_list arg value=/tmp/ /exec I don't know if I have to add a property tag in order to declare the property I want to use or not, object_list. I have tried doing that too but It didn't work. The property is empty. Can anybody send me an example of how to do this?
cvs commit: ant/src/etc/testcases/core/containersrc/test - New directory
conor 2003/04/04 05:50:54 ant/src/etc/testcases/core/containersrc/test - New directory
cvs commit: ant/src/main/org/apache/tools/ant/util DOMElementWriter.java RegexpPatternMapper.java ResourceUtils.java
bodewig 2003/04/04 05:51:12
Modified:src/main/org/apache/tools/ant RuntimeConfigurable.java
src/main/org/apache/tools/ant/listener MailLogger.java
src/main/org/apache/tools/ant/taskdefs AntStructure.java
Concat.java FixCRLF.java Javadoc.java Replace.java
SQLExec.java
src/main/org/apache/tools/ant/taskdefs/email Message.java
src/main/org/apache/tools/ant/taskdefs/optional
ReplaceRegExp.java
src/main/org/apache/tools/ant/taskdefs/optional/junit
JUnitTask.java
src/main/org/apache/tools/ant/taskdefs/optional/perforce
P4Add.java P4Fstat.java
src/main/org/apache/tools/ant/taskdefs/optional/sitraka/bytecode
Utils.java
src/main/org/apache/tools/ant/types Commandline.java
Path.java
src/main/org/apache/tools/ant/util DOMElementWriter.java
RegexpPatternMapper.java ResourceUtils.java
Log:
Avoid reusing StringBuffers to work around JDK 1.4.1 memory leak.
I'm sure that my changes in most cases are of the paranoid type,
ResourceUtils and FixCRLF look as if they really had a chance of
running into trouble.
Revision ChangesPath
1.29 +1 -1
ant/src/main/org/apache/tools/ant/RuntimeConfigurable.java
Index: RuntimeConfigurable.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/RuntimeConfigurable.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- RuntimeConfigurable.java 2 Apr 2003 11:43:41 - 1.28
+++ RuntimeConfigurable.java 4 Apr 2003 13:51:11 - 1.29
@@ -324,7 +324,7 @@
id = (String) attributeMap.get(id);
if (characters.length() != 0) {
-ProjectHelper.addText(p, wrappedObject, characters.toString());
+ProjectHelper.addText(p, wrappedObject, characters.substring(0));
}
Enumeration enum = children.elements();
1.15 +2 -2
ant/src/main/org/apache/tools/ant/listener/MailLogger.java
Index: MailLogger.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/listener/MailLogger.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- MailLogger.java 10 Feb 2003 14:13:34 - 1.14
+++ MailLogger.java 4 Apr 2003 13:51:11 - 1.15
@@ -1,7 +1,7 @@
/*
* The Apache Software License, Version 1.1
*
- * Copyright (c) 2002-2002 The Apache Software Foundation. All rights
+ * Copyright (c) 2002-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -158,7 +158,7 @@
String subject = getValue(properties, prefix + .subject,
(success) ? Build Success : Build Failure);
-sendMail(mailhost, port, from, toList, subject,
buffer.toString());
+sendMail(mailhost, port, from, toList, subject,
buffer.substring(0));
} catch (Exception e) {
System.out.println(MailLogger failed to send e-mail!);
e.printStackTrace(System.err);
1.32 +4 -4
ant/src/main/org/apache/tools/ant/taskdefs/AntStructure.java
Index: AntStructure.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/AntStructure.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- AntStructure.java 7 Mar 2003 11:23:00 - 1.31
+++ AntStructure.java 4 Apr 2003 13:51:11 - 1.32
@@ -1,7 +1,7 @@
/*
* The Apache Software License, Version 1.1
*
- * Copyright (c) 2000-2002 The Apache Software Foundation. All rights
+ * Copyright (c) 2000-2003 The Apache Software Foundation. All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -294,8 +294,8 @@
sb.append();
out.println(sb);
-sb.setLength(0);
-sb.append(!ATTLIST ).append(name);
+sb = new StringBuffer(!ATTLIST );
+sb.append(name);
sb.append(lSep).append( id ID #IMPLIED);
enum = ih.getAttributes();
1.18 +2 -2 ant/src/main/org/apache/tools/ant/taskdefs/Concat.java
Index: Concat.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Concat.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- Concat.java 28 Mar
cvs commit: ant build.xml
conor 2003/04/04 05:53:17
Modified:.build.xml
Log:
New task container test, which fails. This doesn't fail as badly
under 1.5.x but nevertheless is not functional
Revision ChangesPath
1.359 +1 -0 ant/build.xml
Index: build.xml
===
RCS file: /home/cvs/ant/build.xml,v
retrieving revision 1.358
retrieving revision 1.359
diff -u -w -u -r1.358 -r1.359
--- build.xml 2 Apr 2003 15:21:44 - 1.358
+++ build.xml 4 Apr 2003 13:53:17 - 1.359
@@ -302,6 +302,7 @@
patternset id=teststhatfail
exclude name=${optional.package}/BeanShellScriptTest.java/
exclude name=${ant.package}/taskdefs/ImportTest.java/
+ exclude name=${ant.package}/TaskContainerTest.java/
/patternset
!--
cvs commit: ant/src/testcases/org/apache/tools/ant TaskContainerTest.java
conor 2003/04/04 05:53:18
Modified:src/testcases/org/apache/tools/ant TaskContainerTest.java
Log:
New task container test, which fails. This doesn't fail as badly
under 1.5.x but nevertheless is not functional
Revision ChangesPath
1.3 +13 -0
ant/src/testcases/org/apache/tools/ant/TaskContainerTest.java
Index: TaskContainerTest.java
===
RCS file:
/home/cvs/ant/src/testcases/org/apache/tools/ant/TaskContainerTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -w -u -r1.2 -r1.3
--- TaskContainerTest.java28 Mar 2003 08:42:00 - 1.2
+++ TaskContainerTest.java4 Apr 2003 13:53:18 - 1.3
@@ -64,6 +64,10 @@
configureProject(src/etc/testcases/core/taskcontainer.xml);
}
+public void tearDown() {
+executeTarget(cleanup);
+}
+
public void testPropertyExpansion() {
executeTarget(testPropertyExpansion);
assertTrue(attribute worked,
@@ -71,4 +75,13 @@
assertTrue(nested text worked,
getLog().indexOf(As nested text: it worked) -1);
}
+
+public void testTaskdef() {
+executeTarget(testTaskdef);
+assertTrue(attribute worked,
+ getLog().indexOf(As attribute: it worked) -1);
+assertTrue(nested text worked,
+ getLog().indexOf(As nested text: it worked) -1);
+}
+
}
cvs commit: ant/src/etc/testcases/core/containersrc/test SpecialSeq.java
conor 2003/04/04 05:53:18
Added: src/etc/testcases/core/containersrc/test SpecialSeq.java
Log:
New task container test, which fails. This doesn't fail as badly
under 1.5.x but nevertheless is not functional
Revision ChangesPath
1.1
ant/src/etc/testcases/core/containersrc/test/SpecialSeq.java
Index: SpecialSeq.java
===
package test;
import org.apache.tools.ant.Task;
import org.apache.tools.ant.TaskContainer;
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.types.FileSet;
import java.util.*;
public class SpecialSeq extends Task implements TaskContainer {
/** Optional Vector holding the nested tasks */
private Vector nestedTasks = new Vector();
private FileSet fileset;
/**
* Add a nested task.
* p
* @param nestedTask Nested task to execute
* p
*/
public void addTask(Task nestedTask) {
nestedTasks.addElement(nestedTask);
}
/**
* Execute all nestedTasks.
*/
public void execute() throws BuildException {
for (Enumeration e = nestedTasks.elements(); e.hasMoreElements();) {
Task nestedTask = (Task) e.nextElement();
nestedTask.perform();
}
}
public void addFileset(FileSet fileset) {
this.fileset = fileset;
}
}
RE: [RESULT] Ant 1.6 will require JDK 1.2
Probably because Stefan is (with you!) the most active committer on Ant ;-) Thank you both for your fantastic work. --DD -Original Message- From: Conor MacNeill [mailto:[EMAIL PROTECTED] Sent: Friday, April 04, 2003 8:51 AM To: [EMAIL PROTECTED] Subject: [RESULT] Ant 1.6 will require JDK 1.2 This is just to formalize the result of the [VOTE] on the JDK version requirements for Ant. Ant 1.5.3 and any further releases of the Ant 1.5 branch will compile and function with JDK 1.1 Ant 1.6 will be the first Ant release to require at least JDK 1.2 Cheers Conor It's funny that Stefan, who only voted +0, is the first to make a change that requires JDK 1.2 :-) -- Conor MacNeill Blog: http://codefeed.com/blog/
Re: Using files in classpath in task file=
Stefan Bodewig wrote, On 03/04/2003 8.17: On Wed, 02 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote: If I had it in jars I could ship it automatically with the jar that has the task that generated index.xml, so I can easily do something like: xslt in=index.xml out=index.html style=resource:/a/style.xsl/ I see. What I don't see is how we could use an URI here without breaking backwards compatibility. In XSLTProcess we get the style parameter via setStyle(File), this obviously cannot be called with anything else but a file object. If we wanted general URIs, we'd have to change the signature and break custom tasks that inherit from or delegate to instances of XSLTProcess. No way. I'd rather propose to add an alternative attribute styleURI or something to XSLTProcess. What I mean is not to change the passing of a File object. I mean that we can *wrap* an URL in a File. So we pass a File, and use an URL, getting a Virtual File System. A File is used to open a connection, and to navigate the URI space, and a URL has the same features. Be able to specify a URL for every task that needs a file, and that thus uses the above fileutils method. Again, not without changing the tasks to use something else, not File, in their setter method and thus severely breaking backwards compatibility. But if we still use File? Or maybe KISS and just add a getStyleResource(String styleResource). It solves the immediate issue and doesn't open other potential problems. Seems the better way to me - at least until we are prepared to break API compatibility on almost all tasks at once 8-) If it were to break like this, I would also oppose. But could the wrapping ba a viable solution that easily gets us full URL usage in all file-accepting tasks? -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) -
Re: [RESULT] Ant 1.6 will require JDK 1.2
On Sat, 5 Apr 2003, Conor MacNeill [EMAIL PROTECTED] wrote: It's funny that Stefan, who only voted +0, is the first to make a change that requires JDK 1.2 :-) I couldn't find a workaround, that's all (yes, I've seen that smiley). Having said that, I could have left all toStrings as they were after making sure that the StringBuffers didn't get reused. The real bad things happen in StringBuffer#setLength and only if the StringBuffer is shared, which happens after calling toString. Not calling toString avoids the sharing part, not reusing StringBuffers avoids both, sharing and the calls to setLength. This means that we've now traded a certain amount of memory that cannot get reclaimed by the GC in 1.4.1 for more objects that can get garbage collected. I.e. we could see some negative performance impact. The JDepend change would have required yet another (i.e. a third) layer of indirection via reflection. Let's say I'm lazy. ;-) Have nice weekend Stefan
Re: Using files in classpath in task file=
On Fri, 04 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote: What I mean is not to change the passing of a File object. I mean that we can *wrap* an URL in a File. So we pass a File, and use an URL, getting a Virtual File System. How so - put the URI into the name and abuse File as a String? I'd really like to understand that. We are talking about java.io.File here 8-) Stefan
RE: Using files in classpath in task file=
OK, me too I wish Ant was using more URLs instead of files... Using my little resource: custom URL protocol, I could then easily reference any resource in $ANT_HOME/lib. Right now though, you can turn around the current limitations but first doing a get of the URL you want (and with resource: URLs, you can get resources too), and then use it as a file. Not ideal, but would work in most cases. What would be useful then if facilities within Ant to easily deal with the temporary files created, so that there's clean up automatically for example once the build terminates. As Stefan pointed out, making Ant use URLs instead of File in many tasks would be a major backward-incompatible undertaking. --DD -Original Message- From: Stefan Bodewig [mailto:[EMAIL PROTECTED] Sent: Friday, April 04, 2003 9:22 AM To: [EMAIL PROTECTED] Subject: Re: Using files in classpath in task file= On Fri, 04 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote: What I mean is not to change the passing of a File object. I mean that we can *wrap* an URL in a File. So we pass a File, and use an URL, getting a Virtual File System. How so - put the URI into the name and abuse File as a String? I'd really like to understand that. We are talking about java.io.File here 8-) Stefan
Re: Using files in classpath in task file=
On Fri, 04 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote: Sure. Look at the JDK 1.4 version, Ahh, far to modern for Ant. Because a URI can be navigated, and it's possible to make a File from a URI. Not always. org.apache.tools.vfs.File extends java.io.File But this version cannot be the argument for the (existing) setters. For this to work, IntrospectionHelper will need to take special care (i.e. if setXYZ(java.io.File) is found, actually pass it an instance of org.apache.tools.vfs.File). This is possible, but ... * Is this generally desirable? mkdir dir=http://www.apache.org// delete fileset dir=jar:http://my.server.com/applets/loader.jar; include name=**/*.gif/ /fileset /delete means what? If I sound harsh, please forgive me. I'm trying to show that in some situations it may be better to stick with files and we need a way to distinguish them. * is not as transparent as you say. Tasks could only use the URI if they first check that the object is is our version of File and cast to it. I.e. the change in IntrospectionHelper will only work for tasks that can handle it. Both points mean that it becomes hard to explain when URIs can get used and when not. Just as people have by now become so used to the relazive path resolution magic that happens inside Ant that they now report it as a bug if a ceratin attribute is not resolved relative to basedir, we will get bug reports that certain tasks do not deal with URLs of protocol foo properly. I find it hard to imagine that we'll be able to convert all tasks that could reasonably be expected to deal with URIs in one go. if I gave you just an url in the constructor, you could write almost, if not all, those methods. That really depends on the protocol you use. delete() for resources loaded from a jar located on a remote server, loaded via some P2P protocol? I may be making up things, I know. Am I really missing the obvious? Could as well be. Same here. Stefan
Re: Using files in classpath in task file=
Stefan Bodewig wrote, On 04/04/2003 17.55: On Fri, 04 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote: ... Because a URI can be navigated, and it's possible to make a File from a URI. Not always. Agreed, not always with the same features. Listing files in a http URL dir is not usually possible for instance. org.apache.tools.vfs.File extends java.io.File But this version cannot be the argument for the (existing) setters. For this to work, IntrospectionHelper will need to take special care (i.e. if setXYZ(java.io.File) is found, actually pass it an instance of org.apache.tools.vfs.File). This is possible, but ... * Is this generally desirable? Yes, this is the question. mkdir dir=http://www.apache.org// delete fileset dir=jar:http://my.server.com/applets/loader.jar; include name=**/*.gif/ /fileset /delete means what? Delete all gif files that are in the jar at http://my.server.com/applets/loader.jar. Commons VFS deals with many providers to make this possible, but it's not always possible, as with http that is generally not writeable. I would have the same problem if a local file was not writeable, it's consistent. If I sound harsh, please forgive me. Not at all, don't worry :-) I'm trying to show that in some situations it may be better to stick with files and we need a way to distinguish them. Yes, I knew that in many cases this was going to happen. But the above would through an error, as it happens with other non-writeable files. IIUC the main problem WRT this is that URLs are many times not writeable. * is not as transparent as you say. Tasks could only use the URI if they first check that the object is is our version of File and cast to it. No... that's not how it's supposed to be. What other method do they need? I can still navigate it, open it, read, sometimes write, all with the java.io.File signature. I.e. the change in IntrospectionHelper will only work for tasks that can handle it. Are you sure? Both points mean that it becomes hard to explain when URIs can get used and when not. Just as people have by now become so used to the relazive path resolution magic that happens inside Ant that they now report it as a bug if a ceratin attribute is not resolved relative to basedir, we will get bug reports that certain tasks do not deal with URLs of protocol foo properly. I find it hard to imagine that we'll be able to convert all tasks that could reasonably be expected to deal with URIs in one go. That again I would agree with. I believe that this solution can work *only* if we do not need to change the tasks *at all*. If we need to change the tasks, better using a new attribute. if I gave you just an url in the constructor, you could write almost, if not all, those methods. That really depends on the protocol you use. delete() for resources loaded from a jar located on a remote server, loaded via some P2P protocol? I may be making up things, I know. Yes, I know, but getting real: 1) is that a real use case 2) what makes it not possible or sensible to signal it's not featured? Am I really missing the obvious? Could as well be. Same here. I think we are nailing it now :-) -- Nicola Ken Barozzi [EMAIL PROTECTED] - verba volant, scripta manent - (discussions get forgotten, just code remains) -
DO NOT REPLY [Bug 18715] New: - [PATCH] subant to specify basedir to ant
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18715. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18715 [PATCH] subant to specify basedir to ant Summary: [PATCH] subant to specify basedir to ant Product: Ant Version: 1.5.3 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Enhancement Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] The patch applies to revision 1.1 of SubAnt.java in the cvs repository. It tries to achieve the following: * adds 'output' attribute to subant (directly corresponding to ant's attribute of the same name) * includes Gus Heck's patch (see http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18391) * fixes small bug with removal of 'target' attribute's default value (getOwningTarget().getName()) (removal occured on addition to cvs) * specifies now 'dir' attribute to delegated ant (under certain circumstances, see below) If the currently processed element of the 'buildpath' attribute is a filename, the original behaviour is preserved. But if the current element is a directoryname, the behaviour is as follows: * If the 'antfile' attribute is an absolute filename, then the following settings are given to ant: - dir=current element of 'buildpath' - antfile = the value of subant's 'antfile' attribute * If 'antfile' is not absolute (i.e. when the default value is used), the following settings apply to ant: - dir=current element of 'buildpath' - antfile = the absolute filename that results when subant's 'antfile' value is resolved against the current element of 'buildpath'. To specify absolute filenames as the 'antfile' attribute to ant (which is not documented, AFAICT) is possible because of the (also undocumented) behaviour of FileUtils.resolveFile(file, filename), that it returns File(filename) if filename is absolute. The check for absoluteness seems to be platform dependent. It would be nice, if the maintainers could state, whether this behaviour will be preserved (i.e. setting absolute filenames to ant's 'antfile'). For a short discussion about (and a rationale to) this patch, see http://marc.theaimsgroup.com/?t=10487670491r=1w=2. Please note that I've found no easy way to preserve full backwards compatibility as I've stated too rashly in my mail.
DO NOT REPLY [Bug 18715] - [PATCH] subant to specify basedir to ant
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18715. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18715 [PATCH] subant to specify basedir to ant --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 16:26 --- Created an attachment (id=5648) patch against SubAnt.java, revision 1.1
DO NOT REPLY [Bug 18717] New: - Missed defaultvalue attribute in input doc
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18717. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18717 Missed defaultvalue attribute in input doc Summary: Missed defaultvalue attribute in input doc Product: Ant Version: 1.6Alpha (nightly) Platform: All OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Documentation AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] When I started working with input I missed the ability for default values. So I wanted to add it ... and saw that it´s already there. :-) So it would be good, if the doc is enhanced (as long as it isn´t generated by XDoclet :-) Here the add´s (attribute and example - my diff doesn´t work right, so here as snippets): As last attribute: tr td valign=topdefaultvalue/td td valign=topDefines the default value of the property to be created from input. Property value will be set to default if not input is received./td td valign=top align=centerNo/td /tr As last example: pre lt;input message=quot;Please enter db-username:quot; addproperty=quot;db.userquot; defaultvalue=quot;Scott-Tigerquot; /gt;/pre pSame as above, but will set codedb.user/code to the value iScott- Tiger/i if the user enters no value (simply types lt;returngt;)./p
RE: Using files in classpath in task file=
On a related subject, one problem I have found is that there
is no portable way right now in ANT to obtain the URL of a file:
Currently we would do something like:
property name=fileloc location=${myfile}/
property name=fileurl value=file://${fileloc}/
but the number of //s is diferent for UNIX(2) and Windows(3),
and you have to do some nasty conditioning. I would like for ANT
to do this for me, transparently.
property name=fileurl locationURL=${myfile}/
or somethig like that. You need this for passing file parameters to
xslt/
Jose Alberto
-Original Message-
From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
Sent: 03 April 2003 07:18
To: [EMAIL PROTECTED]
Subject: Re: Using files in classpath in task file=
On Wed, 02 Apr 2003, Nicola Ken Barozzi [EMAIL PROTECTED] wrote:
If I had it in jars I could ship it automatically with the jar that
has the task that generated index.xml, so I can easily do something
like:
xslt in=index.xml out=index.html
style=resource:/a/style.xsl/
I see. What I don't see is how we could use an URI here without
breaking backwards compatibility.
In XSLTProcess we get the style parameter via setStyle(File), this
obviously cannot be called with anything else but a file object. If
we wanted general URIs, we'd have to change the signature and break
custom tasks that inherit from or delegate to instances of
XSLTProcess. No way.
I'd rather propose to add an alternative attribute styleURI or
something to XSLTProcess.
Be able to specify a URL for every task that needs a file, and that
thus uses the above fileutils method.
Again, not without changing the tasks to use something else, not File,
in their setter method and thus severely breaking backwards
compatibility.
Or maybe KISS and just add a getStyleResource(String
styleResource). It solves the immediate issue and doesn't open other
potential problems.
Seems the better way to me - at least until we are prepared to break
API compatibility on almost all tasks at once 8-)
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 15729] - StarTeam rootLocalFolder should be java.io.File
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15729. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15729 StarTeam rootLocalFolder should be java.io.File --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 17:49 --- Well by that no bug should be fixed because it is a backward compatibility issue ;-P No seriously, I think the StarTeam people needs to decide whether allowing whether to do ant to a file in a different directory should break a build (because CWD is different) or it should work because files are relative to basedir. I think the later is much better. Maybe some backward comp option should be OK or warning message. We should audit the code to see how many cases of this issues we stil have.
DO NOT REPLY [Bug 18402] - add support for a new target attribute finally
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18402. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18402 add support for a new target attribute finally --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 18:03 --- I have lobbyed for getting ANT-contrib as part of ANT 1.6 do not know if it will happen. Your syntax may be short, but it is not easy to achieve just like that. What do you do if you have multiple targets in a dependency chain and they all have the same finally=X what happens with the dependencies of X? Shall they be executed once? Multiple times? When in the order should they execute? It is not too clear, all that has to be formalized.
Re: Using files in classpath in task file=
Stefan Bodewig wrote: org.apache.tools.vfs.File extends java.io.File But this version cannot be the argument for the (existing) setters. For this to work, IntrospectionHelper will need to take special care (i.e. if setXYZ(java.io.File) is found, actually pass it an instance of org.apache.tools.vfs.File). This is possible, but ... It is a bit hacky, you're right. A cleaner solution would be to add setXYX( java.net.URL ) for tasks that can deal with URLs, and make this works ( i.e. IntrospectionHelper can deal with it ). Not sure if IH can deal with overloaded methods - and how it can distinguish if a String should be converted to File or URL. * Is this generally desirable? mkdir dir=http://www.apache.org// I think this would be better handled by some webDAV antlib. I agree, blindly turning file to URL is not the best solution. protocol foo properly. I find it hard to imagine that we'll be able to convert all tasks that could reasonably be expected to deal with URIs in one go. However we can do it incrementally. Adding an setXYZUrl(URL) attribute should work - without the overloaded method problems. Well - it can be just setXYZUrl( String ). All we need is to add the attributes to the tasks where it is needed. Should we add it to copy ? I don't know :-) But XSLT is a good candidate. Costin
XLTC task?
Just checking before I re-invent the wheel - is anyone else aware of an Ant task for compiling XSL stylesheets into translets? Kyle A.
RE: Need Help to use workspace in PVCS Task
Workspace needs to be a name as defined by PVCS, not a filesystem location. For example /@/Public/Dev. PVCS will use the workfile location set for the workspace for the files. This should probably go to the ant-users list, though. s -Original Message- From: Pothula, Satish Kumar Reddy (Cognizant) [mailto:[EMAIL PROTECTED] Sent: Thursday, April 03, 2003 8:18 PM To: [EMAIL PROTECTED] Subject: Need Help to use workspace in PVCS Task Hi, I am working on to automate the build process for our application using ANT Tool. We are using PVCS as version control for the source code. I am using 'pvcs' task in build.xml to download the source code from PVCS. I am able to download the source with no issues. I have to change the workfile location using the 'workspace' in PVCS Task. I need help on how to set the workspace in ant xml. I am working on windows NT. Below is the xml that i have defined. pvcs repository=C:\Program Files\PVCS\VM\newdb pvcsproject=/TempProject workspace=E:\tmp/ - I am the getting the following error --- getlatest: [pvcs] Executing 'pcli' with arguments: [pvcs] 'lvf' [pvcs] '-z' [pvcs] '-aw' [pvcs] '-spE:\tmp' [pvcs] '-prC:\Program Files\PVCS\VM\newdb' [pvcs] '/TempProject' [pvcs] [pvcs] The ' characters around the executable and arguments are [pvcs] not part of the command. [pvcs] PVCS Version Manager (VMGUI) v6.8.00 (Build 128) for Windows NT/80x8 6 [pvcs] Copyright 1985-2001 MERANT. All rights reserved. BUILD FAILED Failed executing: pcli lvf -z -aw -spE:\tmp -prC:\Program Files\PVCS\VM\newdb /TempProject at org.apache.tools.ant.taskdefs.optional.pvcs.Pvcs.execute(Pvcs.java:23 3) at org.apache.tools.ant.Task.perform(Task.java:341) at org.apache.tools.ant.Target.execute(Target.java:309) at org.apache.tools.ant.Target.performTasks(Target.java:336) at org.apache.tools.ant.Project.executeTarget(Project.java:1339) at org.apache.tools.ant.Project.executeTargets(Project.java:1255) at org.apache.tools.ant.Main.runBuild(Main.java:609) at org.apache.tools.ant.Main.start(Main.java:196) at org.apache.tools.ant.Main.main(Main.java:235) - Did i miss anything in defining the XML. Any Inputs on this is greatly appreciated Thanks, -Satish.
DO NOT REPLY [Bug 18722] - vssget task fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18722. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18722 vssget task fails [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 22:55 --- *** This bug has been marked as a duplicate of 4387 ***
DO NOT REPLY [Bug 18705] - Ant does not build: Java: UNIXProcess:forkAndExec: exec failed: Argument list too long
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18705. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18705 Ant does not build: Java: UNIXProcess:forkAndExec: exec failed: Argument list too long --- Additional Comments From [EMAIL PROTECTED] 2003-04-04 23:03 --- The command line being passed to 'chmod' is too long for your environment. Add '-Dchmod.fail=false' when building The build fails when setting permissions of the generated documentation, so it will not affect the produced distribution. Jesse
