cvs commit: ant/xdocs/stylesheets site.vsl
conor 2003/04/08 18:44:53 Modified:docs ant15_todo.html antnews.html bindownload.html contributors.html cvs.html external.html faq.html guidelines.html index.html legal.html license.html mail.html mission.html page.css problems.html projects.html resources.html srcdownload.html docs/projects index.html docs/projects/antidote design.html index.html module.html xdocsantnews.xml bindownload.xml index.xml srcdownload.xml xdocs/stylesheets site.vsl Log: Ant 1.5.3 release Revision ChangesPath 1.39 +2 -0 ant/docs/ant15_todo.html Index: ant15_todo.html === RCS file: /home/cvs/ant/docs/ant15_todo.html,v retrieving revision 1.38 retrieving revision 1.39 diff -u -w -u -r1.38 -r1.39 --- ant15_todo.html 4 Apr 2003 04:21:01 - 1.38 +++ ant15_todo.html 9 Apr 2003 01:44:48 - 1.39 @@ -160,6 +160,7 @@ img style=float: right height=10 width=10 border=0 alt= src=./images/menu-right.gif /div div class=lightbluebarnbsp;/div + div class=main div class=content h1 class=titleAnt 1.5 Release To-Do List/h1 h3 class=section @@ -577,6 +578,7 @@ /table /div + /div p class=copyright Copyright copy; 2000-2003nbsp;The Apache Software Foundation. All rights reserved. 1.67 +17 -0 ant/docs/antnews.html Index: antnews.html === RCS file: /home/cvs/ant/docs/antnews.html,v retrieving revision 1.66 retrieving revision 1.67 diff -u -w -u -r1.66 -r1.67 --- antnews.html 4 Apr 2003 04:21:01 - 1.66 +++ antnews.html 9 Apr 2003 01:44:48 - 1.67 @@ -164,9 +164,25 @@ img style=float: right height=10 width=10 border=0 alt= src=./images/menu-right.gif /div div class=lightbluebarnbsp;/div + div class=main div class=content h1 class=titleNews/h1 h3 class=section + a name=Ant 1.5.3/a + Ant 1.5.3 +/h3 +h3April 9, 2003 - Ant 1.5.3 Available/h3 +pApache Ant 1.5.3 is now available for + a href=http://ant.apache.org/beta/;download/a. +/p +div class=warning +div class=labelNote/div +div class=contentAnt 1.5.3 will be the last release that supports + JDK 1.1. The next major release of Ant, Ant 1.6, will require JDK 1.2 or + later +/div +/div +h3 class=section a name=Ant 1.5.3 Beta 1/a Ant 1.5.3 Beta 1 /h3 @@ -386,6 +402,7 @@ /p /div + /div p class=copyright Copyright copy; 2000-2003nbsp;The Apache Software Foundation. All rights reserved. 1.27 +22 -14ant/docs/bindownload.html Index: bindownload.html === RCS file: /home/cvs/ant/docs/bindownload.html,v retrieving revision 1.26 retrieving revision 1.27 diff -u -w -u -r1.26 -r1.27 --- bindownload.html 4 Apr 2003 04:21:01 - 1.26 +++ bindownload.html 9 Apr 2003 01:44:48 - 1.27 @@ -158,6 +158,7 @@ img style=float: right height=10 width=10 border=0 alt= src=./images/menu-right.gif /div div class=lightbluebarnbsp;/div + div class=main div class=content h1 class=titleDownloading Ant - Binary Distribution/h1 h3 class=section @@ -206,23 +207,29 @@ a name=Current Release of Ant/a Current Release of Ant /h3 -pCurrently, Apache Ant 1.5.2 is the best available version, see the +pCurrently, Apache Ant 1.5.3 is the best available version, see the a href=[preferred]/ant/README.htmlrelease notes/a./p +div class=warning +div class=labelNote/div +div class=contentAnt 1.5.3 has been released on 9-April-2003 and may not be available on all +mirrors for a few days +/div +/div ul licode.zip/code archive: -a href=[preferred]/ant/binaries/apache-ant-1.5.2-bin.zipapache-ant-1.5.2-bin.zip/a -[a href=http://www.apache.org/dist/ant/binaries/apache-ant-1.5.2-bin.zip.asc;PGP/a] -[a href=http://www.apache.org/dist/ant/binaries/apache-ant-1.5.2-bin.zip.md5;MD5/a]/li +a href=[preferred]/ant/binaries/apache-ant-1.5.3-bin.zipapache-ant-1.5.3-bin.zip/a +[a href=http://www.apache.org/dist/ant/binaries/apache-ant-1.5.3-bin.zip.asc;PGP/a] +[a
Re: cvs commit: ant/xdocs/stylesheets site.vsl
On Tuesday, April 8, 2003, at 09:44 PM, [EMAIL PROTECTED] wrote: + a href=http://ant.apache.org/beta/;download/a. Is this the intended download link? Jesse Stockall - [EMAIL PROTECTED] CRYPTOCard Corp.
cvs commit: ant/xdocs antnews.xml index.xml
conor 2003/04/08 20:05:26 Modified:docs antnews.html index.html xdocsantnews.xml index.xml Log: Fix link - oops Revision ChangesPath 1.68 +1 -1 ant/docs/antnews.html Index: antnews.html === RCS file: /home/cvs/ant/docs/antnews.html,v retrieving revision 1.67 retrieving revision 1.68 diff -u -w -u -r1.67 -r1.68 --- antnews.html 9 Apr 2003 01:44:48 - 1.67 +++ antnews.html 9 Apr 2003 03:05:25 - 1.68 @@ -173,7 +173,7 @@ /h3 h3April 9, 2003 - Ant 1.5.3 Available/h3 pApache Ant 1.5.3 is now available for - a href=http://ant.apache.org/beta/;download/a. + a href=http://ant.apache.org/bindownload.cgi;download/a. /p div class=warning div class=labelNote/div 1.278 +1 -1 ant/docs/index.html Index: index.html === RCS file: /home/cvs/ant/docs/index.html,v retrieving revision 1.277 retrieving revision 1.278 diff -u -w -u -r1.277 -r1.278 --- index.html9 Apr 2003 01:44:49 - 1.277 +++ index.html9 Apr 2003 03:05:26 - 1.278 @@ -170,7 +170,7 @@ Ant 1.5.3 /h3 pApache Ant 1.5.3 is now available for - a href=http://ant.apache.org/beta/;download/a. + a href=http://ant.apache.org/bindownload.cgi;download/a. /p div class=warning div class=labelNote/div 1.42 +1 -1 ant/xdocs/antnews.xml Index: antnews.xml === RCS file: /home/cvs/ant/xdocs/antnews.xml,v retrieving revision 1.41 retrieving revision 1.42 diff -u -w -u -r1.41 -r1.42 --- antnews.xml 9 Apr 2003 01:44:52 - 1.41 +++ antnews.xml 9 Apr 2003 03:05:26 - 1.42 @@ -12,7 +12,7 @@ section name=Ant 1.5.3 h3April 9, 2003 - Ant 1.5.3 Available/h3 pApache Ant 1.5.3 is now available for - a href=http://ant.apache.org/beta/;download/a. + a href=http://ant.apache.org/bindownload.cgi;download/a. /p div class=warning 1.46 +1 -1 ant/xdocs/index.xml Index: index.xml === RCS file: /home/cvs/ant/xdocs/index.xml,v retrieving revision 1.45 retrieving revision 1.46 diff -u -w -u -r1.45 -r1.46 --- index.xml 9 Apr 2003 01:44:53 - 1.45 +++ index.xml 9 Apr 2003 03:05:26 - 1.46 @@ -12,7 +12,7 @@ section name=Ant 1.5.3 pApache Ant 1.5.3 is now available for - a href=http://ant.apache.org/beta/;download/a. + a href=http://ant.apache.org/bindownload.cgi;download/a. /p div class=warning
Re: cvs commit: ant/xdocs/stylesheets site.vsl
On Wed, 9 Apr 2003 12:33 pm, Jesse Stockall wrote: On Tuesday, April 8, 2003, at 09:44 PM, [EMAIL PROTECTED] wrote: + a href=http://ant.apache.org/beta/;download/a. Is this the intended download link? Umm, no - fixed now - thanks Conor -- Conor MacNeill Blog: http://codefeed.com/blog/
1.5.3 Release
The 1.5.3 release is up on the site. I haven't had time to send the announcements out yet. Conor -- Conor MacNeill Blog: http://codefeed.com/blog/
Re: 1.5.3 Release
On Wed, 9 Apr 2003, Conor MacNeill [EMAIL PROTECTED] wrote: The 1.5.3 release is up on the site. I haven't had time to send the announcements out yet. Which may be good so that the mirrors have time to catch up. Freshmeat announcement is pending approval, next I'll do will be Usenet and the Jakarta Site (under elsewhere 8-). I'll let you do the various announce@ mailing lists. Stefan
Re: having datatypes load classes
On Tue, 08 Apr 2003, Marc Portier [EMAIL PROTECTED] wrote: but since that pattern is to be seen more around ant iteself, I was hoping for some reuse here One would think so, but the truth is that you'll find copy-paste reuse in this area instead of delegation or something. Patches for a nice little utility class are welcome 8-) Stefan
Re: having datatypes load classes
Stefan Bodewig wrote: On Tue, 08 Apr 2003, Marc Portier [EMAIL PROTECTED] wrote: but since that pattern is to be seen more around ant iteself, I was hoping for some reuse here One would think so, but the truth is that you'll find copy-paste reuse in this area instead of delegation or something. Patches for a nice little utility class are welcome 8-) Stefan, thx for the invitation, if others want to be on the party: please join. Have to think about this some more, and have to read the replies from Dominique first (which at first sight seem to go somewhat over the 'nice little' attributes that I was seeking as well) woke up with something along the lines of a ClassLoaderFactory (name should be tuned down a bit, too much expectations here, inspiration welcome, PathUtil?) - public ClassLoader getClassLoaderForPath(Path); having the responsibility to check off against the project map of references (as does the Definer) possibly having a variant - public ClassLoader getUniqueClassLoaderForPath(Path) while the first would follow the documented rules of the ant.reuse.loader property, the latter would always make a new one, and never store that in the references map. in fact if ant.reuse.loader == false the behaviour of both methods would be equal. combination of both offers the flexibility to cover all the use cases I see I'm guessing this approach would offer the least pressure on having to rethink more interfaces/existing stuff. (compared to e.g. introduction of the ClassLoader datatype that was suggested in the thread I mentioned) Another advantage I see is that it's orthogonal to existing stuff, so people could just use it without neading to switch to cvs head or something (me included :-)) The real effort would be in refactoring and testing the existing implementations to use this utility then (but that's somewhat future music) (also thinking about singleton vs statics for the beast) not overseeing _all_ use cases, and some general greenhorn feeling around the complete internals of ant makes me hesitate and think some more first though. but again, all of this might be in the answers from Dominique already. regards, -marc= Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Marc Portierhttp://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center Read my weblog at http://radio.weblogs.com/0116284/ [EMAIL PROTECTED] [EMAIL PROTECTED]
Re: 1.5.3 Release
congrats to all, I'm just the odd fresh one on this list... So maybe I'm just well placed for nothing that after the established popularity (which by the way it extends towards the other apache and jakarta projects is a real boost for the larger community at hand here) one might forget to thank a whole lot of individuals joining forces and making a difference. keep it up... -marc= Stefan Bodewig wrote: On Wed, 9 Apr 2003, Conor MacNeill [EMAIL PROTECTED] wrote: The 1.5.3 release is up on the site. I haven't had time to send the announcements out yet. Which may be good so that the mirrors have time to catch up. Freshmeat announcement is pending approval, next I'll do will be Usenet and the Jakarta Site (under elsewhere 8-). I'll let you do the various announce@ mailing lists. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Marc Portierhttp://outerthought.org/ Outerthought - Open Source, Java XML Competence Support Center Read my weblog at http://radio.weblogs.com/0116284/ [EMAIL PROTECTED] [EMAIL PROTECTED]
DO NOT REPLY [Bug 18849] New: - New skip attribute for HeadFilter and TailFilter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 New skip attribute for HeadFilter and TailFilter Summary: New skip attribute for HeadFilter and TailFilter Product: Ant Version: 1.6Alpha (nightly) Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Core AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] After discussing this topic on the [EMAIL PROTECTED] mailinglist (http://marc.theaimsgroup.com/?l=ant-userm=104981188307275w=2) I have written the implementation. Some JUnit-Tests for the new (and the old) functions and an Update of the docs. Because I am having troubles with creating diffs I attach a ZIP-File with the complete sources ... and my tries with the diffs ... I worked with the CVS-Head version of 09.Apr 2003.
DO NOT REPLY [Bug 18849] - New skip attribute for HeadFilter and TailFilter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 New skip attribute for HeadFilter and TailFilter --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 10:52 --- Created an attachment (id=5728) Modified Sources (Implementation, Test, Doc)
DO NOT REPLY [Bug 18849] - New skip attribute for HeadFilter and TailFilter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 New skip attribute for HeadFilter and TailFilter --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 10:53 --- Created an attachment (id=5729) Try of a Diff for org.apache.tools.ant.filters.TailFilter.java
DO NOT REPLY [Bug 18849] - New skip attribute for HeadFilter and TailFilter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 New skip attribute for HeadFilter and TailFilter --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 10:53 --- Created an attachment (id=5730) Try of a Diff for org.apache.tools.ant.filters.HeadFilter.java
DO NOT REPLY [Bug 18849] - New skip attribute for HeadFilter and TailFilter
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 New skip attribute for HeadFilter and TailFilter --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 10:54 --- Created an attachment (id=5731) Try of a Diff for docs\manual\CoreTypes\filterchain.html
DO NOT REPLY [Bug 18850] New: - Visual Source Safe History Does Not Allow Specific Users.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18850.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18850
Visual Source Safe History Does Not Allow Specific Users.
Summary: Visual Source Safe History Does Not Allow Specific
Users.
Product: Ant
Version: 1.5.3
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Normal
Priority: Other
Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Hi,
When using the vsshistory task, the user attribute is ignored. I have fixed
this locally in the
org\apache\tools\ant\taskdefs\optional\vss\MSVSSHISTORY.java file :
/**
* Executes the task.
* p
* Builds a command line to execute ss and then calls Exec's run method
* to execute the command line.
*/
public void execute() throws BuildException {
Commandline commandLine = new Commandline();
int result = 0;
// first off, make sure that we've got a command and a vssdir and a
label ...
if (getVsspath() == null) {
String msg = vsspath attribute must be set!;
throw new BuildException(msg, location);
}
// now look for illegal combinations of things ...
// build the command line from what we got the format is
// ss History elements [-H] [-L] [-N] [-O] [-V] [-Y] [-#] [-?]
// as specified in the SS.EXE help
commandLine.setExecutable(getSSCommand());
commandLine.createArgument().setValue(COMMAND_HISTORY);
// VSS items
commandLine.createArgument().setValue(getVsspath());
// -I-
commandLine.createArgument().setValue(-I-); // ignore all errors
// -V
// Label an existing file or project version
getVersionDateCommand(commandLine);
getVersionLabelCommand(commandLine);
// -R
if (m_Recursive) {
commandLine.createArgument().setValue(FLAG_RECURSION);
}
// -B / -D / -F-
if (m_Style.length() 0) {
commandLine.createArgument().setValue(m_Style);
}
// -Y
getLoginCommand(commandLine);
// ===
// ADD THE USER NAME TO THE COMMAND LINE
getUserCommand(commandLine);
// ===
// -O
getOutputCommand(commandLine);
System.out.println(***: + commandLine);
result = run(commandLine);
if (result != 0) {
String msg = Failed executing: + commandLine.toString();
throw new BuildException(msg, location);
}
}
Deferred datatype evaluation
I've been thinking as a result of this bug
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18700
I have made a change to the Configuration of UnknownElements so that non-tasks
types are not configured until their first use. This allows Ant to work
irrespective of the order in which data types are defined.
For example, given this simple build file (note testloc is used before
definition)
project name=deferred default=default
path id=test
pathelement location=${testloc}/
/path
property name=testloc location=testdir/
property name=result refid=test/
target name=default
echo message=Result is ${result}/
/target
/project
Ant 1.5.3 will give
Result is /home/conor/development/apache/ant-bugs/scratch/${testloc}
whilst with this patch, Ant 1.6 will give
Result is /home/conor/development/apache/ant-bugs/scratch/testdir
which is kind of cool. Far less procedural.
I'm attaching a patch to show the changes but I want to get some feedback if
this is desirable before committing.
Currently two tests fail (taskname case sensitivity and classfiletest). I
haven't looked into these failures yet - it may be a problem or something
I've broken. I don't want to bother until there is consensus that this is
interesting.
Thoughts?
Conor
--
Conor MacNeill
Blog: http://codefeed.com/blog/Index: src/main/org/apache/tools/ant/Project.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/Project.java,v
retrieving revision 1.133
diff -3 -u -w -p -r1.133 Project.java
--- src/main/org/apache/tools/ant/Project.java 3 Apr 2003 14:44:01 -
1.133
+++ src/main/org/apache/tools/ant/Project.java 9 Apr 2003 12:06:06 -
@@ -2201,13 +2201,16 @@ public class Project {
*/
public Object get(Object key) {
//System.out.println(AntRefTable.get + key);
-Object o = super.get(key);
-if (o instanceof UnknownElement) {
+Object ref = super.get(key);
+if (ref instanceof UnknownElement) {
// Make sure that
-((UnknownElement) o).maybeConfigure();
-o = ((UnknownElement) o).getTask();
+((UnknownElement) ref).resolve(false);
+ref = ((UnknownElement) ref).getTask();
+if (ref == null) {
+ref = super.get(key);
}
-return o;
+}
+return ref;
}
}
Index: src/main/org/apache/tools/ant/UnknownElement.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/UnknownElement.java,v
retrieving revision 1.45
diff -3 -u -w -p -r1.45 UnknownElement.java
--- src/main/org/apache/tools/ant/UnknownElement.java 6 Apr 2003 09:30:56
- 1.45
+++ src/main/org/apache/tools/ant/UnknownElement.java 9 Apr 2003 12:06:08
-
@@ -117,22 +117,25 @@ public class UnknownElement extends Task
* @exception BuildException if the configuration fails
*/
public void maybeConfigure() throws BuildException {
+resolve(true);
+}
+
+public void resolve(boolean deferDataType) {
//ProjectComponentHelper
helper=ProjectComponentHelper.getProjectComponentHelper();
//realThing = helper.createProjectComponent( this, getProject(), null,
// this.getTag());
+if (deferDataType) {
+realThing = makeTask(this, getWrapper());
+if (realThing == null) {
+// must be a data type - defer config to first use
+return;
+}
+} else {
realThing = makeObject(this, getWrapper());
+}
getWrapper().setProxy(realThing);
-if (realThing instanceof Task) {
-Task task = (Task) realThing;
-
-task.setRuntimeConfigurableWrapper(getWrapper());
-
-// For Script to work. Ugly
-// The reference is replaced by RuntimeConfigurable
-this.getOwningTarget().replaceChild(this, (Task) realThing);
-}
handleChildren(realThing, getWrapper());
@@ -215,10 +218,8 @@ public class UnknownElement extends Task
*/
public void execute() {
if (realThing == null) {
-// plain impossible to get here, maybeConfigure should
-// have thrown an exception.
-throw new BuildException(Could not create task of type:
- + elementName, getLocation());
+// not a task - so nothing to execute.
+return;
}
if (realThing instanceof Task) {
@@ -328,6 +329,11 @@ public class UnknownElement extends Task
task.setLocation(getLocation());
// UnknownElement always has an associated target
task.setOwningTarget(getOwningTarget());
+
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs MatchingTask.java
bodewig 2003/04/09 05:46:17
Modified:src/main/org/apache/tools/ant/taskdefs MatchingTask.java
Log:
Don't defer setting of default excludes for the implicit fileset,
thereby making tar basedir=... and zip basedir=... honor this
attribute.
PR: 18637
Revision ChangesPath
1.33 +1 -3
ant/src/main/org/apache/tools/ant/taskdefs/MatchingTask.java
Index: MatchingTask.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/MatchingTask.java,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- MatchingTask.java 7 Mar 2003 11:23:02 - 1.32
+++ MatchingTask.java 9 Apr 2003 12:46:17 - 1.33
@@ -96,7 +96,6 @@
public abstract class MatchingTask extends Task implements SelectorContainer
{
-protected boolean useDefaultExcludes = true;
protected FileSet fileset = new FileSet();
/**
@@ -214,7 +213,7 @@
* shouldn't be used.
*/
public void setDefaultexcludes(boolean useDefaultExcludes) {
-this.useDefaultExcludes = useDefaultExcludes;
+fileset.setDefaultexcludes(useDefaultExcludes);
}
/**
@@ -222,7 +221,6 @@
*/
protected DirectoryScanner getDirectoryScanner(File baseDir) {
fileset.setDir(baseDir);
-fileset.setDefaultexcludes(useDefaultExcludes);
return fileset.getDirectoryScanner(getProject());
}
cvs commit: ant WHATSNEW
bodewig 2003/04/09 05:47:41 Modified:.WHATSNEW Log: Keep record of fixed bugs Revision ChangesPath 1.390 +3 -0 ant/WHATSNEW Index: WHATSNEW === RCS file: /home/cvs/ant/WHATSNEW,v retrieving revision 1.389 retrieving revision 1.390 diff -u -r1.389 -r1.390 --- WHATSNEW 4 Apr 2003 09:08:51 - 1.389 +++ WHATSNEW 9 Apr 2003 12:47:41 - 1.390 @@ -87,6 +87,9 @@ * The index created by jar didn't conform to the spec as it didn't include the top-level entries. Bugzilla Report 16972. +* tar and zip didn't honor the defaultexcludes attribute for the + implicit fileset. Bugzilla Report 18637. + Other changes: -- * Shipped XML parser is now Xerces 2.4.0
DO NOT REPLY [Bug 18637] - defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18637 defaultexcludes not works with zip,tar,jar tasks or bag with CVS directories [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 12:49 --- Should be fixed with nightly build 2003-04-10.
DO NOT REPLY [Bug 18852] - core task war still broken in 1.5.3
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18852.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18852
core task war still broken in 1.5.3
--- Additional Comments From [EMAIL PROTECTED] 2003-04-09 13:03 ---
This is strange for several reasons (apart from the fact that it works for me).
The exclude of *.class shouldn't be necessary at all as you already have an
include element.
Are you sure that the class files are not getting into WEB-INF/classes by a
different (zip)fileset?
Can you send us a snippet of ant -debug? The relevant part should begin with
Setup scanner in dir ${bin}${file.separator}classes with patternset { includes:
*.properties excludes: **/*.class}
or something close to that and show the .class files being added after that.
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs SQLExec.java
bodewig 2003/04/09 06:15:31
Modified:.WHATSNEW
docs/manual/CoreTasks sql.html
src/main/org/apache/tools/ant/taskdefs SQLExec.java
Log:
Provide user control over Statement's escape processing.
PR: 18822
Revision ChangesPath
1.391 +2 -0 ant/WHATSNEW
Index: WHATSNEW
===
RCS file: /home/cvs/ant/WHATSNEW,v
retrieving revision 1.390
retrieving revision 1.391
diff -u -r1.390 -r1.391
--- WHATSNEW 9 Apr 2003 12:47:41 - 1.390
+++ WHATSNEW 9 Apr 2003 13:15:31 - 1.391
@@ -223,6 +223,8 @@
* javacc and jjtree will now autodetect JavaCC 3.x and can use it.
+* sql has a new attribute to control escape processing.
+
Changes from Ant 1.5.2 to Ant 1.5.3
===
1.20 +10 -0 ant/docs/manual/CoreTasks/sql.html
Index: sql.html
===
RCS file: /home/cvs/ant/docs/manual/CoreTasks/sql.html,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- sql.html 4 Apr 2003 08:50:07 - 1.19
+++ sql.html 9 Apr 2003 13:15:31 - 1.20
@@ -139,6 +139,16 @@
td width=10% valign=topNo (defaul=false)/td
/tr
+tr
+ td width=12% valign=topescapeprocessing/td
+ td width=78% valign=topControl whether the Java statement
+object will perform escape substitution.br
+See a
+
href=http://java.sun.com/j2se/1.4.2/docs/api/java/sql/Statement.html#setEscapeProcessing(boolean)Statement's
+API docs/a for details. emsince Ant 1.6/em.
+ td width=10% valign=topNo (defaul=true)/td
+/tr
+
/table
h3Parameters specified as nested elements/h3
1.53 +17 -1 ant/src/main/org/apache/tools/ant/taskdefs/SQLExec.java
Index: SQLExec.java
===
RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/SQLExec.java,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -r1.52 -r1.53
--- SQLExec.java 4 Apr 2003 13:51:11 - 1.52
+++ SQLExec.java 9 Apr 2003 13:15:31 - 1.53
@@ -210,6 +210,13 @@
private boolean keepformat = false;
/**
+ * Argument to Statement.setEscapeProcessing
+ *
+ * @since Ant 1.6
+ */
+private boolean escapeProcessing = true;
+
+/**
* Set the name of the SQL file to be run.
* Required unless statements are enclosed in the build file
*/
@@ -328,6 +335,15 @@
}
/**
+ * Set escape processing for statements.
+ *
+ * @since Ant 1.6
+ */
+public void setEscapeProcessing(boolean enable) {
+escapeProcessing = enable;
+}
+
+/**
* Load the sql file and then execute it
*/
public void execute() throws BuildException {
@@ -375,7 +391,7 @@
}
try {
statement = conn.createStatement();
-
+statement.setEscapeProcessing(escapeProcessing);
PrintStream out = System.out;
try {
DO NOT REPLY [Bug 18754] - ant hangs, if the printsummary-attribute of a junit-task in a parallel task is wrong
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18754. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18754 ant hangs, if the printsummary-attribute of a junit-task in a parallel task is wrong --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 13:27 --- Hmm, does your start_server ever finish? I.e. will your antcall return if you never call stop_server in stand-alone invocations?
DO NOT REPLY [Bug 18754] - ant hangs, if the printsummary-attribute of a junit-task in a parallel task is wrong
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18754. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18754 ant hangs, if the printsummary-attribute of a junit-task in a parallel task is wrong --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 13:37 --- No, stop_server isn't finished by itself. It needs the call of the stop_server target to finish.
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional Javah.java
bodewig 2003/04/09 06:36:32
Modified:.WHATSNEW
src/main/org/apache/tools/ant/taskdefs/optional Javah.java
Log:
Make javah work on JDK 1.4.2.
PR: 18667
Submitted by: James Allers jallers at advancedreality dot com
Revision ChangesPath
1.392 +2 -0 ant/WHATSNEW
Index: WHATSNEW
===
RCS file: /home/cvs/ant/WHATSNEW,v
retrieving revision 1.391
retrieving revision 1.392
diff -u -r1.391 -r1.392
--- WHATSNEW 9 Apr 2003 13:15:31 - 1.391
+++ WHATSNEW 9 Apr 2003 13:36:32 - 1.392
@@ -225,6 +225,8 @@
* sql has a new attribute to control escape processing.
+* javah will invoke oldjavah on JDK 1.4.2. Bugzilla Report 18667.
+
Changes from Ant 1.5.2 to Ant 1.5.3
===
1.22 +25 -9
ant/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java
Index: Javah.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/Javah.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- Javah.java10 Feb 2003 14:13:45 - 1.21
+++ Javah.java9 Apr 2003 13:36:32 - 1.22
@@ -55,6 +55,8 @@
package org.apache.tools.ant.taskdefs.optional;
import java.io.File;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.Method;
import java.util.Enumeration;
import java.util.StringTokenizer;
import java.util.Vector;
@@ -335,15 +337,29 @@
throw new BuildException(Compile failed);
}
*/
+
+
try {
-// Javac uses logstr to change the output stream and calls
-// the constructor's invoke method to create a compiler instance
-// dynamically. However, javah has a different interface and this
-// makes it harder, so here's a simple alternative.
-
//--
-com.sun.tools.javah.Main main
-= new com.sun.tools.javah.Main(cmd.getArguments());
-main.run();
+Class javahMainClass = null;
+try {
+// first search for the old javah class in 1.4.2 tools.jar
+javahMainClass =
Class.forName(com.sun.tools.javah.oldjavah.Main);
+} catch(ClassNotFoundException cnfe) {
+// assume older than 1.4.2 tools.jar
+javahMainClass = Class.forName(com.sun.tools.javah.Main);
+}
+
+// now search for the constructor that takes in String[]
arguments.
+Class[] strings = new Class[] {String[].class};
+Constructor constructor = javahMainClass.getConstructor(strings);
+
+// construct the javah Main instance
+Object javahMain = constructor.newInstance(new Object[]
{cmd.getArguments()});
+
+// find the run method
+Method runMethod = javahMainClass.getMethod(run,new Class[0]);
+
+runMethod.invoke(javahMain,new Object[0]);
} catch (Exception ex) {
if (ex instanceof BuildException) {
throw (BuildException) ex;
@@ -352,7 +368,7 @@
}
}
}
-
+
/**
* Does the command line argument processing common to classic and
* modern.
DO NOT REPLY [Bug 18667] - javah module no longer works with Java 1.4.2
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18667. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18667 javah module no longer works with Java 1.4.2 [EMAIL PROTECTED] changed: What|Removed |Added Severity|Blocker |Normal Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.6 Version|1.5.1 |1.5.3 --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 13:39 --- Thanks james, patch will be in nightly build 2003-04-10.
DO NOT REPLY [Bug 18754] - ant hangs, if the printsummary-attribute of a junit-task in a parallel task is wrong
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18754. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18754 ant hangs, if the printsummary-attribute of a junit-task in a parallel task is wrong [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 13:52 --- Well, there's the problem. Your defunct junit makes the build fail in one thread and Ant waits for the other thread to finish - which never happens. There isn't much Ant can currently do.
DO NOT REPLY [Bug 18670] - Checksum validation against property always fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670 Checksum validation against property always fails [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Target Milestone|--- |1.6
DO NOT REPLY [Bug 18670] - Checksum validation against property always fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670 Checksum validation against property always fails [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 13:59 --- I can reproduce this.
DO NOT REPLY [Bug 18862] New: - FileSet's should simply ignore when the directory does not exist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18862. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18862 FileSet's should simply ignore when the directory does not exist Summary: FileSet's should simply ignore when the directory does not exist Product: Ant Version: unspecified Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Core AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] It would be nice if Ant would not fail on these: fileset dir=someNonExistentDir/ The meaning really should be that there are no files in that fileset. Any objections to this change being made in the 1.6 version? Any issues that would be caused by this change?
DO NOT REPLY [Bug 18863] New: - provide better error messages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18863. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18863 provide better error messages Summary: provide better error messages Product: Ant Version: 1.5.3 Platform: PC OS/Version: Windows NT/2K Status: NEW Severity: Major Priority: Other Component: Build Process AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I changed my ant buildfile and now i can't start any task anymore because as soon as i start ant, just the following output appears: BUILD FAILED Error reading project file: Invalid byte 2 of 3-byte UTF-8 sequence. so, what does it mean? in which line or in which target does this error occur? i changed a lot of things and also turned on show special characters in my text editor but i can't find any error or special characters in my build file ... :-(
DO NOT REPLY [Bug 18670] - Checksum validation against property always fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18670
Checksum validation against property always fails
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution||INVALID
--- Additional Comments From [EMAIL PROTECTED] 2003-04-09 14:20 ---
Oh my, we have a problem, or maybe not. The problem is that the docs are
confusing as hell and the property attribute is overloaded too much.
If you are storing the checksum, its value is the name of a property. If you
are verifying, its value is the value to compare with (one level of indirection
less). So
checksum property=checksum file=checksum.xml/
checksum property=${checksum} file=checksum.xml
verifyproperty=verifiy/
should work.
I'd love to fix this inconsistency, but it is impossible as the examples show
the usage of ${md5} as property's value. All we can do is clarifying the docs.
Changing the meaning of the property attribute to be consistent would break
existing build files and cannot be done.
cvs commit: ant/src/etc/testcases/taskdefs checksum.xml
bodewig 2003/04/09 07:23:01
Modified:src/etc/testcases/taskdefs checksum.xml
Log:
There is no bug
Revision ChangesPath
1.3 +2 -1 ant/src/etc/testcases/taskdefs/checksum.xml
Index: checksum.xml
===
RCS file: /home/cvs/ant/src/etc/testcases/taskdefs/checksum.xml,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- checksum.xml 9 Apr 2003 14:02:23 - 1.2
+++ checksum.xml 9 Apr 2003 14:23:01 - 1.3
@@ -39,6 +39,7 @@
target name=verifyFromProperty
checksum property=checksum file=checksum.xml/
-checksum property=checksum file=checksum.xml
verifyproperty=verify/
+checksum property=${checksum} file=checksum.xml
+ verifyproperty=verify/
/target
/project
RE: having datatypes load classes
Two comments:
1) DynamicTag is fully Ant 1.5.x compatible. No need for 1.6. Just use it
along side your own classes, and you're good to go.
2) DynamicTag *relies* on taskdef or typedef (you can declare your
custom extension either way), which takes care of all the classloading,
already has all the special stuff like loaderref. Any enhancement to these
tasks automatically benefit DynamicTag.
With your use case, imagine you have a JAR of all your filters, with a
properties file within it called filters.properties like so:
xincludefilter = org.outerj.xml.XIncludeFilter
filter1 = org.outerj.xml.SomeFilter
You could do:
typedef resource=org/outerj/xml/filters.properties
classpath=org_outerj_xml.jar /
target name=test depends=-init
xmlchain toDir=./build/chain extension=.xxx
fileset refid=workOnStuf /
customfilters
filter1 attr1=v1 attr2=v2
mysubelement .../
/filter1
xincludefilter .../
customfilters
xmlfilter refid=other-filter/
/xmlchain
/target
And in your code, all you have to do is:
public Object createCustomFilters() {
// dynatag must contain at least 1 element, no upper limit
DynamicTag dynatag = new DynamicTag(org.outerj.xml.XmlFilter.class,
1, Integet.MAX_INT);
_filterVector.addElement(dynatag);
return dynatag;
}
Then at execute time, convert the DynamicTags added to the vector to real
filters (pseudo-code):
Vector filters = new Vector();
foreach o in _filterVector {
if (o instanceof DynamicTag) {
filters.addAll(((DynamicTag)o).getTags());
}
}
DynamicTag guarantees you all elements within it are of the required type,
the fictitious XmlFilter interface here. The really nice part is that you
code XIncludeFilter and SomeFilter like a regular bean, and Ant
automatically configures it using its normal rules (calls setters methods,
or add/create methods, with all the magic type conversion it does to go from
String to int, File (resolved to basedir), etc...). Your current filters
might not have much in term of configuration now, but DynamicTag allows a
very rich configuration of any extension point.
I personally think it's pretty elegant, and doesn't require mucking at all
with class loading issues.
But again, my perspective is biased, since I authored DynamicTag. --DD
-Original Message-
From: Marc Portier [mailto:[EMAIL PROTECTED]
Sent: Wednesday, April 09, 2003 1:32 AM
To: Ant Developers List
Subject: Re: having datatypes load classes
Stefan Bodewig wrote:
On Tue, 08 Apr 2003, Marc Portier [EMAIL PROTECTED] wrote:
but since that pattern is to be seen more around ant iteself, I was
hoping for some reuse here
One would think so, but the truth is that you'll find copy-paste reuse
in this area instead of delegation or something.
Patches for a nice little utility class are welcome 8-)
Stefan,
thx for the invitation, if others want to be on the party: please
join.
Have to think about this some more,
and have to read the replies from Dominique first (which at first
sight seem to go somewhat over the 'nice little' attributes that
I was seeking as well)
woke up with something along the lines of a
ClassLoaderFactory (name should be tuned down a bit, too much
expectations here, inspiration welcome, PathUtil?)
- public ClassLoader getClassLoaderForPath(Path);
having the responsibility to check off against the project map of
references (as does the Definer)
possibly having a variant
- public ClassLoader getUniqueClassLoaderForPath(Path)
while the first would follow the documented rules of the
ant.reuse.loader property, the latter would always make a new
one, and never store that in the references map.
in fact if ant.reuse.loader == false the behaviour of both
methods would be equal.
combination of both offers the flexibility to cover all the use
cases I see
I'm guessing this approach would offer the least pressure on
having to rethink more interfaces/existing stuff. (compared to
e.g. introduction of the ClassLoader datatype that was suggested
in the thread I mentioned)
Another advantage I see is that it's orthogonal to existing
stuff, so people could just use it without neading to switch to
cvs head or something (me included :-))
The real effort would be in refactoring and testing the existing
implementations to use this utility then (but that's somewhat
future music)
(also thinking about singleton vs statics for the beast)
not overseeing _all_ use cases, and some general greenhorn
feeling around the complete internals of ant makes me hesitate
and think some more first though.
but again, all of this might be in the answers from Dominique
already.
regards,
-marc=
cvs commit: ant/docs/manual/CoreTasks checksum.html
bodewig 2003/04/09 07:31:47 Modified:docs/manual/CoreTasks checksum.html Log: Clarify docs Revision ChangesPath 1.6 +12 -5 ant/docs/manual/CoreTasks/checksum.html Index: checksum.html === RCS file: /home/cvs/ant/docs/manual/CoreTasks/checksum.html,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- checksum.html 22 Jun 2002 23:38:27 - 1.5 +++ checksum.html 9 Apr 2003 14:31:47 - 1.6 @@ -50,10 +50,17 @@ /tr tr td valign=topproperty/td -td valign=topSpecifies the name of the property to be set -with the generated checksum value. This cannot be specified -when fileext is being used or when the number of files -for which checksums is to be generated is greater than 1. +td valign=topThis attribute can mean two different things, it +depends on the presence of the verifyproperty attribute.br/ +bIf you don't set the verifyproperty attribute/b, property +specifies the name of the property to be set with the generated +checksum value.br/ +bIf you set the verifyproperty attribute/b, property specifies +the checksum you expect to be generated (the checksum itself, not +a name of a property containing the checksum).br/ +This cannot be specified when fileext is being used or when the +number of files for which checksums is to be generated is greater +than 1. /td td valign=top align=centerNo/td /tr @@ -151,7 +158,7 @@ the result will be true only if the checksums matched correctly for all files being considered. -hrp align=centerCopyright copy; 2001-2002 Apache Software Foundation. All rights +hrp align=centerCopyright copy; 2001-2003 Apache Software Foundation. All rights Reserved./p /body
cvs commit: ant/docs/manual/CoreTasks checksum.html
bodewig 2003/04/09 07:32:03 Modified:docs/manual/CoreTasks Tag: ANT_15_BRANCH checksum.html Log: Clarify docs Revision ChangesPath No revision No revision 1.4.2.4 +12 -5 ant/docs/manual/CoreTasks/checksum.html Index: checksum.html === RCS file: /home/cvs/ant/docs/manual/CoreTasks/checksum.html,v retrieving revision 1.4.2.3 retrieving revision 1.4.2.4 diff -u -r1.4.2.3 -r1.4.2.4 --- checksum.html 12 Jun 2002 08:48:20 - 1.4.2.3 +++ checksum.html 9 Apr 2003 14:32:03 - 1.4.2.4 @@ -50,10 +50,17 @@ /tr tr td valign=topproperty/td -td valign=topSpecifies the name of the property to be set -with the generated checksum value. This cannot be specified -when fileext is being used or when the number of files -for which checksums is to be generated is greater than 1. +td valign=topThis attribute can mean two different things, it +depends on the presence of the verifyproperty attribute.br/ +bIf you don't set the verifyproperty attribute/b, property +specifies the name of the property to be set with the generated +checksum value.br/ +bIf you set the verifyproperty attribute/b, property specifies +the checksum you expect to be generated (the checksum itself, not +a name of a property containing the checksum).br/ +This cannot be specified when fileext is being used or when the +number of files for which checksums is to be generated is greater +than 1. /td td valign=top align=centerNo/td /tr @@ -151,7 +158,7 @@ the result will be true only if the checksums matched correctly for all files being considered. -hrp align=centerCopyright copy; 2001-2002 Apache Software Foundation. All rights +hrp align=centerCopyright copy; 2001-2003 Apache Software Foundation. All rights Reserved./p /body
DO NOT REPLY [Bug 18862] - FileSet's should simply ignore when the directory does not exist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18862. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18862 FileSet's should simply ignore when the directory does not exist [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 15:12 --- *** This bug has been marked as a duplicate of 11270 ***
DO NOT REPLY [Bug 11270] - FileSet and DirSet break if the directory does not exist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11270. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11270 FileSet and DirSet break if the directory does not exist [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||m --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 15:12 --- *** Bug 18862 has been marked as a duplicate of this bug. ***
DO NOT REPLY [Bug 18863] - provide better error messages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18863. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18863 provide better error messages --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 15:15 --- Can you run with -debug and see if you get a stack trace. Also (since you have a .de address), do you have any German characters in there, perhaps? Thanks
DO NOT REPLY [Bug 18863] - provide better error messages
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18863. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18863 provide better error messages [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 15:18 --- There is nothing Ant can do, the error message comes straight from the XML parser. What it is trying to tell you: * You didn't say which encoding your build file is in (in the ?xml? thingy at the top). Consequently the parser assumes that you are using UTF-8. * Your build file is not valid UTF-8 encoded. Given your email address, I assume you have German Umlauts in some comments, does using ?xml version=1.0 encoding=ISO-8859-1 ? at the top of your build file help?
DO NOT REPLY [Bug 18625] - replacetokens: token with empty value throws IndexOutOfBoundsException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18625. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18625 replacetokens: token with empty value throws IndexOutOfBoundsException [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Target Milestone|--- |1.6
cvs commit: ant/src/main/org/apache/tools/ant/filters ReplaceTokens.java
bodewig 2003/04/09 08:37:57
Modified:.WHATSNEW
src/main/org/apache/tools/ant/filters ReplaceTokens.java
Log:
Don't die on empty values.
PR: 18625
Revision ChangesPath
1.393 +3 -0 ant/WHATSNEW
Index: WHATSNEW
===
RCS file: /home/cvs/ant/WHATSNEW,v
retrieving revision 1.392
retrieving revision 1.393
diff -u -r1.392 -r1.393
--- WHATSNEW 9 Apr 2003 13:36:32 - 1.392
+++ WHATSNEW 9 Apr 2003 15:37:57 - 1.393
@@ -90,6 +90,9 @@
* tar and zip didn't honor the defaultexcludes attribute for the
implicit fileset. Bugzilla Report 18637.
+* The replacetokens filter would throw an exception if the token's
+ value was an empty string. Bugzilla Report 18625.
+
Other changes:
--
* Shipped XML parser is now Xerces 2.4.0
1.11 +4 -2
ant/src/main/org/apache/tools/ant/filters/ReplaceTokens.java
Index: ReplaceTokens.java
===
RCS file:
/home/cvs/ant/src/main/org/apache/tools/ant/filters/ReplaceTokens.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- ReplaceTokens.java19 Feb 2003 14:40:37 - 1.10
+++ ReplaceTokens.java9 Apr 2003 15:37:57 - 1.11
@@ -190,8 +190,10 @@
final String replaceWith = (String) hash.get(key.toString());
if (replaceWith != null) {
-replaceData = replaceWith;
-replaceIndex = 0;
+if (replaceWith.length() 0) {
+replaceData = replaceWith;
+replaceIndex = 0;
+}
return read();
} else {
String newData = key.toString() + endToken;
DO NOT REPLY [Bug 18625] - replacetokens: token with empty value throws IndexOutOfBoundsException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18625. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18625 replacetokens: token with empty value throws IndexOutOfBoundsException [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 15:40 --- fixed in nightly build 2003-04-10.
DO NOT REPLY [Bug 18543] - Cannot work with j2ee1.3.1.jar
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18543. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18543 Cannot work with j2ee1.3.1.jar --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 15:49 --- fork junit. I have no idea why replacing xml-apis.jar and xercesImpl.jar with j2ee.jar doesn't work. Any useful error messages?
DO NOT REPLY [Bug 18868] New: - Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868 Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath Summary: Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath Product: Ant Version: 1.6Alpha (nightly) Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Wrapper scripts AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] It would be helpfull to be able to add zip files to the $ANT_HOME/lib directory and have then added to the classpath as jar files are.
DO NOT REPLY [Bug 18868] - Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868 Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 16:21 --- Created an attachment (id=5738) diff -u of ant wrapper script
DO NOT REPLY [Bug 18868] - Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868 Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 16:21 --- Created an attachment (id=5739) diff -u of ant.bat wrapper script
DO NOT REPLY [Bug 18868] - Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868 Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 17:28 --- We are terriefed of changing ant.bat, it is more trouble than it is worth -and will go away almost completely in ant1.6 final. The specific issue you have -inclusing zip files, is one that I think has been rejected in the past on the basis that renaming the files .jar works. Distributing stuff in .zip form is a very outdated practice. Out of curiosity, whose libraries are the particular problem -they arent from Oracle, are they?
testlet.jar?
Does anyone have testlet.jar they can send me? It's one of the library dependencies for the deprecated test task. Matt Bishop bea Systems 999 North Northlake Way Seattle, WA 98103 206.926.2924 - phone http://www.bea.com
DO NOT REPLY [Bug 18868] - Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868 Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 18:35 --- Yep, Oracle drivers. How'd you guess ;) If renaming works, I will go with that. Thanks.
DO NOT REPLY [Bug 18868] - Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18868 Modify ant startup script to add $ANT_HOME/lib/*.zip to classpath [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID
DO NOT REPLY [Bug 18876] New: - signjar is incorrect to its documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18876. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18876 signjar is incorrect to its documentation Summary: signjar is incorrect to its documentation Product: Ant Version: 1.5.3 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The signjar task strongly suggests that the jar attribute is required, and that a fileset may be used for jar specification. In fact either, but not both, of jar and fileset can specify the file(s) to sign. It strongly suggests that files will only be signed if they were unsigned, where this action also requires lazy=true. It uses the full alias to validate if the signature file exists, whereas the definition of jarsigner's default is that only the first 8 characters of the alias will be used. The sigfile is used to specify a signature file other than the alias, but this is never checked in signjar. I will attach a suggested update to signjar.java and signjar.html to ease the confusion of trying to optimally sign jars.
DO NOT REPLY [Bug 18876] - signjar is incorrect to its documentation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18876. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18876 signjar is incorrect to its documentation --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 19:44 --- Created an attachment (id=5744) a suggested update to signjar.java
DO NOT REPLY [Bug 18879] New: - problem with multiple buildnumber tasks
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18879. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18879 problem with multiple buildnumber tasks Summary: problem with multiple buildnumber tasks Product: Ant Version: 1.5.1 Platform: All OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I have an ant script that contains more than one buildnumber tags. The first tag sets the build.number property correctly, but further buildnumber tags seem to have no effect on the property. Example: I have two files, a.number and b.number. The build number in a.number is 10 and the build number in b.number is 20. My script contains buildnumber file=a.number/ buildnumber file=b.number/ After execution, both files have been updated correctly to 11 and 21. However, the property build.number contains the value 10.
DO NOT REPLY [Bug 18882] - zip task ignores the file .cvsignore
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18882. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18882 zip task ignores the file .cvsignore --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 21:34 --- Created an attachment (id=5752) Zip file generated by Ant script
DO NOT REPLY [Bug 18882] - zip task ignores the file .cvsignore
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18882. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18882 zip task ignores the file .cvsignore --- Additional Comments From [EMAIL PROTECTED] 2003-04-09 21:50 --- FileSet (and ZipFileSet) by extension, has default Excludes which contains a .cvsignore pattern. Please see the documentation of FileSet for the attribute that allows to not use these default excludes. --DD
DO NOT REPLY [Bug 18884] New: - stcheckout should handle a convertCRLF flag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18884.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18884
stcheckout should handle a convertCRLF flag
Summary: stcheckout should handle a convertCRLF flag
Product: Ant
Version: 1.5.3
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Normal
Priority: Other
Component: Optional Tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
The stcheckout optional task should be able to checkout files without messing
with the eol characters.
When you use this task to checkout Unix files onto an NT system, say, all of
the files are in DOS format. The fixcrlf task doesn't help me in this
situation because some of my files are in binary format.
I looked in the StarTeamCheckout class and in StarTeam's API and I think all
you have to do is something like ,...
add:
private boolean convertCRLF = true;
public void setConvertCRLF(boolean value) {
this.convertCRLF = value;
}
change line 533 (in 1.5.3 source) to:
!this.useRepositoryTimeStamp, this.convertCRLF, true);
