[GitHub] ant pull request #29: detect solaris 10 to avoid certain POSIX expressions

[jwadamson]

GitHub user jwadamson opened a pull request:

https://github.com/apache/ant/pull/29

detect solaris 10 to avoid certain POSIX expressions

Another attempt at fixing for solaris without regressing POSIX platforms.

1) use `uname` to detect solaris 10 platform.  Could not figure out a way 
via feature-detection to make change specific to the heirloom-sh found on it. 
Can be overridden via env PROTECT_NL=true|false.
2) esc_arg sed line is now done with `` instead of $(), due to heirloom 
compatibility.
3) ant_exec_debug final printing should have used printf instead of echo 
for accuracy of output
4) padding protection only was needed on the end of the processing argument 
and only for non-heirloom.


I tested with arguments for empty-string and the 6 most special characters 
(dollar, double-quote, backtick, singlequote, backslash, newline):

--execdebug -version '' '$' '"' '`' "'" '\\' '
'

Worked on ubuntu 14.04, and with Solaris 10 with the caviat newlines get 
trimmed from arguments on Solaris 10 e.g. the newline-only argument was 
translated into an empty-string.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwadamson/ant-1 1.9.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #29


commit 2b2e4b8bc4038cbdd1a01451d1fdd5fee1edd262
Author: Jeffrey Adamson 
Date:   2017-01-13T16:16:45Z

detect solaris 10 to avoid certain POSIX expressions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: Thoughts on Next Release

[jhm]

Yep.

Jan

> -Ursprüngliche Nachricht-
> Von: Maarten Coene [mailto:maarten_co...@yahoo.com.INVALID]
> Gesendet: Freitag, 13. Januar 2017 13:42
> An: Ant Developers List
> Betreff: Re: Thoughts on Next Release
> 
> Agreed.
> Maarten
> 
> 
>   Van: Stefan Bodewig 
>  Aan: dev@ant.apache.org
>  Verzonden: vrijdag 13 januari 13:19 2017
>  Onderwerp: Thoughts on Next Release
> 
> Hi all,
> 
> it looks as if the wrapper script still didn't work on Solaris 10 and
> also I seem to have broken Eclipse integration. The later has already
> been fixed in git, and we seem to be getting closer to fixing the
> former.
> 
> IMHO we should cut new releases once both have been fixed.
> 
> Thoughts?
> 
> Stefan
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Thoughts on Next Release

[Maarten Coene]

Agreed.
Maarten


  Van: Stefan Bodewig 
 Aan: dev@ant.apache.org 
 Verzonden: vrijdag 13 januari 13:19 2017
 Onderwerp: Thoughts on Next Release
   
Hi all,

it looks as if the wrapper script still didn't work on Solaris 10 and
also I seem to have broken Eclipse integration. The later has already
been fixed in git, and we seem to be getting closer to fixing the
former.

IMHO we should cut new releases once both have been fixed.

Thoughts?

        Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



   

Thoughts on Next Release

[Stefan Bodewig]

Hi all,

it looks as if the wrapper script still didn't work on Solaris 10 and
also I seem to have broken Eclipse integration. The later has already
been fixed in git, and we seem to be getting closer to fixing the
former.

IMHO we should cut new releases once both have been fixed.

Thoughts?

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org