Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Gintautas Grigelionis
2017-07-01 18:56 GMT+02:00 Nicolas Lalevée : > > > Le 1 juil. 2017 à 15:27, Gintautas Grigelionis > a écrit : > > > >> Probably a thing to improve are all the « since 2.x » annotations. Maybe > > we can have a macro for that, which will render

[GitHub] ant-ivyde pull request #:

2017-07-01 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivyde/commit/b048846233286ed9bb1ae7fbeab9ab3f58983189#commitcomment-22871013 Isn't Eclipse Oxygen Java 8 only? --- If your project is set up for it, you can reply to this email and have your reply appear

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Nicolas Lalevée
> Le 1 juil. 2017 à 15:27, Gintautas Grigelionis a > écrit : > >> Probably a thing to improve are all the « since 2.x » annotations. Maybe > we can have a macro for that, which will render everywhere the same, and > which will be placed everywhere the same. Now

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Nicolas Lalevée
> Le 1 juil. 2017 à 15:31, Jaikiran Pai a écrit : > > > On 29-Jun-2017, at 11:29 AM, Jaikiran Pai wrote: > > >> I’m picking up “OSGi” section next. > > I have completed and pushed the migration of “OSGi” and “Using standalone” > sections

[GitHub] ant-ivy issue #48: Generics and Java 7 syntax in osgi and plugins packages

2017-07-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/48 >> https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox Thanks - the JLS sections[1][2] mentioned in there answers my

Re: [GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread Gintautas Grigelionis
I believe stackoverflow has an answer [1] Gintas [1] https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox 2017-07-01 15:56 GMT+02:00 jaikiran : > Github user jaikiran commented on a diff in the pull

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125162592 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Jaikiran Pai
On 29-Jun-2017, at 11:29 AM, Jaikiran Pai wrote: > I’m picking up “OSGi” section next. I have completed and pushed the migration of “OSGi” and “Using standalone” sections to upstream (it’s actually live on site since yesterday). For the OSGi pages, I had to reword

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Gintautas Grigelionis
> Probably a thing to improve are all the « since 2.x » annotations. Maybe we can have a macro for that, which will render everywhere the same, and which will be placed everywhere the same. Now sometimes it is at the beginning of the line, sometimes at the end, sometimes above. And I find it being

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Gintautas Grigelionis
Thank you. PR 49 and 50 became one big spaghetti as I tried to catch up with your work and learn the ropes :-) Now, 49 is closed and 50 is squashed. Cheers, Gintas 2017-07-01 14:07 GMT+02:00 Nicolas Lalevée : > Thank you very much Gintas. > > These PRs are huge, so

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Jaikiran Pai
On 30-Jun-2017, at 9:48 PM, Nicolas Lalevée wrote: > I have seen that you have qualified the source blocks, telling it is xml. > Then I have done the same for the 'Ivy File' and 'Ant Tasks’ sections. And I > enabled the highlightjs integration with acsiidoctor. I

[GitHub] ant-ivy issue #49: Aesthetic changes in .gitignore, build.xml and build-rele...

2017-07-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/49 This is a part of #50 now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...

2017-07-01 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Jaikiran Pai
FWIW - I just finished reviewing PR-48 (the generics changes) https://github.com/apache/ant-ivy/pull/48/. Took me around an hour, the changes look fine :) I just have one comment/question about one of the change in that PR (I have to read up the Java spec or find some necessary documentation

Re: IVYDE-382 proposed patch

2017-07-01 Thread Nicolas Lalevée
Hi Alexander, Yes, it would be really nice if you could create a page documenting the new feature. I have just migrated the documentation of IvyDE to asciidoc, so it will be easier to contribute. I have also squashed and rebased your work on this branch:

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Nicolas Lalevée
Thank you very much Gintas. These PRs are huge, so they will take a little bit of time to process. Also, in the PR 49 and 50 I can see a lot of commits [1] [2]. For a cleaner git history, could you rebase and squash them ? I don’t require to have one commit, for instance having the two commits

Re: IVYDE-382 proposed patch

2017-07-01 Thread alexander . blaas
Good afternoon, sorry for the delay in my reply. The last two weeks I was very busy with exams and work. We are glad that our proposed patch found its way back to the main development path and that perhaps it will be a part of a following release :-) Is there a way we can support you?

Re: Ivy - we have now moved to asciidoc for docs

2017-07-01 Thread Gintautas Grigelionis
I opened a PR (well, actually two :-() to fix spelling and links that still point to configuration. Gintas 2017-06-30 18:44 GMT+02:00 Gintautas Grigelionis : > terminology.adoc apparently has an incorrect link on line 150, > configuration/statuses.html should be