Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Gintautas Grigelionis 
Ivy should be used standalone, so I'd rather implement Jaikiran's
suggestion.
Any comments about moving a public method TestHelper.getCurrentAuthenticator()
over to IvyAuthenticator()?

Gintas

2018-02-05 6:12 GMT+01:00 Stefan Bodewig :

> On 2018-02-05, Jaikiran Pai wrote:
>
> > On 02/02/18 11:49 PM, gin...@apache.org wrote:
> >> Repository: ant-ivy
> >> Updated Branches:
> >>refs/heads/master 1d3567f30 -> 7ebc8107a
>
>
> >> IVY-1569 Avoid reflection warnings (or worse) in Java 9+
>
>
> >>>private static int getJavaVersion() {
> >>>// See https://docs.oracle.com/javase/8/docs/technotes/
> guides/versioning/spec/versioning2.html#wp90002
> >>>final String[] version = System.getProperty("java.
> version").split("\\.");
> >>>final int major = Integer.parseInt(version[0]);
> >>>return major == 1 ? Integer.parseInt(version[1]) : major;
> >>>}
> >>   }
>
> > I think we should use java.specification.version system property
> > instead which is the recommended one as per the JEP
> > http://openjdk.java.net/jeps/223. We use this property in Ant too to
> > determine the Java version.
>
> Or org.apache.tools.ant.util.JavaEnvUtils#getParsedJavaVersion
>
> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Stefan Bodewig 
On 2018-02-05, Jaikiran Pai wrote:

> On 02/02/18 11:49 PM, gin...@apache.org wrote:
>> Repository: ant-ivy
>> Updated Branches:
>>refs/heads/master 1d3567f30 -> 7ebc8107a


>> IVY-1569 Avoid reflection warnings (or worse) in Java 9+


>>>private static int getJavaVersion() {
>>>// See 
>>> https://docs.oracle.com/javase/8/docs/technotes/guides/versioning/spec/versioning2.html#wp90002
>>>final String[] version = 
>>> System.getProperty("java.version").split("\\.");
>>>final int major = Integer.parseInt(version[0]);
>>>return major == 1 ? Integer.parseInt(version[1]) : major;
>>>}
>>   }

> I think we should use java.specification.version system property
> instead which is the recommended one as per the JEP
> http://openjdk.java.net/jeps/223. We use this property in Ant too to
> determine the Java version.

Or org.apache.tools.ant.util.JavaEnvUtils#getParsedJavaVersion

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-04 Thread Jaikiran Pai 

+1.

- Downloaded the binary .tar.gz. Installed it and checked the 
directories/files


- Setup the ANT_HOME to point to this and ran existing projects using 
this version. All went fine.


- Basic checks on the manuals, WHATSNEW and other files. All look good.

- Downloaded the source .tar.gz. Checked the presence of source files.

All above tests done on Java 8 setup.

-Jaikiran


On 03/02/18 10:02 PM, Stefan Bodewig wrote:

Hi all

I've created a release candidate for 1.9.10:

git tag: ANT_1_9_10_RC1
  on commit: 528c94e
tarballs: https://dist.apache.org/repos/dist/dev/ant/
   revision: 24666
Maven artifacts:
  
https://repository.apache.org/content/repositories/orgapacheant-1020/org/apache/ant/

This Vote will be open at least for 72 hours and close no earlier than
2018-02-06 16:30UTC.

Cheers

 Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Jaikiran Pai 



On 02/02/18 11:49 PM, gin...@apache.org wrote:

Repository: ant-ivy
Updated Branches:
   refs/heads/master 1d3567f30 -> 7ebc8107a


IVY-1569 Avoid reflection warnings (or worse) in Java 9+


+private static int getJavaVersion() {
+// See 
https://docs.oracle.com/javase/8/docs/technotes/guides/versioning/spec/versioning2.html#wp90002
+final String[] version = 
System.getProperty("java.version").split("\\.");
+final int major = Integer.parseInt(version[0]);
+return major == 1 ? Integer.parseInt(version[1]) : major;
+}
  }

I think we should use java.specification.version system property instead 
which is the recommended one as per the JEP 
http://openjdk.java.net/jeps/223. We use this property in Ant too to 
determine the Java version.


-Jaikiran

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-04 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/57
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Windows/37/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-04 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/57
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/Ant%20Github-PR-Linux/31/



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-04 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/ant/pull/57
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #57: Make junitreport with Saxon

2018-02-04 Thread adamretter 
GitHub user adamretter opened a pull request:

https://github.com/apache/ant/pull/57

Make junitreport with Saxon

Previously the XSLT(s) used in `junitreport` were only compatible with 
Xalan 2. Whilst you could specify a different `TransformerFactory`, and that 
could be Saxon, it would fail as the XSL(s) use Xalan specific extensions.

This PR adds compatibility with Saxon, so that if you specify Saxon as the 
`TransformerFactory`, then pure XSLT2 stylesheets are used without any vendor 
extensions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/adamretter/ant junitreport-xsl-saxon

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit 3ceba3aaf66701aad8fc4a8ad685df4e6645a2c9
Author: Adam Retter 
Date:   2018-02-04T10:09:55Z

[bugfix] Allow Saxon to be used for junitreport XSL transformation




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Issues with Downloading Ant's dependencies

2018-02-04 Thread Stefan Bodewig 
On 2018-02-03, Gintautas Grigelionis wrote:

> My turn to say "sorry for being a PITA" ;-)
> I broke fetch.xml and JetBrains CI -- should have been more attentive to
> their builds.

I'm not sure anybody is looking at the JetBrains CI builds (I
don't). Don't worry, stuff happens.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org