[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/70 Thanks for bearing with me 😉please see the revised commit. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For addi

[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread supertick
Github user supertick commented on the issue: https://github.com/apache/ant-ivy/pull/70 I would make a default overload which took only a String[] arg to model **exactly** the Main.main input, but all the rest is perfect, including the better isCli boolean vs silly cli option

[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/70 @supertick if you're fine with this PR, please close #69. I will merge this one later. --- - To unsubscribe, e-mail: dev-unsubscr.

Re: Snapshot access to regular users of Ant

2018-03-20 Thread Gintautas Grigelionis
2018-03-20 18:03 GMT+01:00 Stefan Bodewig : > On 2018-03-19, Gintautas Grigelionis wrote: > > > Maybe Ant Task Guidelines could be exposed under under "Contributing" > > as a landing page, and the relevant information could be moved into > > the manual? > > The tutorials as well as the Ant task gu

Re: Snapshot access to regular users of Ant

2018-03-20 Thread Stefan Bodewig
On 2018-03-19, Gintautas Grigelionis wrote: > Maybe Ant Task Guidelines could be exposed under under "Contributing" > as a landing page, and the relevant information could be moved into > the manual? The tutorials as well as the Ant task guidelines have always been only attachments to the manual

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Gintautas Grigelionis
2018-03-20 16:43 GMT+01:00 Stefan Bodewig : > On 2018-03-20, Gintautas Grigelionis wrote: > > > My understanding is that junitlauncher has a dependency on JUnit 4 > through > > vintage engine. I guess pom should provide profiles for engine choice. > See > > my earlier questions re the task classpa

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Jaikiran Pai wrote: > This looks like some odd merge or squashing issue when I pushed that > task changes. I have fixed it. The task itself doesn't need any JUnit > test engine specific dependencies like this one. I just pushed the > commit upstream which should fix this. Looks goo

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Jaikiran Pai
Hi Stefan, This looks like some odd merge or squashing issue when I pushed that task changes. I have fixed it. The task itself doesn't need any JUnit test engine specific dependencies like this one. I just pushed the commit upstream which should fix this. P.S: I haven't responded to some oth

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Gintautas Grigelionis wrote: > My understanding is that junitlauncher has a dependency on JUnit 4 through > vintage engine. I guess pom should provide profiles for engine choice. See > my earlier questions re the task classpath. Only when running the tests. The launcher task itself

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Gintautas Grigelionis
My understanding is that junitlauncher has a dependency on JUnit 4 through vintage engine. I guess pom should provide profiles for engine choice. See my earlier questions re the task classpath. Gintas Den tis 20 mars 2018 16:28Stefan Bodewig skrev: > Hi > > I've just added a POM for ant-junitla

junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has a dependency on org.junit.Test and I haven't declared any dependency on JUnit4 inside the POM (only transitively with scope test). The class h

Re: signjar-test failures in Jenkins

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Stefan Bodewig wrote: > it looks as if I had broken every single Jenkins build. Of course the > test pass on my machine with all JDKs I've got installed. No, it fails on Java10 for me, because jarsigner -verify now dies for a self-signed certificate. I'll try to figure out when thi

signjar-test failures in Jenkins

2018-03-20 Thread Stefan Bodewig
Hi all it looks as if I had broken every single Jenkins build. Of course the test pass on my machine with all JDKs I've got installed. Can anybody who gets test errors in his/her local environment please run ./build.sh -f src/tests/antunit/taskdefs/signjar-test.xml testVerifyJarStrictPKCS12 -v

[GitHub] ant-ivy issue #70: IVY-1321 Make Main.run() public

2018-03-20 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/70 I'm a bit surprised that StackOverflow does not refer to Apache [Confluence](https://cwiki.apache.org/confluence/display/IVY/Programmatic+use+of+Ivy) ---