Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-14 Thread Stefan Bodewig 
On 2018-04-12, Nicolas Lalevée wrote:

> I have built a release candidate for Ivy 2.5.0-rc1.

> The git tag of this release is: 
> https://git-wip-us.apache.org/repos/asf?p=ant-ivy.git;a=tag;h=refs/tags/2.5.0-rc1
>  
> 
>  with the sha1 887fd46f3e90016e313f7724ca259b936d30a03e

> The artifacts has been published to: 
> https://dist.apache.org/repos/dist/dev/ant/ivy/2.5.0-rc1 
>  at revision 26310

As usual I haven't tested anything, just looked at the legal stuff,
i.e. NOTICE and LICENSE are where they should be an look OK, checksums
are fine, tag and source archive match and RAT is reasonably happy.

> Do you vote for the release of these binaries?

+1

If you want to call them 2.5.0-rc1. If you want the release to be 2.5.0
then the names of the archives and the jars are all wrong and you'll
have to rebuild everything (and call for another vote).

It would be good if you could sign the tag as well.

A minor nit, the .gitignore and .gitattributes files are mssing from the
source archives. I don't consider this important but it would be nice if
this could be fixed after the release.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant git commit: More isEmpty()

2018-04-14 Thread Stefan Bodewig 
On 2018-04-13, Jaikiran Pai wrote:

> I think we could probably document that passing null to such attribute
> setters will lead to NullPointerException, which most likely will be
> the case in a lot of places other than those that just set the
> incoming value to some member variable.

Agreed. In that case the change as such is fine.

Any idea where to put documentation like this?

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-14 Thread Stefan Bodewig 
On 2018-04-13, Gintautas Grigelionis wrote:

> 2018-04-13 5:33 GMT+00:00 Stefan Bodewig :

>> Ant test cases are not designed to be run from an IDE, this has never
>> been a goal. I'm surprised this system property is the only thing you
>> need to remember :-)

>  Well, I decided to give it a spin :-) I find it useful to run
> debugger on test cases from IDE.

I'm glad it works for you.

Please don't break different approaches of doing things just to make the
IDE use case easier, though. In particular please don't remove the root
system property and please run all tests via the build file before
pushing changes.

Thanks

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org