Re: [GitHub] ant pull request #:

2018-05-12 Thread Jaikiran Pai
I did plan to addit yesterday, but my local tests did not trigger the package-info constant pool entry for some reason. So I decided to not rush it in and spend some time to get the test right, to make sure it works fine. I'll add it in either tonight or tomorrow once I get to see what's going

[GitHub] ant pull request #:

2018-05-12 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java: In

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
On 12/05/18 8:29 PM, Simon IJskes wrote: I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Simon IJskes
I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact should be available here[2]. [1]

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
I went ahead and pushed a commit[1] to fix this. We have our nightly Jenkins job which generates a nightly build. So if you would like to test it, you can pick up a distribution which contains this commit, whenever the next job runs. The artifact should be available here[2]. [1]

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon

ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Simon IJskes
Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands,