AW: [Bug 33169] KIndly update the date feature

2018-06-28 Thread jhm
Thanks, will have a look tomorrow. Sounds like we should keep BZ as it is. Jan > -Ursprüngliche Nachricht- > Von: Stefan Bodewig [mailto:bode...@apache.org] > Gesendet: Donnerstag, 28. Juni 2018 13:27 > An: dev@ant.apache.org > Betreff: Re: [Bug 33169] KIndly update the date feature > >

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Stefan Bodewig
On 2018-06-28, Jaikiran Pai wrote: > On 28/06/18 8:37 PM, Stefan Bodewig wrote: >> /dir >>/dir2 >>/dir3 >> link -> /dir/dir2 >> isLeadingPath("/dir/dir3", "/dir/dir3/link") returns true which it would >> not do if links have been resolved. > That's a good example and yes it would

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Jaikiran Pai
On 28/06/18 8:37 PM, Stefan Bodewig wrote: On 2018-06-28, Jaikiran Pai wrote: However, looking at the FileUtils#isLeadingPath(...) implementation, I wonder why it even uses normalize. Given that the goal of that API (as stated in the javadoc) is to figure out if one path leads the other, to m

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Stefan Bodewig
On 2018-06-28, Jaikiran Pai wrote: > However, looking at the FileUtils#isLeadingPath(...) implementation, I > wonder why it even uses normalize. Given that the goal of that API (as > stated in the javadoc) is to figure out if one path leads the other, > to me that translates to being a check to se

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Jaikiran Pai
I don't have enough background on the expectations of the normalize method, so can't really say how it should behave. Plus, it gets used in relatively larger number of places as compared to isLeadingPath, so not too sure how it might impact other places if we do change its existing semantics.

FileUtils.normalize/isLeadingPath have bitten me

2018-06-28 Thread Stefan Bodewig
Hi all while looking into https://bz.apache.org/bugzilla/show_bug.cgi?id=62502 I realized that I had a false expectation of what normalize would do in a certain edge case. If you feed into it a path with more "../" segments than can be travelled up, like FileUtils.normalize("/tmp/dest/../../../.

Re: [Bug 33169] KIndly update the date feature

2018-06-28 Thread Stefan Bodewig
On 2018-06-28, Stefan Bodewig wrote: > The ASF installations allow everybody to create accounts and everybody > to create new issues. This is a deliberate choice and is the same for > JIRA and Bugzilla - and is the best choice for an open source project > IMHO. > I'm not sure whether JIRA allows

Re: [Bug 33169] KIndly update the date feature

2018-06-28 Thread Stefan Bodewig
On 2018-06-28, Jan Matèrne (jhm) wrote: >>> Just curious about our bugzilla infrastructure - do random users get >>> to change the content of these bugs, even if they aren't the ones who >>> reported the issue? >> Yes. >> Back when Bugzilla was introduced the developers and admins falsely >> ass

Re: [Bug 33169] KIndly update the date feature

2018-06-28 Thread Gintautas Grigelionis
On Thu, 28 Jun 2018 at 11:43, Jan Matèrne (jhm) wrote: > > > Just curious about our bugzilla infrastructure - do random users get > > > to change the content of these bugs, even if they aren't the ones who > > > reported the issue? > > > > Yes. > > > > Back when Bugzilla was introduced the develo

AW: [Bug 33169] KIndly update the date feature

2018-06-28 Thread jhm
> > Just curious about our bugzilla infrastructure - do random users get > > to change the content of these bugs, even if they aren't the ones who > > reported the issue? > > Yes. > > Back when Bugzilla was introduced the developers and admins falsely > assumed only sensible people would be using