[GitHub] ant pull request #:

2018-07-03 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29586480 In manual/install.html: In manual/install.html on line 931: I'll change it tomorrow. ---

[GitHub] ant pull request #:

2018-07-03 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29585155 In manual/install.html: In manual/install.html on line 931: Sorry about nitpicking: I would prefer a space between Java and

Re: Jenkins-Builds failing

2018-07-03 Thread Gintautas Grigelionis
Ant nightly is stuck on archiving for 30 hours now. It should be escalated, I believe that could have something to do with the last upgrade of Jenkins. Gintas On Mon, 2 Jul 2018 at 14:18, Jan Matèrne wrote: > Several of our Jenkins builds are failing: > > > > IvyDE: > >

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-03 Thread Stefan Bodewig
On 2018-07-03, Jaikiran Pai wrote: > I did some testing manually for this new method, with both symlinks > and non-symlinks with both the string check version and the > getParent() version. In both of those, I couldn't get it to break in > any odd ways (which is a good thing). It also means that

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-03 Thread Jaikiran Pai
Hi Stefan, I did some testing manually for this new method, with both symlinks and non-symlinks with both the string check version and the getParent() version. In both of those, I couldn't get it to break in any odd ways (which is a good thing). It also means that my theory that the string

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/54 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/65/ ---

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

2018-07-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/54 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/59/ ---

Re: ant task mail fails on jdk10

2018-07-03 Thread Stefan Bodewig
On 2018-07-03, Jan Matèrne (jhm) wrote: > We already have something: > mail: "This task may depend on external libraries that are not included in > the Ant distribution. See Library Dependencies for more information." > dependencies: > "mail.jar Mail task with Mime encoding, and the MimeMail

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-03 Thread Stefan Bodewig
On 2018-07-02, Stefan Bodewig wrote: > On 2018-07-02, Jaikiran Pai wrote: >> I just checked the commits related to this and it looks mostly >> correct. However, I am still not 100% sure we have covered it all with >> this new method that was introduced[1] and used in the unzip >> part. What I

Re: ant task mail fails on jdk10

2018-07-03 Thread Gintautas Grigelionis
libraries.properties for Ant 1.10.x specify javax.mail 1.6.1 which pulls in activation 1.1 Gintas On Tue, 3 Jul 2018 at 08:19, Jan Matèrne (jhm) wrote: > Did my own test: > > password="${mail.pwd}" from="${from}" subject="Testemail"> > > > Ant-Version:

AW: ant task mail fails on jdk10

2018-07-03 Thread jhm
Did my own test: Ant-Version: ${ant.version} Java-Version: ${java.version} Running with Java8 + Java10, and I got my two mails: Ant-Version: Apache Ant(TM) version 1.10.1 compiled on February 2 2017