[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/64 Thank you @jnsnkrllive. This now looks fine to me. I'll merge this later tonight/tomorrow, once our currently in-progress Ant release(s) are officially announced. ---

[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/64 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/71/ ---

[GitHub] ant issue #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/64 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/65/ ---

[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread jnsnkrllive
Github user jnsnkrllive commented on a diff in the pull request: https://github.com/apache/ant/pull/64#discussion_r202364682 --- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java --- @@ -413,6 +429,16 @@ public void execute() throws BuildException {

[RESULT] Release Ant 1.9.13 based on RC1

2018-07-13 Thread Stefan Bodewig
Hi all with +1s by Jaikiran Pai Maarten Coene Nicolas Lalevée Stefan Bodewig (implicit) and no other votes the vote has passed. I'll start the usual publish, wait for mirrors, announce cycle now. Thanks to everybody who voted Stefan

[RESULT] Release Ant 1.10.5 based on RC1

2018-07-13 Thread Stefan Bodewig
Hi all with +1s by Jaikiran Pai Maarten Coene Paul King (not binding but much appreciated) Nicolas Lalevée Stefan Bodewig (implicit) and no other votes the vote has passed. I'll start the usual publish, wait for mirrors, announce cycle now. Thanks to everybody who voted Stefan

[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task

2018-07-13 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/64#discussion_r202287386 --- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java --- @@ -413,6 +429,16 @@ public void execute() throws BuildException {