Re: [PROPOSAL] ant-junitlauncher watchdog customization
Hello Aleksei, That looks fine to me. I've merged it to our master branch. I've added your github profile name (Alex) to our contributors list. If you want to use a different name to be added, please let us know, I'll update accordingly. -Jaikiran On 30/04/21 2:06 pm, Aleksei Zotov wrote: Hi all, I've raised https://github.com/apache/ant/pull/147 PR for having an ability to customize a watchdog created for test execution. The PR description has all the details explained. Could you, please, have a look and let me know what you think. Thanks, Aleksei Zotov. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] asfgit closed pull request #147: Make Watchdog for JUnitLauncherTask customizable.
asfgit closed pull request #147: URL: https://github.com/apache/ant/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PROPOSAL] ant-junitlauncher watchdog customization
Hi all, I've raised https://github.com/apache/ant/pull/147 PR for having an ability to customize a watchdog created for test execution. The PR description has all the details explained. Could you, please, have a look and let me know what you think. Thanks, Aleksei Zotov.
[GitHub] [ant] ddevienne commented on pull request #147: Make Watchdog for JUnitLauncherTask customizable.
ddevienne commented on pull request #147: URL: https://github.com/apache/ant/pull/147#issuecomment-829961147 Looks perfectly reasonable to me, FWIW. +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] alex-ninja opened a new pull request #147: Make Watchdog for JUnitLauncherTask customizable.
alex-ninja opened a new pull request #147: URL: https://github.com/apache/ant/pull/147 ### Context Currently I'm working on migration of Cassandra to JUnit5 (https://issues.apache.org/jira/browse/CASSANDRA-16630). There is a nice customization that is used there: before terminating a test by timeout, we get all stack traces via `jstack` command. It is very useful for troubleshooting purposes. You can check the reference implementation for JUnit4: https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/JStackJUnitTask.java. Unfortunately it is impossible to do the same customization for `JUnitLauncherTask` (unlikely to `JUnitTask`) because everything is hidden (private) now. We want to have a way to easily extend `Watchdog` created for a task/test monitoring. ### Summary of the changes 1. Moved Watchdog creation into a separate method 2. Made the method protected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
