[GitHub] [ant] arturobernalg opened a new pull request #164: Use inner class as static.
arturobernalg opened a new pull request #164: URL: https://github.com/apache/ant/pull/164 Its not require access to an enclosing instance's non-public fields and methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg opened a new pull request #162: Use Bulk operation instead of iteration.
arturobernalg opened a new pull request #162: URL: https://github.com/apache/ant/pull/162 Some operations inside loops that could be replaced with a bulk method. Bulk methods are shorter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
Hi. On Sat, Oct 2, 2021 at 2:28 PM Jaikiran Pai wrote: > +1 > > - Downloaded the .tar.gz binary > Please not that the ASF nor its projects release Binaries. (They are provided to users as a convenience) We also do not vote on releases based on Binaries. The vote should be based on whether or not the 'source' - that is being released is good enough. Gav... > - Checked the NOTICE file and some random manuals > > - Built internal projects using Java 8 and this version of Ant > > - Built some sample projects with Java 17 and this version Ant > > All looks fine. > > -Jaikiran > > On 30/09/21 8:28 am, Jaikiran Pai wrote: > > I've created a release candidate for 1.10.12: > > > > git tag: ANT_1.10.12_RC1 > > on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 > > tarballs: https://dist.apache.org/repos/dist/dev/ant/ > > revision: 50166 > > Maven artifacts: > > https://repository.apache.org/content/repositories/orgapacheant-1051/ > > Snapcraft Build > > Revision 21 in latest/candidate > > > > This release is mainly a bug fix release and the exact changes are > > noted in > > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. > > Of particular interest is the relatively minor bug fix in the javadoc > > task which is necessary for it to work properly in the recently > > released Java 17 version. > > > > This vote will be open at least for 72 hours and close no earlier than > > 4th October 2021 03:00 AM UTC (given that it's a weekend in the next > > couple of days, I decided to extend the voting period till Monday) > > > > > > -Jaikiran > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > > -- *Gavin McDonald* Systems Administrator ASF Infrastructure Team
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
+1 - Downloaded the .tar.gz binary - Checked the NOTICE file and some random manuals - Built internal projects using Java 8 and this version of Ant - Built some sample projects with Java 17 and this version Ant All looks fine. -Jaikiran On 30/09/21 8:28 am, Jaikiran Pai wrote: I've created a release candidate for 1.10.12: git tag: ANT_1.10.12_RC1 on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 50166 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1051/ Snapcraft Build Revision 21 in latest/candidate This release is mainly a bug fix release and the exact changes are noted in https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of particular interest is the relatively minor bug fix in the javadoc task which is necessary for it to work properly in the recently released Java 17 version. This vote will be open at least for 72 hours and close no earlier than 4th October 2021 03:00 AM UTC (given that it's a weekend in the next couple of days, I decided to extend the voting period till Monday) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] twogee opened a new pull request #161: Use Jakarta EE
twogee opened a new pull request #161: URL: https://github.com/apache/ant/pull/161 Java Mail became Jakarta Mail, and Ant should prepare for EOL of the former. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] twogee commented on pull request #138: Update the optional dependencies
twogee commented on pull request #138: URL: https://github.com/apache/ant/pull/138#issuecomment-932738776 Thanks, @bodewig, and sorry about missing the extraneous changes. I will open a new PR for changes re Jakarta Mail specifically. The change to `ClasspathUtils` is related to an attempt to avoid nested `try` in `EmailTask#getMailerImplementation()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #138: Update the optional dependencies
bodewig commented on pull request #138: URL: https://github.com/apache/ant/pull/138#issuecomment-932727849 Thank you @twogee - do you think you could split the Jakarta Mailer support changes from the other changes? The changes to `ClasspathUtils` seem to be completely unrelated to either and the chunk that removes string concatenation is completely unnecessary anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
