[GitHub] [ant] arturobernalg commented on pull request #162: Use Bulk operation instead of iteration.
arturobernalg commented on pull request #162: URL: https://github.com/apache/ant/pull/162#issuecomment-932936163 > thank you @arturobernalg Currently there is a release vote underway and I don't want to disturb things by changing `master` before it is done. Completely agree. This is a minor change. can wait. Thank you @bodewig -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #164: Use inner class as static.
bodewig commented on pull request #164: URL: https://github.com/apache/ant/pull/164#issuecomment-932935464 for historical reasons Ant is not following semantic versioning, so the next "major release" would be 1.11.0. Having said that I'm not aware of anybody planning to create such a thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #162: Use Bulk operation instead of iteration.
bodewig commented on pull request #162: URL: https://github.com/apache/ant/pull/162#issuecomment-932934965 thank you @arturobernalg Currently there is a release vote underway and I don't want to disturb things by changing `master` before it is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #163: Make final var when is possible.
bodewig commented on pull request #163: URL: https://github.com/apache/ant/pull/163#issuecomment-932934721 @arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg commented on pull request #164: Use inner class as static.
arturobernalg commented on pull request #164: URL: https://github.com/apache/ant/pull/164#issuecomment-932934366 > Thank you @arturobernalg but I'm afraid this is a change that is not backwards compatible at all so we cannot accept it. HI @bodewig Ok, close the PR. maybe for a new. mayor release. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg closed pull request #164: Use inner class as static.
arturobernalg closed pull request #164: URL: https://github.com/apache/ant/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg commented on a change in pull request #162: Use Bulk operation instead of iteration.
arturobernalg commented on a change in pull request #162:
URL: https://github.com/apache/ant/pull/162#discussion_r720815321
##
File path: src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
##
@@ -294,7 +294,7 @@ public void send() {
? new InternetAddress(addr.getAddress())
: new InternetAddress(addr.getAddress(), name));
}
-return addrs.toArray(new InternetAddress[addrs.size()]);
+return addrs.toArray(new InternetAddress[0]);
Review comment:
Hi @bodewig
Reverted.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg closed pull request #163: Make final var when is possible.
arturobernalg closed pull request #163: URL: https://github.com/apache/ant/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg commented on pull request #163: Make final var when is possible.
arturobernalg commented on pull request #163: URL: https://github.com/apache/ant/pull/163#issuecomment-932933258 > This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle. > > Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV. HI @bodewig I close the PR TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #161: Use Jakarta EE
bodewig commented on pull request #161: URL: https://github.com/apache/ant/pull/161#issuecomment-932931398 There might be a way to reduce the code duplication between the two mailer classes, but that can be done as a refactoring later. Also we'll need a new POM and a new artifact to publish. I'll look into this after 1.10.12 is out. The change to ClasspathUtils looks good, thank you, but is not really related to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #163: Make final var when is possible.
bodewig commented on pull request #163: URL: https://github.com/apache/ant/pull/163#issuecomment-932930381 This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle. Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on a change in pull request #163: Make final var when is possible.
bodewig commented on a change in pull request #163:
URL: https://github.com/apache/ant/pull/163#discussion_r720811997
##
File path: src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java
##
@@ -381,7 +381,7 @@ protected void setCommonOptions(final ExecTask cmd) {
* @throws BuildException if the property is not correctly defined.
*/
protected void declareSysProperty(
-ExecTask cmd, Environment.Variable property) throws BuildException {
+final ExecTask cmd, final Environment.Variable property) throws
BuildException {
Review comment:
why did you change indentation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on a change in pull request #162: Use Bulk operation instead of iteration.
bodewig commented on a change in pull request #162:
URL: https://github.com/apache/ant/pull/162#discussion_r720811564
##
File path: src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
##
@@ -294,7 +294,7 @@ public void send() {
? new InternetAddress(addr.getAddress())
: new InternetAddress(addr.getAddress(), name));
}
-return addrs.toArray(new InternetAddress[addrs.size()]);
+return addrs.toArray(new InternetAddress[0]);
Review comment:
seems to belong to a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #164: Use inner class as static.
bodewig commented on pull request #164: URL: https://github.com/apache/ant/pull/164#issuecomment-932924639 Thank you @arturobernalg but I'm afraid this is a change that is not backwards compatible at all so we cannot accept it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on a change in pull request #164: Use inner class as static.
bodewig commented on a change in pull request #164:
URL: https://github.com/apache/ant/pull/164#discussion_r720811236
##
File path: src/main/org/apache/tools/ant/taskdefs/Javac.java
##
@@ -910,7 +910,7 @@ public boolean getNowarn() {
*/
public ImplementationSpecificArgument createCompilerArg() {
final ImplementationSpecificArgument arg =
-new ImplementationSpecificArgument();
+new ImplementationSpecificArgument();
Review comment:
please don't change whitespace in existing code.
##
File path: src/main/org/apache/tools/ant/taskdefs/Input.java
##
@@ -44,7 +44,7 @@
/**
* Represents an InputHandler.
*/
-public class Handler extends DefBase {
+public static class Handler extends DefBase {
Review comment:
this change is not backwards compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
On 2021-09-30, Jaikiran Pai wrote: > This release is mainly a bug fix release and the exact changes are > noted in > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of > particular interest is the relatively minor bug fix in the javadoc > task which is necessary for it to work properly in the recently > released Java 17 version. +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Bug report for Ant [2021/10/03]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 5003|Opn|Blk|2001-11-21|exec task does not return after executed command f| | 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders| | 7552|Opn|Cri|2002-03-28|Invalid task cache in targets | | 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task? | | 8294|New|Enh|2002-04-19|: Allow and to app| | 8866|New|Enh|2002-05-07|Signal handling in java task | | 8895|New|Enh|2002-05-08|ant and/or antcall should support forking | | 8972|New|Enh|2002-05-10|allow property expansion in property v| | 8981|New|Enh|2002-05-10|Tar task command additional features | | 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support | | 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks| |10020|New|Enh|2002-06-19|'s dependency behaviour should be more con| |10231|New|Enh|2002-06-25|Need access to current file in SQLExec| |10283|New|Enh|2002-06-27|Add a destfile to the uptodate task | |10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv| |3|New|Enh|2002-07-24|keytool task | |11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta| |12267|New|Enh|2002-09-03|Add ability to unzip into separate folders| |12292|New|Enh|2002-09-04|[PATCH] enable tag inside tar| |12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu| |12518|New|Enh|2002-09-11|Gunzip & BUnZip2 add filesets, patternsets, and ov| |12765|New|Enh|2002-09-18|"rmdir" and "deltree" patches for ftp task enhance| |12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time | |13047|Inf|Enh|2002-09-26|Support for and on O| |13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task| |13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh| |13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope| |13939|New|Enh|2002-10-24|Translate task should have better key matching cap| |14320|New|Enh|2002-11-06|copy fileset followsymlinks="false" does not copy | |14393|New|Enh|2002-11-08|Support use of jndi within ant| |14512|New|Enh|2002-11-13|Allow creating database connection similar to with does not spot bad symlin| |15149|New|Enh|2002-12-06|Replace task | |15244|New|Enh|2002-12-10|tar task should be able to store symbolic links as| |15430|New|Enh|2002-12-17|Enhancement to ReplaceRegExp.java | |15596|New|Enh|2002-12-21|Identity mapper in uptodate task. | |15747|New|Enh|2003-01-01|change tasks (e.g. Ant) to take urls as well as fi| |15853|New|Enh|2003-01-07|Allow to plug-in different XML Catalog resolver in| |15949|Opn|Enh|2003-01-10|please provide links to docs.xml and jakarta-site2| |16131|New|Enh|2003-01-15|not possible to suppress "BUILD SUCCESSFUL" messag| |16427|New|Enh|2003-01-26|Output return value of setLastModified/document be| |16469|New|Enh|2003-01-27|Apply task should allow parallel execution on diff| |16562|New|Enh|2003-01-29|Can not accept characters from keyboard in a thre| |16860|New|Enh|2003-02-06|Silent or Debug a single target | |16896|New|Enh|2003-02-07|Support in ProjectHelper / ProjectHelperImpl to op| |17074|New|Enh|2003-02-14|Contribution for WLSTOP | |17181|New|Nor|2003-02-18|Build fails while trying to get VSS files by label| |17372|New|Enh|2003-02-25|Enhancement of replace Task | |17742|New|Maj|2003-03-06|PVCS task generates GET with promotion group incor| |17781|New|Enh|2003-03-07|name attribute of record task is not relative to b| |17829|New|Enh|2003-03-10|Allow ejbjar task to accept nested manifest | |17850|New|Nor|2003-03-10|PVCS task dont work with promotion group | |17961|New|Enh|2003-03-13|New task to collect services from a JAR
