[GitHub] [ant] arturobernalg commented on pull request #163: Make final var when is possible.
arturobernalg commented on pull request #163: URL: https://github.com/apache/ant/pull/163#issuecomment-934565487 > @arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way. HI @bodewig TY for the feedback. I'll reopen the PR. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
+0 (non-binding) I checked: * LICENSE & NOTICE seem okay * HASH & SIG seem okay * I ran against the Groovy test suite which has 100+ ant-related tests and all continue to pass (using JDK16 and the upcoming Groovy 4) I was surprised to see binary jars in the src archives under lib/optional. I don't know the history, so perhaps it is fine. Cheers, Paul. On Thu, Sep 30, 2021 at 12:58 PM Jaikiran Pai wrote: > I've created a release candidate for 1.10.12: > > git tag: ANT_1.10.12_RC1 > on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 > tarballs: https://dist.apache.org/repos/dist/dev/ant/ >revision: 50166 > Maven artifacts: > https://repository.apache.org/content/repositories/orgapacheant-1051/ > Snapcraft Build >Revision 21 in latest/candidate > > This release is mainly a bug fix release and the exact changes are noted > in > https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. > Of particular interest is the relatively minor bug fix in the javadoc > task which is necessary for it to work properly in the recently released > Java 17 version. > > This vote will be open at least for 72 hours and close no earlier than > 4th October 2021 03:00 AM UTC (given that it's a weekend in the next > couple of days, I decided to extend the voting period till Monday) > > > -Jaikiran > > > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
Re: [VOTE] Release Apache Ant 1.10.12 based on RC1
+1 Maarten Op donderdag 30 september 2021 04:58:56 CEST schreef Jaikiran Pai : I've created a release candidate for 1.10.12: git tag: ANT_1.10.12_RC1 on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 50166 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1051/ Snapcraft Build Revision 21 in latest/candidate This release is mainly a bug fix release and the exact changes are noted in https://dist.apache.org/repos/dist/dev/ant/RELEASE-NOTES-1.10.12.html. Of particular interest is the relatively minor bug fix in the javadoc task which is necessary for it to work properly in the recently released Java 17 version. This vote will be open at least for 72 hours and close no earlier than 4th October 2021 03:00 AM UTC (given that it's a weekend in the next couple of days, I decided to extend the voting period till Monday) -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
