[GitHub] [ant] jaikiran commented on pull request #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox


jaikiran commented on PR #195:
URL: https://github.com/apache/ant/pull/195#issuecomment-1318135936

   > I'll also check why my testing of my previous commit didn't catch the 1.8 
version issue
   
   For the record - one of the test jobs did catch this issue for 1.8 version, 
I just hadn't caught up with my email notifications for these failures.
   
   Thank you again for this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] jaikiran merged pull request #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox


jaikiran merged PR #195:
URL: https://github.com/apache/ant/pull/195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] jaikiran commented on pull request #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox


jaikiran commented on PR #195:
URL: https://github.com/apache/ant/pull/195#issuecomment-1317878895

   Thank you @keithc-ca for this change. I will run some CI test before merging 
(I'll also check why my testing of my previous commit didn't catch the 1.8 
version issue).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] [ant] keithc-ca opened a new pull request, #195: Fix detection of java.specification.version

2022-11-16 Thread GitBox


keithc-ca opened a new pull request, #195:
URL: https://github.com/apache/ant/pull/195

   The existing use of `tr` doesn't distinguish between Java 8 and Java 18; see 
https://github.com/apache/ant/commit/bbe6859b2f57a2c9dcb51e269527f3c18a74aa1d#commitcomment-90131350
 - this fixes that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Release Ant 1.10.13?

2022-11-16 Thread Jaikiran Pai

Hello everyone,

We last released Ant more than a year back. During that period we have 
had some good amount of bug fixes and changes that have gone in. Plus, 
Java 18 and beyond was released in the meantime where setting the 
security manager isn't allowed by default (Ant sets it). Users can still 
use the current released Ant version against these recent Java versions, 
but they additionally have to set a system property while launching Ant 
to allow setting the security manager. Ant's mainline code has changes 
where it does the necessary work (to the extent possible) to set this 
property internally without forcing the users to do that. So releasing 
this version of Ant should help projects building against these recent 
versions.


The way we detect Java versions within Ant's startup script isn't 
straightforward, especially for Windows. We had a brief discussion[1] 
about it in the past and I'll be focusing on this area to see if I can 
improve that situation in this coming week before the release.



[1] https://lists.apache.org/thread/53jo1sy8ly2645j68m7s2g2mb4f10dy5

-Jaikiran


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org