maartenc closed pull request #87:
URL: https://github.com/apache/ant-ivy/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@a
jaikiran commented on pull request #95:
URL: https://github.com/apache/ant-ivy/pull/95#issuecomment-977473905
Hello @maartenc, this looks good to me. One question - The `retrieve` also
has a `pathId` which creates a path out of the retrieved artifacts. Is that
affected by this issue too an
maartenc commented on pull request #95:
URL: https://github.com/apache/ant-ivy/pull/95#issuecomment-977820162
Thanks for the review @jaikiran, the path creation is ok (we use that as a
workaround for the moment), but just to be sure I've added some extra checks to
the junit test.
I'
jaikiran commented on pull request #95:
URL: https://github.com/apache/ant-ivy/pull/95#issuecomment-977880327
Thank you Maarten for the updated tests. They look fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
maartenc merged pull request #95:
URL: https://github.com/apache/ant-ivy/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@a
bodewig merged pull request #170:
URL: https://github.com/apache/ant/pull/170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig commented on pull request #170:
URL: https://github.com/apache/ant/pull/170#issuecomment-996053788
many thanks @sonyDeswal and sorry about the long delay
I've added documentation and a few cosmetic changes with 43214e433 - and
also enabled strict host name checking by default
bernolanger opened a new pull request #96:
URL: https://github.com/apache/ant-ivy/pull/96
The default accept header of Java isn't valid as described at
https://bugs.openjdk.java.net/browse/JDK-8163921
Therefore set an accept header that accepts simply anything in the
ivy:retriev
bernolanger opened a new pull request #173:
URL: https://github.com/apache/ant/pull/173
Most clients do not send the Authorization header on redirects by default;
because of security issues.
The ant:get task instead, always sends the Authorization header to the
redirected location.
azotcsit opened a new pull request #174:
URL: https://github.com/apache/ant/pull/174
### Context
I'm working on migration of Cassandra to JUnit5
(https://issues.apache.org/jira/browse/CASSANDRA-16630). Our test running code
is heavily customized and relies onto
[forkMode](https://githu
azotcsit commented on a change in pull request #169:
URL: https://github.com/apache/ant/pull/169#discussion_r773913282
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
##
@@ -43,7 +43,7 @@
/**
* Contains some comm
bodewig merged pull request #173:
URL: https://github.com/apache/ant/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig commented on pull request #173:
URL: https://github.com/apache/ant/pull/173#issuecomment-999741812
many thanks @bernolanger
we'd like to credit you in CONTRIBUTORS and contributors.xml. What is the
name you'd want us to use?
--
This is an automated message from the Apache
jaikiran commented on pull request #173:
URL: https://github.com/apache/ant/pull/173#issuecomment-129159
>Therefore I didn't change the default behavior to avoid breaking existing
Ant scripts. This means, "authenticateOnRedirect" defaults to "true". But maybe
it would be better to chan
jaikiran commented on pull request #96:
URL: https://github.com/apache/ant-ivy/pull/96#issuecomment-130597
This looks OK to me. However, it looks like this PR didn't trigger a CI run,
so I'll manually run our tests to make sure this doesn't break anything, before
merging this.
--
bodewig commented on pull request #173:
URL: https://github.com/apache/ant/pull/173#issuecomment-1000436715
you are right @jaikiran, I'll change the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
sonyDeswal commented on pull request #170:
URL: https://github.com/apache/ant/pull/170#issuecomment-1002418266
Thanks Stefan.
It works. Please use my Name as Santosh R. Dhariwal, if possible.
Regards,Santosh Dhariwal
On Thursday, December 16, 2021, 11:34:15 PM GMT+5:30, Stefan
bodewig commented on pull request #170:
URL: https://github.com/apache/ant/pull/170#issuecomment-1002523492
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
azotcsit commented on pull request #169:
URL: https://github.com/apache/ant/pull/169#issuecomment-1009962932
Closing as per the discussion on the dev mail list:
https://lists.apache.org/thread/2v8l95fwh0sgz0vlgqcf1rpd88swf3pv
--
This is an automated message from the Apache Git Service.
T
azotcsit closed pull request #169:
URL: https://github.com/apache/ant/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant
didiksupriadi41 opened a new pull request #97:
URL: https://github.com/apache/ant-ivy/pull/97
`com.jcraft#jsch.agentproxy` doesn't provides any jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jaikiran merged pull request #96:
URL: https://github.com/apache/ant-ivy/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@a
jaikiran commented on pull request #96:
URL: https://github.com/apache/ant-ivy/pull/96#issuecomment-1013608057
Thank you @bernolanger for this contribution. I've merged it. It looks like
this is your first contribution to this project. I will add "Berno Langer" to
the list of contributors,
tsmock opened a new pull request #175:
URL: https://github.com/apache/ant/pull/175
Bugzilla Report 65833
This occurs when the stacktrace message contains ]]>, which is the CDATA
end code. There is no escape, so it must be replaced with `]]` + `]]>` +
`
azotcsit commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r789921289
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,9 @@ private void writeFailed(fina
tsmock commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r790853748
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,9 @@ private void writeFailed(final
tsmock commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r790853748
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,9 @@ private void writeFailed(final
tsmock commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r790853748
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,9 @@ private void writeFailed(final
azotcsit commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r791701322
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,9 @@ private void writeFailed(fina
azotcsit commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r791701322
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,9 @@ private void writeFailed(fina
jaikiran commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r792306165
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,7 @@ private void writeFailed(fina
jaikiran commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1021851685
This PR looks fine to me. Thank you for fixing this. Given that we have had
odd issues in this area with XML content, do you think it's possible to add a
test case to reproduce this
tsmock commented on a change in pull request #175:
URL: https://github.com/apache/ant/pull/175#discussion_r792663467
##
File path:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LegacyXmlResultFormatter.java
##
@@ -298,8 +298,7 @@ private void writeFailed(final
tsmock commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-106543
> This PR looks fine to me. Thank you for fixing this. Given that we have
had odd issues in this area with XML content, do you think it's possible to add
a test case to reproduce this
tsmock edited a comment on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-106543
> This PR looks fine to me. Thank you for fixing this. Given that we have
had odd issues in this area with XML content, do you think it's possible to add
a test case to reprodu
azotcsit commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1022986551
@tsmock
I experienced the same problem and @jaikiran suggested to fetch necessary
dependencies by running `ant -f fetch.xml -Ddest=optional` [1]. It actually
helped me.
[
tsmock commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1023232685
> @tsmock I experienced the same problem and @jaikiran suggested to fetch
necessary dependencies by running `ant -f fetch.xml -Ddest=optional` [1]. It
actually helped me.
>
> [
bodewig closed pull request #176:
URL: https://github.com/apache/ant/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig commented on pull request #176:
URL: https://github.com/apache/ant/pull/176#issuecomment-1024893091
@mominmalik33 please find a different place to play. It is trivial to set up
your own repository at github instead of bothering "real" projects.
--
This is an automated message fro
bodewig closed pull request #177:
URL: https://github.com/apache/ant/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig closed pull request #179:
URL: https://github.com/apache/ant/pull/179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig closed pull request #178:
URL: https://github.com/apache/ant/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig closed pull request #183:
URL: https://github.com/apache/ant/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig closed pull request #182:
URL: https://github.com/apache/ant/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig closed pull request #180:
URL: https://github.com/apache/ant/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
bodewig closed pull request #181:
URL: https://github.com/apache/ant/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.
tsmock commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1033872016
Do I need to do anything else for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
asfgit closed pull request #175:
URL: https://github.com/apache/ant/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.a
jaikiran commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1034445095
Hello Taylor, I just merged the initial commit that is part of this PR. I
left out the tests for now since it even had changed some junit versions. I'll
look into the testing part s
tsmock commented on pull request #175:
URL: https://github.com/apache/ant/pull/175#issuecomment-1034936800
I ended up updating the JUnit5 versions to get some of their newer testing
methods for testing JUnit extensions. In any case, from what _I_ know, there
shouldn't be any effect on `ant
bodewig commented on PR #184:
URL: https://github.com/apache/ant/pull/184#issuecomment-1088251930
I'm not really sure what to make of this:
* please don't change the format of files. Either change whitespace or code
but not both. Otherwise the PR creates too much noise to tell the rea
chagmed opened a new pull request, #185:
URL: https://github.com/apache/ant/pull/185
Correct small typo in selectors.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
bodewig merged PR #185:
URL: https://github.com/apache/ant/pull/185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
bodewig commented on PR #185:
URL: https://github.com/apache/ant/pull/185#issuecomment-1094072471
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
zhanglei-1987 opened a new pull request, #98:
URL: https://github.com/apache/ant-ivy/pull/98
Allow customization ‘dataFilePattern’
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
mizdebsk opened a new pull request, #186:
URL: https://github.com/apache/ant/pull/186
Parsing SOURCE_DATE_EPOCH environment variable by Tstamp leads to integer
overflow and produces wrong result.
The following example illustrates that:
TODAY is ${TODAY}
This
jaikiran commented on PR #186:
URL: https://github.com/apache/ant/pull/186#issuecomment-1107119527
Hello @mizdebsk, thank you for contributing this fix.
Would you be interested in adding a test case for this change so that this
doesn't regress in future. We have an existing test class
mizdebsk commented on PR #186:
URL: https://github.com/apache/ant/pull/186#issuecomment-1107514169
Sure, I will add a test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
mizdebsk commented on PR #186:
URL: https://github.com/apache/ant/pull/186#issuecomment-1107528178
I've added a test case that demonstrates the issue.
Test case is more complex than the actual fix.
Does it mean I have to sign Apache CLA? I have not signed it yet.
The test case is
dependabot[bot] opened a new pull request, #188:
URL: https://github.com/apache/ant/pull/188
Bumps xercesImpl from 2.12.0 to 2.12.2.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xerces:xercesImpl&package-mana
dependabot[bot] opened a new pull request, #189:
URL: https://github.com/apache/ant/pull/189
Bumps xercesImpl from 2.12.0 to 2.12.2.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xerces:xercesImpl&package-mana
kleini commented on PR #186:
URL: https://github.com/apache/ant/pull/186#issuecomment-1132665670
We're having an issue, with this, too.
[tstamp] Honouring environment variable SOURCE_DATE_EPOCH which has been
set to 1651903417
Date of 12/12/1969 07:10 PM results in negative
jaikiran commented on PR #186:
URL: https://github.com/apache/ant/pull/186#issuecomment-1132923161
> I've added a test case that demonstrates the issue.
Test case is more complex than the actual fix.
Does it mean I have to sign Apache CLA? I have not signed it yet.
Hello @mizdebs
jaikiran closed pull request #186: Fix integer overflow when parsing
SOURCE_DATE_EPOCH
URL: https://github.com/apache/ant/pull/186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
jaikiran commented on PR #186:
URL: https://github.com/apache/ant/pull/186#issuecomment-1133509843
I've received confirmation that CLA is not a must. I've also tested your
changes in this PR and they look good and I've now merged it. Thank you for
this fix and the test case and apologies fo
sfllaw commented on PR #173:
URL: https://github.com/apache/ant/pull/173#issuecomment-1145242151
82f5edcf49002943773a165464e152b1d75a68a8 changed the default value of
`authenticateOnRedirect` from true to false, which is backwards incompatible
but is actually proper behaviour.
--
This is
sfllaw commented on PR #173:
URL: https://github.com/apache/ant/pull/173#issuecomment-1145284283
I encountered this bug when using `` with HTTP Basic Auth to supply a
username and password. If the server responds with a 3xx redirect to an S3
bucket, Amazon will respond with a 400 Bad Reques
bodewig merged PR #190:
URL: https://github.com/apache/ant/pull/190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
ppkarwasz opened a new pull request, #191:
URL: https://github.com/apache/ant/pull/191
Since the `` tag is not in the scope of the `` target,
fetching artifacts from repositories different from Maven
Central fails (e.g. JAI).
--
This is an automated message from the Apache Git Service.
jaikiran commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1206507678
Hello @ppkarwasz, thank you for this change. It looks OK to me, but I'm
surprised that without this change, the fetch fails for you. I tested it
locally (without this change) and our CI instan
ppkarwasz commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1206746776
Hi @jaikiran,
Thank you for the prompt answer. If the `` element is outside of
`` task, my Ant tries to retrieve the artifact from the default
repositories only (i.e. Maven Central).
ppkarwasz opened a new pull request, #192:
URL: https://github.com/apache/ant/pull/192
This PR adds a Log4j2 build listener as a modern alternative to the obsolete
Log4j 1.x listener.
The Log4j2 listener differs in some choices from the Log4j counterpart. Most
notably:
* the
bodewig commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207380896
Many thank @ppkarwasz in particular since you found all the places that need
to be touched when adding a new dependency. :-)
TBH I don't really see any reason why this should be part of t
bodewig commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1207381957
I can reproduce this locally and believe the key is to remove jai from the
local m2 repo. Maybe the CI server has stored jai there as well @jaikiran ?
--
This is an automated message from the
bodewig merged PR #191:
URL: https://github.com/apache/ant/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
bodewig commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1207382355
@ppkarwasz many thanks, what name do you want us to use when we add you to
the contributors file?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
ppkarwasz commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1207390997
@bodewig, I didn't notice I never filled up the Github profile with my real
name. You can use `Piotr P. Karwasz`.
--
This is an automated message from the Apache Git Service.
To respond to
bodewig commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1207394065
see b9272756f
Even if your name had been present I would have asked :-) . Not all people
want their name to show up in a list like ours.
--
This is an automated message from the Apache
vlsi commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207443229
I agree, it does not make sense adding dependency on log4j2.
It would be better adding a slf4j build listener.
--
This is an automated message from the Apache Git Service.
To respond to the me
ppkarwasz commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207491526
@bodewig, I understand the reluctance of adding yet another component with
external dependencies to maintain, but I believe this should be a low
maintenance listener. If you consider adding i
vlsi commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207492798
>I can help maintaining it.
Well, it would be nice to avoid dependency on log4j2 if possible since any
new CVE would trigger cases like "Ant is using vulnerable log4j"
--
This is an autom
ppkarwasz commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207497790
This would be just a marketing problem: Log4j2 Core's vulnerabilities never
affected the Log4j2 API as well as Logback's vulnerabilities never affected
SLF4J. In the case of a new CVE against
rgoers commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207497855
@vlsi What a pointless comment. ANY software can have a CVE. For the record,
the Log4j 2 API has never had any CVE's reported against it. From a
functionality point of view it is exactly the sam
jaikiran commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1207597394
> I can reproduce this locally and believe the key is to remove jai from the
local m2 repo. Maybe the CI server has stored jai there as well @jaikiran ?
That's very likely. Thank you @pp
bodewig commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207757018
I'd say the same thing about an SLF4J based logger implementation. My
reluctance to adding new dependencies for things that could be add-ons - maybe
just a separate antlib under the umbrella of
vlsi commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207773563
> My reluctance to adding new dependencies for things that could be add-ons
+1
> I'd say the same thing about an SLF4J based logger implementation
Well, at least slf4j allows pl
ppkarwasz commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207894653
> We are maintaining things we accepted more than twentytwo years ago
(`` anyone :-) ) just to give a perspective on what maintenance
involves.
@bodewig, I perfectly understand the pro
bodewig commented on PR #193:
URL: https://github.com/apache/ant/pull/193#issuecomment-1290054573
I have no idea what you are trying to do but you are certainly not at the
correct repo here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
bodewig closed pull request #193: Update defaults.properties
URL: https://github.com/apache/ant/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
keithc-ca opened a new pull request, #194:
URL: https://github.com/apache/ant/pull/194
This fixes parsing of archives produced on macOS.
See the discussion in
https://github.com/ibmruntimes/Semeru-Runtimes/issues/15.
--
This is an automated message from the Apache Git Service.
To respo
qf28 commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305727468
Hi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305954729
I should have asked my five year younger self wether I remember why the code
is what it is :-) - see https://github.com/apache/commons-compress/pull/54
I'll merge this PR right away. We'd
bodewig merged PR #194:
URL: https://github.com/apache/ant/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
keithc-ca commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305963866
Thanks for merging this.
> We'd like to credit you in CONTRIBUTORS and contributors.xml
Please use
```
Keith
W.
Campbell
```
--
This is a
bodewig closed pull request #184: Bugs are Fixed
URL: https://github.com/apache/ant/pull/184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubsc
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305971189
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
keithc-ca opened a new pull request, #195:
URL: https://github.com/apache/ant/pull/195
The existing use of `tr` doesn't distinguish between Java 8 and Java 18; see
https://github.com/apache/ant/commit/bbe6859b2f57a2c9dcb51e269527f3c18a74aa1d#commitcomment-90131350
- this fixes that.
--
T
jaikiran commented on PR #195:
URL: https://github.com/apache/ant/pull/195#issuecomment-1317878895
Thank you @keithc-ca for this change. I will run some CI test before merging
(I'll also check why my testing of my previous commit didn't catch the 1.8
version issue).
--
This is an automat
jaikiran merged PR #195:
URL: https://github.com/apache/ant/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
jaikiran commented on PR #195:
URL: https://github.com/apache/ant/pull/195#issuecomment-1318135936
> I'll also check why my testing of my previous commit didn't catch the 1.8
version issue
For the record - one of the test jobs did catch this issue for 1.8 version,
I just hadn't caugh
601 - 700 of 714 matches
Mail list logo