Re: 1.6 milestones ?

2003-03-14 Thread peter reilly
: peter reilly [mailto:[EMAIL PROTECTED] Sent: 14 March 2003 11:32 To: Ant Developers List Subject: Re: 1.6 milestones ? new features I would like in 1.6. 1) import task to import in-line at the moment, it imports at the end of the build file, thus messing up order for top

Re: Dynamic Configurator

2003-03-20 Thread peter reilly
Ant Dev with java gives an example. I used DynamicConfigurator to implement custom conditions in bugzilla bug no : 17199 I did not have the problems you describe. Peter On Thursday 20 March 2003 18:45, Brett Wooldridge wrote: Hello list, I'm trying to use DynamicConfigurator and am having

[PATCH] to enchance concat

2003-03-21 Thread peter reilly
Included is a gzipped tar file containing a patch to concat to 1) takes a path for source files 2) does optional dependency checking (sourcefiles-destfile) 3) has optional filterchains to filter the source files 4) has optional header and a footer element The file contains the patch and

Re: Artima SuiteRunner Task

2003-03-26 Thread peter reilly
I would include filters, mappers, conditions and selectors to the list. A relatively simple mod to the core ant makes this possible (bugzilla 17199) basically get ConditionBase.java, AbstractFileSet, FilterChain implement DynamicConfigurator. and get UnknownElement (bugzilla 18312) call

Re: Artima SuiteRunner Task

2003-03-27 Thread peter reilly
Costin Manolache wrote: I would include filters, mappers, conditions and selectors to the list. I would exclude them :-) Taks, types, mappers, filters, whatever are just ant components - and they shouldn't need a special syntax from user perspective. That is what I meant to say.

RE: DynamicTag

2003-04-15 Thread peter reilly
throw different * exceptions for the various error conditions: * dl * liname not found/li * liname found but no matching dynamic element method/li * /dl * At the moment the method simply returns null for these * conditions. * /p * * @author Peter Reilly */ public class

RE: DynamicTag

2003-04-16 Thread peter reilly
Dominique Devienne wrote: Interesting... So how come DynamicTag is not compatible with Ant 1.6, when it compiles and works fine with 1.5.1??? Sounds like an incompatible API change to me, which hopefully will be fixed. It compiles on Ant 1.6, but currently the unknownelement returned does not get

Re: AW: [VOTE] propertycopy

2003-04-22 Thread peter reilly
And the original author was Matthew Inger. Peter On Tuesday 22 April 2003 10:43, [EMAIL PROTECTED] wrote: I took a look at cvs log http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/ant-contrib/ant-contrib/src/ n et/sf/antcontrib/property/PropertyCopy.java The initial version was introduced by

Re: Test failures (Gump is coming to tell us anyway ...)

2003-04-22 Thread peter reilly
Hi, Your guess is nearly right, I originally used beanshell, after modifying it to use apache BSF. When submitting I modified the tests to use javascript, but missed the test to check if script is available. Cheers, Peter On Tuesday 15 April 2003 07:39, Stefan Bodewig wrote: In addition,

Re: cvs commit: ant/src/main/org/apache/tools/ant/types/selectors ExtendSelector.java

2003-04-22 Thread peter reilly
On Tuesday 15 April 2003 01:05, Conor MacNeill wrote: I have some questions about this patch On Tue, 15 Apr 2003 03:21 am, [EMAIL PROTECTED] wrote: +Project.setProjectOnObject(project, o); Why is this a static method rather than a plain method like this:

Re: antlib

2003-04-22 Thread peter reilly
A flat namespace is a bit problematic :- for example: is containsregexp a filter, condition or a selector The antlib proposal does provide associating the same name to different classes using roles. If a flat namespace is used, there is not much point in proceeding with the xml based

Re: antlib

2003-04-23 Thread peter reilly
On Wednesday 23 April 2003 17:41, Dominique Devienne wrote: Let's turn around your question: Tell me of a (string) role (beside the special task/type cases) that would not be an interface? What good a bean is, if it's not of an expected Java type? What method or field are you going to use/call

Re: antlib

2003-04-23 Thread peter reilly
On Wednesday 23 April 2003 17:57, Dominique Devienne wrote: Yes, it could be a problem. But running the risk of speaking yet another anathema, I'm starting to believe the Jelly approach of using XML namespaces is the right one... +1 Seems simple to implement and fits in with current usage.

Re: antlib

2003-04-24 Thread peter reilly
On Thursday 24 April 2003 11:47, Jose Alberto Fernandez wrote: Obviously (b) is much better. So they define their antlib as follows: antlib condition name=cpuusage classname=com.amazing.queries.CpuUsage adaptor=com.amazing.ant.ConditionAdaptor/

Re: antlib

2003-04-25 Thread peter reilly
On Friday 25 April 2003 08:31, Stefan Bodewig wrote: On Thu, 24 Apr 2003, Costin Manolache [EMAIL PROTECTED] wrote: Look - adding roles concept to ant, and adding antlib are 2 separate issues. +1 I tend to agree - that's why I proposed to get antlib into the main trunk with support for

Re: polymorphism (was Re: antlib)

2003-04-25 Thread peter reilly
On Friday 25 April 2003 10:42, Stefan Bodewig wrote: Yes, that's one way to implement it. The tricky part starts if you want to support polymorphism for more than one nested element. true. The problem exists in CVS HEAD for TokenFilter, it can take TokenFilter.Filter and TokenFilter.Tokenizer

Re: antlib

2003-04-25 Thread peter reilly
null for these * conditions. * /p * * @author Peter Reilly */ public class DynamicElementHelper { private Vector nestedDynamicMethods = new Vector(); /** * Constructor for DynamicElementHelper. * * @param clazz the class to reflect over */ public

Re: polymorphism (was Re: antlib)

2003-04-25 Thread peter reilly
On Friday 25 April 2003 14:30, Stefan Bodewig wrote: because it feels more natural? classpath ant:type=PathThatIgnoresBuildSysclassPathToTrickGump or PathThatIgnoresBuildSysclassPathToTrickGump ant:element=classpath I see. This is an interesting idea, whether is more natural is debatable

Re: polymorphism (was Re: antlib)

2003-04-25 Thread peter reilly
On Friday 25 April 2003 14:34, Stefan Bodewig wrote: On Fri, 25 Apr 2003, Jose Alberto Fernandez In simple non-ambiguos cases like the above this could be without the trick. copy ... classfileset ... /copy condition true/ /condition This is exactly what dynamicElement is for. For

Re: polymorphism (was Re: antlib)

2003-04-25 Thread peter reilly
On Friday 25 April 2003 16:45, Wannheden, Knut wrote: It'd be natural to people who've worked with XML Schema Instance documents, where you'd write something like: classpath xsi:type=my:somekindofpath/ Maybe the XML Namespace like notation of my:somekindofpath could mean that

Re: antlib

2003-04-25 Thread peter reilly
On Friday 25 April 2003 18:32, Erik Hatcher wrote: On Friday, April 25, 2003, at 01:25 PM, Costin Manolache wrote: All I ask is to do the changes in the core separately. +1 +1 I'm in agreement with you on the order of events, Costin, 100%. antlib with tasks/datatypes is fair game to

Re: Roles (was: antlib)

2003-04-28 Thread peter reilly
On Monday 28 April 2003 17:28, peter reilly wrote: An object of Cimpl gets method 3, An object of ABImpl is ambiguous and is allowed. That should be not allowed Peter

Re: NameSpace antlib was (Re: polymorphism)

2003-04-28 Thread peter reilly
On Sunday 27 April 2003 22:14, Wannheden, Knut wrote: Or even: antelope:if xmlns:antelope=antlib:${ant-contrib.jar} / That syntax abuses the purpose of XML Namespaces, IMO. Although a namespace is identified by an URI, I don't think attaching semantics to it is correct. I am no expert

Re: Roles (was: antlib)

2003-04-28 Thread peter reilly
My comments in-line: On Monday 28 April 2003 16:35, Costin Manolache wrote: To keep things simple and make it easier to get an agreement - let's let adapters out, and focus on the core issue. IMO it seems what everything leads to is the need to extend the introspection patterns with another

Re: NameSpace antlib was (Re: polymorphism)

2003-04-28 Thread peter reilly
On Monday 28 April 2003 18:41, Nicola Ken Barozzi wrote: peter reilly wrote, On 28/04/2003 19.37: On Sunday 27 April 2003 22:14, Wannheden, Knut wrote: ... but maybe the buildfile author wants/needs to specify the namespace URI (anything really), in which case an additional ns attribute

Re: Roles (was: antlib)

2003-04-28 Thread peter reilly
On Monday 28 April 2003 18:40, Jose Alberto Fernandez wrote: condition property=x and if istrue value=yes/ thenechoyes/echo/then elseechono/echo/else /if istrue value=yes/ /and /condition

Re: Roles (was: antlib)

2003-04-29 Thread peter reilly
First, I must say that it would be nice to have context dependent element names - my core example is the element name containsregexp - is this a condition, filter or selector ? , the different meaning may mean that different classes should implement them. However, I think that expressing this in

Re: NameSpace antlib was (Re: polymorphism)

2003-04-29 Thread peter reilly
Two points 1) Using /org/apache/.../anlib.xml defeats the purpose of the antlib proposal. However it is in keeping with current ant practice. it could be supported using typedef definitionresource=/org/apache/commons/modeler/ant/antlib.xml classpath path=${commons.modler/

Re: Roles (was: antlib)

2003-04-29 Thread peter reilly
On Tuesday 29 April 2003 10:46, Jose Alberto Fernandez wrote: If you don't want if to be useable as a condition - don't make it implement condition. It sounds very nice, but the reality is that if already exists and has existed for a long time. Hence we can not go and change it just because

Re: Roles (was: antlib)

2003-04-29 Thread peter reilly
On Tuesday 29 April 2003 12:49, Stefan Bodewig wrote: On Mon, 28 Apr 2003, peter reilly [EMAIL PROTECTED] wrote: 4. public void add(NestedElement anInner) 5. public void addConfigured(NestedElement anInner) Make NestedElement a FileSet and explain how you'd support accepting

Re: Roles (was: antlib)

2003-04-29 Thread peter reilly
On Tuesday 29 April 2003 13:12, Stefan Bodewig wrote: I think the learning curve for beginners to grok copy ... classfileset .../ zipfileset .../ /copy is steeper than the alternative copy ... fileset type=classfileset .../ fileset type=zipfileset .../ /copy This is

Re: Roles (was: antlib)

2003-04-29 Thread peter reilly
On Tuesday 29 April 2003 16:50, Stefan Bodewig wrote: On Tue, 29 Apr 2003, Jose Alberto Fernandez [EMAIL PROTECTED] wrote: This continues with the two-tier issue, the core conditions of ANT you can just named, but the third party ones need to use some funny syntax. core conditions would

Re: NameSpace antlib was (Re: polymorphism)

2003-04-30 Thread peter reilly
I think that agreement is very close. What about this proposal: The current types and tasks properties files may be combined into a antdef.xml file of the form: antdef taskdef name=acme classname=org.acme.Acme onerror=fail/report/ignore/ ... ... /antdef Definer

Re: Roles (was: antlib)

2003-04-30 Thread peter reilly
On Wednesday 30 April 2003 17:54, Costin Manolache wrote: Stefan Bodewig wrote: On Tue, 29 Apr 2003, peter reilly [EMAIL PROTECTED] wrote: We are still left the problem of the Type createName() pattern. I don't think that it was solvable. Almost any soltion world require cooperation

Re: Roles (was: antlib)

2003-05-01 Thread peter reilly
On Wednesday 30 April 2003 18:17, Costin Manolache wrote: All the discussions so far were about adding an addSomething() - while leaving all existing use cases unmodified. Stefan introduced the concept of a typedef attribute, which allows the ant core code to substitute a different class (named

Re: NameSpace antlib was (Re: polymorphism)

2003-05-01 Thread peter reilly
On Wednesday 30 April 2003 18:28, Costin Manolache wrote: peter reilly wrote: I think that agreement is very close. What about this proposal: The current types and tasks properties files may be combined into a antdef.xml file of the form: antdef taskdef name=acme classname

Re: Roles (was: antlib)

2003-05-01 Thread peter reilly
19446 over the weekend with the changes. Peter. On Thursday 01 May 2003 09:24, peter reilly wrote: On Wednesday 30 April 2003 18:17, Costin Manolache wrote: All the discussions so far were about adding an addSomething() - while leaving all existing use cases unmodified. Stefan introduced

Re: Roles (was: antlib)

2003-05-02 Thread peter reilly
I have done a little further work on my patch to allow nested elements to have Project type as a constructor. If the object contains both addElement() and createElement(), the addElement() method is used. example: typedef myfileset mypath anttest etc .. copy todir=output fileset

Re: Namespaces in Ant

2003-05-06 Thread peter reilly
On Monday 05 May 2003 20:20, J.Pietschmann wrote: peter reilly wrote: I would agree with most of what Nicola says. I think that XML ns is a heavy solution for name clashing of names defined in a antlib. Moreover I do not think that the antlib needs to define a qualified name. The prefix

Re: AW: command line option visibility within a task ..

2003-05-06 Thread peter reilly
On Tuesday 06 May 2003 17:39, [EMAIL PROTECTED] wrote: BTW You´re using the old email adress [EMAIL PROTECTED] The new one is [EMAIL PROTECTED] that is [EMAIL PROTECTED] Peter

Re: Roles (was: antlib)

2003-05-12 Thread peter reilly
On Friday 09 May 2003 04:08, Costin Manolache wrote: peter reilly wrote: Using property files is nice but with new attributes to typedef (adaptor for example) it would be better to use an xml file/resource. I think we already agreed on XML - there is no reason to continue adding

Re: FW: Retrieve all the nodes in an XML file using xmlproperty

2003-05-12 Thread peter reilly
/xmlproperties/classes [mkdir] Created dir: /home/preilly/proj/learning/xmlproperties/classes [echo] MyModule.java,MyModule1.java [javac] Compiling 2 source files to /home/preilly/proj/learning/xmlproperties/classes Cheers, Peter -Original Message- From: peter reilly [mailto

Re: FW: Retrieve all the nodes in an XML file using xmlproperty

2003-05-12 Thread peter reilly
I was afraid you may say this ;-) The .java is added to the end of the property value of ${suite.testcases.filename} not to each of the components of the string. You will need to do something like xsl to convert the input xml. something like: suite

Re: antlib / proposal of Peter Reilly

2003-05-14 Thread peter reilly
be glad to hear your comments concerning : 1) the functionality provided by the contribution 2) the implementation I am quoting Peter Reilly here : This patch adds 4 new features (the code is interrelated, but may be split). * adapter attribute added to typedef * add(Type) method added

Re: antlib / proposal of Peter Reilly

2003-05-14 Thread peter reilly
on the need for roles and separate symbol-tables for different Types. Roles/separate symbol-tables could be dealt with later. I would like for someone to explain how ejbjar, jspc, serverdeploy can have vendor dependent weblogic, jboss, etc. within this model. I am quoting Peter Reilly here

Re: antlib / proposal of Peter Reilly

2003-05-14 Thread peter reilly
On Wednesday 14 May 2003 13:23, Conor MacNeill wrote: ant-type polymorphism is not a priority for me, Pity - it solves most extensibility problems :-). Hi Conor, et al I have merged the ant-type code into my antlib code. However it uses a magic attribute name ant-type to achieve the effect

Re: antlib / proposal of Peter Reilly

2003-05-15 Thread peter reilly
On Thursday 15 May 2003 07:56, Conor MacNeill wrote: On Thu, 15 May 2003 12:56 am, peter reilly wrote: I have merged the ant-type code into my antlib code. However it uses a magic attribute name ant-type to achieve the effect and not as discussed before - the namesspaced attribute name

Re: antlib / proposal of Peter Reilly

2003-05-19 Thread peter reilly
. peter reilly wrote: On Thursday 15 May 2003 07:56, Conor MacNeill wrote: I would prefer to use the XML schema attribute for this. Mmmm, this would be confusing as the XML schema attribute has an associated URI http://www.w3.org/2001/XMLSchema; which implies a lot more

Re: antlib / proposal of Peter Reilly

2003-05-19 Thread peter reilly
On Saturday 17 May 2003 20:13, Costin Manolache wrote: peter reilly wrote: for example: typedef resource=org/acme/mydefinitions.xml classpath=classes/ to allow loading of tasks/types from different 3rd party with some tasks haveing the same name, I have added a prefix attribute

Re: antlib / proposal of Peter Reilly

2003-05-19 Thread peter reilly
. I was thinking maybe we do not need to look further and we could commit this contribution ? I would be glad to hear your comments concerning : 1) the functionality provided by the contribution 2) the implementation I am quoting Peter Reilly here : This patch adds 4 new features

Re: antlib / proposal of Peter Reilly

2003-05-19 Thread peter reilly
On Monday 19 May 2003 11:50, Wannheden, Knut wrote: Peter, acme:hellp xmlns:acme=NSURI This would allow arbitrary NSURIs ( for people who like meaning-free URIs) and allow the classpath association. I do not want meaning-free URIs. I want ant to ignore URIs that it

Re: antlib / proposal of Peter Reilly

2003-05-19 Thread peter reilly
/Target be done by PH2#ElementHandler? I think one should be able to plug in handlers for different URIs, or URI patterns. My UnknownUriHandler is an (possibly not very good) example. On Monday 19 May 2003 15:33, Jose Alberto Fernandez wrote: From: peter reilly [mailto:[EMAIL PROTECTED

Re: Free-form ANT Task Structure

2003-05-20 Thread peter reilly
To embed the config information, the easiest is to map the info to objects. Ant introspection is very powerfull and easy to use for normal java data object. Alternatively one can use the DynamicConfigurator interface. This provides the name of the unknown element and the name/value of unknown

Re: antlib / proposal of Peter Reilly

2003-05-21 Thread peter reilly
On Wednesday 21 May 2003 08:21, Stefan Bodewig wrote: On Mon, 19 May 2003, peter reilly [EMAIL PROTECTED] wrote: 1) are build script authors allowed to specify arbitary URIs for ant type definitions? I do not think this is a good idea. I've seen that Costin and Conor prefer

Re: Free-form ANT Task Structure

2003-05-21 Thread peter reilly
Loritsch wrote: peter reilly wrote: To embed the config information, the easiest is to map the info to objects. Ant introspection is very powerfull and easy to use for normal java data object. The problem is that it only works when you know in advance what the configuration elements

Re: antlib / proposal of Peter Reilly

2003-05-22 Thread peter reilly
On Thursday 22 May 2003 10:29, Stefan Bodewig wrote: On Thu, 22 May 2003, peter reilly [EMAIL PROTECTED] wrote: Ok I will chop it up into a sequence of patches. Thanks. The first patch adds the add(Type) introspection method and implements this in condition, filterchain, tokenfilter

add(Type) submit

2003-05-28 Thread peter reilly
I am thinking of commiting patch number 6453 from http://issues.apache.org/bugzilla/show_bug.cgi?id=19897 This adds the add(Type) introspection rule and implements it in condition, filterchain and selectors. I have had a couple of +1s to the patch but would like to confirm this before

Re: copy task addition

2003-05-28 Thread peter reilly
I do not think this is a good idea. It will add @property@ to ${property} as a way for dealing with properties. This could be a custom filter or nearly the same behaviour could be achieved by using replaceregex and expandproperties: filterchain replaceregex pattern=@([EMAIL

Re: Advice required on committing

2003-05-28 Thread peter reilly
: peter reilly [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, May 28, 2003 6:57 AM Subject: Advice required on committing Hi, I have just been made a ant committer. I have found a bug in ant's regular expession handling for replacing matched groups. Ant uses \n to identify

[VOTE] Re: add(Type) submit

2003-05-28 Thread peter reilly
I am thinking of commiting patch number 6453 from http://issues.apache.org/bugzilla/show_bug.cgi?id=19897 This adds the add(Type) introspection rule and implements it in condition, filterchain and selectors. On Wednesday 28 May 2003 12:30, Magesh Umasankar wrote: P.S. Please prefix mark the

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/junit FormatterElement.java JUnitTask.java

2003-05-28 Thread peter reilly
On Wednesday 28 May 2003 15:04, Conor MacNeill wrote: On Wed, 28 May 2003 11:27 pm, Erik Hatcher wrote: If folks feel strongly about it, I'll revert it. I'm not into strong feelings :-). Let's see what people think. +1 to keep the if attribute I use this all the time with cc: compiler

Re: cvs commit: ant/xdocs contributors.xml

2003-05-28 Thread peter reilly
On Wednesday 28 May 2003 15:21, [EMAIL PROTECTED] wrote: bodewig 2003/05/28 07:21:05 Modified:docs contributors.html xdocscontributors.xml Log: This is supposed to be sorted ;-) Opps. Peter

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/junit FormatterElement.java JUnitTask.java

2003-05-28 Thread peter reilly
I would rather use the C logic for this. Unless the value is explicity false/off/no or , the value is treated as true. This would break less scripts. But it is still not bc and third party tasks would also need to be changed to follow the new behaviour. Peter. On Wednesday 28 May 2003 17:37,

Re: PROPOSE:optional nested filelist for available task

2003-06-03 Thread peter reilly
/ /targetfiles /outofdate echo message=${no.need.to.create}/ /target Peter On Friday 30 May 2003 23:17, Dominique Devienne wrote: I myself like quite a bit the outofdate task from Ant-Contrib by Peter Reilly... Also does away with Ant's pour if/unless conditions on targets to directly execute

Re: patch for namespaced antlib

2003-06-04 Thread peter reilly
Hi Antoine, Thanks for your detailed comments. On Tuesday 03 June 2003 20:26, you wrote: - Original Message - From: peter reilly [EMAIL PROTECTED] To: Antoine Levy-Lambert [EMAIL PROTECTED] Sent: Tuesday, June 03, 2003 2:01 PM TypeAdapter behaves in the same way as the current

Re: patch for namespaced antlib

2003-06-04 Thread peter reilly
On Wednesday 04 June 2003 10:48, Antoine Levy-Lambert wrote: Peter, thanks for your work. Your explanations concerning the scope of different flavours of typedef declarations are important, make sure that they make their way in the documentation. Ah yes documentation. Peter

Re: cvs commit: ant/docs ant_task_guidelines.html

2003-06-04 Thread peter reilly
pretty awesome. Peter On Wednesday 04 June 2003 13:18, [EMAIL PROTECTED] wrote: umagesh 2003/06/04 05:18:55 Modified:docs ant_task_guidelines.html Added: .patch.xml Log: Suggest using Ant to generate a patch file for Ant. Revision ChangesPath

Re: Error in [if]-task

2003-06-05 Thread peter reilly
I see the problem. It is in the TaskAdapter, if the adapted task throws a build exception, this is logged at error level. Method executeM = null; try { Class c = proxy.getClass(); executeM = c.getMethod(execute, new Class[0]); if (executeM ==

Fwd: Re: Embedded dynamic ANT tasks.

2003-06-06 Thread peter reilly
Hi Dawid, You may consider having a parallel set of code for bsh CVS head as some of the bsh apis have changed since 1.2.x Peter. On Friday 06 June 2003 15:53, Dawid Weiss wrote: Dear ANT community, I thought one day: maybe it would be fun if I could define ANT tasks INSIDE the ANT

Re: scriptdef

2003-06-09 Thread peter reilly
Sounds cool. Peter. On Monday 09 June 2003 14:58, Conor MacNeill wrote: Hi all, I've just added a scriptdef task to allow tasks to be created using scripts. It's loosely based on something I wrote a while back for Mutant. Attached below is an example usage. I had to make a few small mods to

Re: Ant scripting from Jython.

2003-06-13 Thread peter reilly
jython does support named parameters, one can do some bizarre stuff: script language=jython from java.io import File def twrapper(taskname, **args): t = project.createTask(taskname) for a in args.keys(): exec(t.%s = %s % (a, args[a])) t.execute() twrapper('echo', message='hello

Re: Ant scripting from Jython.

2003-06-16 Thread peter reilly
, dir=File('todir')) twrapper('mkdir', dir=File(todir)) twrapper('copy', file=File(fromfile), todir=File(todir)) -Original Message- From: peter reilly [mailto:[EMAIL PROTECTED] Sent: Friday, June 13, 2003 4:59 AM To: Ant Developers List Subject: Re: Ant scripting from

Re: Using classloader for Junit

2003-06-19 Thread peter reilly
Check the ant faq http://ant.apache.org/faq.html#delegating-classloader In essence you need to place the junit.jar file in ${ant.home}/lib Cheers, Peter On Thu, 2003-06-19 at 08:43, Nick Chalko wrote: ?xml version=1.0 ? project default=test name=junit.antlib path id=ant.deps

Re: Using classloader for Junit

2003-06-19 Thread peter reilly
Ah, I see. That would be nice, but the classloader task is not yet complete. Peter On Thu, 2003-06-19 at 08:52, Nick Chalko wrote: peter reilly wrote: Check the ant faq http://ant.apache.org/faq.html#delegating-classloader In essence you need to place the junit.jar file in ${ant.home}/lib

Re: FixCRLF as a FilterChain

2003-06-19 Thread peter reilly
Please do! On Thu, 2003-06-19 at 14:13, Denis N.Antonioli wrote: Hi Is there any plan to offer a FilterChain for FixCRLF? I could use this in my present project... and have nothing against contributing it ;-) Greetings dna

Re: FileUtils#createTempFile : what about using java.io.tmpdir as a default there ?

2003-06-20 Thread peter reilly
I think java.io.tmpdir is not used because it is not in java 1.1. As Ant does not support 1.1 (except to generated 1.1 classes), use should probably be made of java.io.File#createTempFile(). Peter. On Thu, 2003-06-19 at 23:32, Antoine Levy-Lambert wrote: One user complained that FixCrLf

Re: Using classloader for Junit

2003-06-20 Thread peter reilly
. The code that instantiate the tasks needs to have a reference to the child loader, and I don't think core tasks have dependencies on the classes in the optional. peter reilly wrote: Ah, I see. That would be nice, but the classloader task is not yet complete. Hi Costin, looking

Re: Having a user task at the project level ..

2003-06-24 Thread peter reilly
You need to wait for ant 1.6 or use a nightly build. Peter On Mon, 2003-06-23 at 18:23, Harsha Kalidindi wrote: Hi: I am using Ant 1.5.3. I have few custom tasks. Can I have any of them be configured to be valid at the project level? Right now, I cannot seem to specify

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs ZipTest.java

2003-06-25 Thread peter reilly
Well done! On Tue, 2003-06-24 at 21:25, [EMAIL PROTECTED] wrote: antoine 2003/06/24 13:25:58 Modified:src/testcases/org/apache/tools/ant/taskdefs ZipTest.java Log: An error was happening under Windows when executing the cleanup, test3.zip could not be deleted. This is

Re: linux test failures

2003-06-25 Thread peter reilly
Hi Steve, do you have a HEAD copy of Jdk14RegexpRegexp. I made a bug fix to that recently - I put in the dollar test to test it. (bug report 20306). Peter. On Wed, 2003-06-25 at 01:30, Steve Loughran wrote: running on redhat 9.0, [SMP] and I'm seeing a regexp failure on Sun's SDK:

Re: [VOTE] Jan Materne as committer

2003-06-25 Thread peter reilly
+1 especially if he can get a proper cvs connection ;-) On Wed, 2003-06-25 at 11:06, Conor MacNeill wrote: I'd like to propose Jan Materne as an Ant committer. I think his contribution in recent months has been quite obvious both on the dev and user lists and also the bug reports. I think he

[PATCH - VOTE] antlib patch #2 - unification of type and task

2003-06-25 Thread peter reilly
I am about to commit the second of the patches for the antlib update - http://issues.apache.org/bugzilla/show_bug.cgi?id=19897 patch - 6762. If anyone has objections please veto. Peter - To unsubscribe, e-mail: [EMAIL

Re: Ant 1.6 todo thoughts

2003-06-26 Thread peter reilly
Ok: 1) polymorphism 2) loading of antlib.xml files/resource 3) namespace 4) roles Peter On Wed, 2003-06-25 at 10:25, Stefan Bodewig wrote: On 25 Jun 2003, peter reilly [EMAIL PROTECTED] wrote: The roadmap could be: 1) roles (allowing the typedef definition to be optionally

Re: [PATCH - VOTE] antlib patch #2 - unification of type and task

2003-06-26 Thread peter reilly
Opps, Sorry, the patch has been outstanding for weeks (since 2003-05-29) and I wanted to move to the next step. Peter. On Thu, 2003-06-26 at 14:26, Stefan Bodewig wrote: On 25 Jun 2003, peter reilly [EMAIL PROTECTED] wrote: If anyone has objections please veto. Nit picking, I know

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs TypeAdapterTest.java

2003-06-26 Thread peter reilly
Yep, I realize that getTaskDefinitions returns an empty table and that this behaviour is not backward compatible. The problem is that as tasks are now types, the getTypeDefinitions() should now return everything. Current code that use getTaskDefinitions also need to to call getTypeDefinitions()

Re: [Fwd: [GUMP] Build Failure - Axis]

2003-06-27 Thread peter reilly
I can see the problem here. Previously property/ was a special task that was created differently from the other tasks (it was created in Ant#init()). I had removed this, and made it a normal task but missed the usage from Ant#reinit (and perhaps other places). I have not been able to write a

Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread peter reilly
Yep it works with CVS versions, but the latest released versions of both do not work together. bsf 2.3.0 rc1 and Rhino 1.5R4 or Rhino 1.5R41 gives the error: java.lang.NoSuchMethodError: org.mozilla.javascript.Context.getDebuggableEngine()Lorg/mozilla/javascript/debug/DebuggableEngine; Peter On

Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread peter reilly
The only thing thats needs to be done is that the ant manual for 1.6 should be correct. The contents of the manual would indicate the versions that do work - this will depend on when ant 1.6 is released ;-) and when newer versions of BSF are released. Peter On Mon, 2003-06-30 at 12:17, Stefan

Re: Checkstyle Audit

2003-07-03 Thread peter reilly
Excellent work. I have a problem with three rules: major: The DesignForExtensionCheck seems a bit silly. minor: The LeftCurlyCheck is against my in-house rule that if there is a multi line condition, the { should be on a separate line - but I can live the rule. minor:

Re: Checkstyle Audit

2003-07-03 Thread peter reilly
I know ... Ah well, Peter On Thu, 2003-07-03 at 16:30, Stefan Bodewig wrote: On 03 Jul 2003, peter reilly [EMAIL PROTECTED] wrote: minor: The LeftCurlyCheck is against my in-house rule that if there is a multi line condition, the { should be on a separate line

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java

2003-07-04 Thread peter reilly
Yep, However it is not used at the moment, and it got placed in by accident in the first place. Peter On Fri, 2003-07-04 at 10:01, Stefan Bodewig wrote: This also remove the format attribute, won't we need that for XML style task definitions to come? Stefan

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
On Fri, 2003-07-04 at 11:23, Conor MacNeill wrote: On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote: Hi Conor, actually, it might be even better if the pages were generated by a cron job running daily, or even better, if a kind of cvs commit daemon would regenerate the pages

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
I just downloaded mozilla 1.4, and the tooltips work fine on Linux. Peter On Fri, 2003-07-04 at 11:51, Stefan Bodewig wrote: On Fri, 4 Jul 2003, Conor MacNeill [EMAIL PROTECTED] wrote: Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in an anchor with no href. It seems

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
I am surprised you do not see the tooltips The mozilla page http://www.mozilla.org/docs/web-developer/faq.html makes a little song and dance over suporting tooltips for the title attribute. Peter On Fri, 2003-07-04 at 12:50, Stefan Bodewig wrote: On Fri, 4 Jul 2003, Conor MacNeill [EMAIL

Re: Test Failures

2003-07-04 Thread peter reilly
I think this is due to a change of using an iterator instead of a enumerator. The test code in question was inserting tasks into the current target, and this does not seem to be a good idea. I moved the place where the task is being placed to another target and the test passes. Peter Conor

Re: Test Failures

2003-07-07 Thread peter reilly
the way the task list of a target is visitied. Peter. On Mon, 2003-07-07 at 08:37, Stefan Bodewig wrote: On 04 Jul 2003, peter reilly [EMAIL PROTECTED] wrote: The test code in question was inserting tasks into the current target, and this does not seem to be a good idea. In general

[Patch] keep-alive feature

2003-07-07 Thread peter reilly
I am thinking of committing the keep-alive feature: http://issues.apache.org/bugzilla/show_bug.cgi?id=21144 Do any of the ant commiters have a problem with this feature? Peter - To unsubscribe, e-mail: [EMAIL PROTECTED] For

Re: [Patch] keep-alive feature

2003-07-07 Thread peter reilly
On Mon, 2003-07-07 at 18:12, Steve Loughran wrote: peter reilly wrote: I am thinking of committing the keep-alive feature: http://issues.apache.org/bugzilla/show_bug.cgi?id=21144 Do any of the ant commiters have a problem with this feature? I am mostly neutral. I can see its

Re: Test Failures

2003-07-08 Thread peter reilly
On Mon, 2003-07-07 at 09:37, Stefan Bodewig wrote: On 07 Jul 2003, peter reilly [EMAIL PROTECTED] wrote: I am not sure that that depending on an undocumented (I think) feature of Vector/Enumeration is a good idea. I agree, though it is sort-of documented in Vector's javadocs (the class

Re: Test Failures

2003-07-08 Thread peter reilly
On Tue, 2003-07-08 at 13:19, Stefan Bodewig wrote: On 08 Jul 2003, peter reilly [EMAIL PROTECTED] wrote: On Mon, 2003-07-07 at 09:37, Stefan Bodewig wrote: So if we agreed that it is OK to add/remove tasks to the target currently being executed, we simply needed to provide a better

  1   2   3   4   5   6   7   8   9   10   >