Github user jsuereth commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/6#discussion_r37987168
--- Diff:
src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java ---
@@ -306,6 +306,15 @@ private void
Github user jsuereth commented on the pull request:
https://github.com/apache/ant-ivy/pull/6#issuecomment-135037966
One naming comment, then LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jsuereth commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/6#discussion_r37987042
--- Diff:
src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorParser.java ---
@@ -306,6 +306,15 @@ private void
Github user jsuereth commented on the pull request:
https://github.com/apache/ant-ivy/pull/7#issuecomment-125626169
FYI - We ran this on sbt/ivy and it looks great! I backported to Ivy 2.3
and it'll be available to sbt users shortly. Great work on teh fix! Also,
nice catch
