[GitHub] ant issue #39: [1.9.x branch] BZ-58589 Preserve last modified time (if asked...
Github user nlalevee commented on the issue: https://github.com/apache/ant/pull/39 LGTM +1 for merge --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/59 Yep, I fixed the configuration, I tried to launch a rebuild for this PR, but it seems that rebuild on Jenkins doesn't take into account the PR, so I aborted it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #57: fix last inconsistencies in generics
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/57 @twogee, you have looked into the open sources softwares that use Ivy, but Ivy is under the ASL, not the GPL, it might be used in some closed, commercial products :) So we cannot know for sure that we won't break softwares by changing that part of the API. The hierarchy of the classes of the DependencyResolver is not of the best design, it would have been great to have more composition than inheritance. But that's we have. So unless we want to break things, rewrite things and make an Ivy3, I think we should stick with it. To move forward, I suggest that this PR doesn't break the API at all. And if you still think DependencyResolver deserve a probably-safe API break, you're welcomed to discuss it on ant-dev so we can get a consensus. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23071422 Probably. And rather than asking for it, it is often better to suggest a patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivyde issue #6: IvyDE credentials documentation added and cleanup done
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivyde/pull/6 Merged. The feature is now in master and will be available with the next release. Thank you very much Alexander! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #50: Check spelling, fix whitespace and links
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/50 I have messed up a little bit the merge, I have merged the wrong branch, but in the end everything is now merged, so we are now OK. Thanks for the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #36: Replace emma with jacoco
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/36 The build-release.xml seems to be largely modified because of some space at the end of xml tags. Could we avoid that ? It is painful to review and seems useless. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #33: More code cleanup
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/33 In french we have "ssi" which is a contraction of "si et seulement si" which has a mathematical meaning about absolute equivalence between two propositions. I bet that in english "iff" means then "if and only if". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #32: A few loose bits in JUnit 4 migration
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/32 The job was configure to use the default Ant, which I don't know which is exactly. So I have changed the conf to use Ant 1.9.9 (the same version that the one declared in the ivy.xml of Ivy). A new build is coming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/31 @twogee to properly add you to the list of contributors, do you confirm you are Gintautas Grigelionis ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #20: Fix IVY-1522
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/20 merged. Thank both of you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #30: Fix transient test failures
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/30 I don't find the fix fully satisfying because it doesn't address the fragile static set of circularDependencyId, it might produce some side effect errors in the future. At least we should keep it mind that this is a weak spot in the code. Nevertheless this patch nicely address the issue at hand so I merged it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #22: Fix transient test failures
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/22 after many runs on my machine, I think I have found the actual issue. If testRemoveDuplicates is run after testRemoveDuplicates2, then it fails. It seems due to the fact that WarnCircularDependencyStrategy is a singleton and that circularDependencies in AbstractLogCircularDependencyStrategy is thus not reinitialized. Not sure yet what the proper fix should be. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #20: Fix IVY-1522
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/20 So let's get out of scope of this PR the support of weird characters in version, organisation or module name. Especially since the set of supported characters depends on the filesystem, which is usually tied to an OS but is not a strictly good indicator. So @jaikiran, would you consider rewrite the unit test to just test FileUtil.dissect ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #20: Fix IVY-1522
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/20 I agree with you both. Ivy has never specified a version scheme, and it is kind of its strength, it can be compatible with a lot of use case. We should continue to do so. But we shouldn't mess with the filesystem either, we should support at least the 3 main OS: Linux, Windows and OSX. So a correct fix for this issue might be harder. Like there is an URLEncoder, Ivy should probably have a FileNameEncoder which will be able to write any file names and read them back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #20: Fix IVY-1522
Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/20 I have increased the timeout to 20m --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174610 It seems to break badly Ivy on Windows. I tried to launch the test with a fresh checkout of your PR, and Ivy could not even resolve dependencies. Here are the logs: ``` BUILD FAILED C:\Users\nlalevee\dev\ivy\git\build.xml:184: impossible to resolve dependencies: java.io.FileNotFoundException: \:\Users\nlalevee\.ivy2\cache\resolved-org.apache.ivy-ivy-work...@hibpro7.xml (La syntaxe du nom de fichier, de râpertoire ou de volume est incorrecte) at java.io.FileOutputStream.open0(Native Method) at java.io.FileOutputStream.open(FileOutputStream.java:270) at java.io.FileOutputStream.init(FileOutputStream.java:213) at java.io.FileOutputStream.init(FileOutputStream.java:162) at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorUpdater.update(XmlModuleDescriptorUpdater.java:135) at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorParser.toIvyFile(XmlModuleDescriptorParser.java:160) at org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor.toIvyFile(DefaultModuleDescriptor.java:552) at org.apache.ivy.core.cache.DefaultResolutionCacheManager.saveResolvedModuleDescriptor(DefaultResolutionCacheManager.java:176) at org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:243) at org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:195) at org.apache.ivy.Ivy.resolve(Ivy.java:509) at org.apache.ivy.ant.IvyResolve.doExecute(IvyResolve.java:325) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272) at org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:228) at org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179) at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88) at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:435) at org.apache.tools.ant.Target.performTasks(Target.java:456) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) at org.apache.tools.ant.Project.executeTarget(Project.java:1376) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1260) at org.apache.tools.ant.Main.runBuild(Main.java:853) at org.apache.tools.ant.Main.startAnt(Main.java:235) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: Add feature for PomModuleDescriptorParser di...
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/6#issuecomment-136152918 I have implemented it with two properties, ivy.maven.sources.lookup and ivy.maven.javadoc.lookup, which defaults to true Thanks for the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-136139712 Merged. Thank you for the pull request. Sorry for the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: Lets ssh-based resolvers use an ~/.ssh/confi...
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/3#issuecomment-69492990 merged. Thanks for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request: The default subject is `bintray`, not 'jcent...
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/pull/5#issuecomment-69492417 merged. Thanks ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
