[GitHub] ant issue #21: JDK9 command line options updated to JEP 293

2016-09-09 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/21 Thank you Stefan. I've overlooked one place with the old option, so I've created a new pull request #22 to fix this problem. I've also added a patch for 1.9.x branch into #22. --- If your

[GitHub] ant issue #22: Fixed forgotten -upgrademodulepath in the DefaultCompilerAdap...

2016-09-09 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/22 The patch for Ant 1.9.x branch containing relevant changes from pull request #21 and #22. [ant_1.9.x.txt](https://github.com/apache/ant/files/464590/ant_1.9.x.txt) --- If your project is set up

[GitHub] ant pull request #22: Fixed forgotten -upgrademodulepath in the DefaultCompi...

2016-09-09 Thread tzezula
GitHub user tzezula opened a pull request: https://github.com/apache/ant/pull/22 Fixed forgotten -upgrademodulepath in the DefaultCompilerAdapter - follow pull request #21 In the #21 I've overlooked one "-upgrademodulepath" in the DefaultCompilerAdapter.

[GitHub] ant pull request #21: JDK9 command line options updated to JEP 293

2016-09-09 Thread tzezula
GitHub user tzezula opened a pull request: https://github.com/apache/ant/pull/21 JDK9 command line options updated to JEP 293 The JDK9 command line options updated to [JEP-293](http://openjdk.java.net/jeps/293) - Guidelines for JDK Command-Line Tool Options. Options introduced

[GitHub] ant issue #18: JDK9 modules support for JUnitTask

2016-07-14 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/18 Thanks a lot Stefan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant issue #18: JDK9 modules support for JUnitTask

2016-07-13 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/18 Should be rebased. Let me know in case of any problems. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] ant issue #18: JDK9 modules support for JUnitTask

2016-07-13 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/18 OK, I will rebase to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] ant issue #18: JDK9 modules support for JUnitTask

2016-07-12 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/18 I also improved the black-box test example in JUnit manual. The `addExport` to `ALL-UNNAMED` module containing the Ant is needed when Ant's test runner tries to invoke method on the test class

[GitHub] ant issue #18: JDK9 modules support for JUnitTask

2016-07-12 Thread tzezula
Github user tzezula commented on the issue: https://github.com/apache/ant/pull/18 Sorry I've overlooked the comment. Regarding the JUnit lookup. When the JUnit is not found on the classpath it's searched on the modulepath. In fact the module path is used for 2 things here

[GitHub] ant pull request: JDK9 modules support for JUnitTask

2016-04-27 Thread tzezula
Github user tzezula commented on the pull request: https://github.com/apache/ant/pull/18#issuecomment-215201380 I've forwarded the pull request to jigsaw-dev mailing list for comments. http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-April/007515.html --- If your project

[GitHub] ant pull request: JDK9 modules support for JUnitTask

2016-04-21 Thread tzezula
GitHub user tzezula opened a pull request: https://github.com/apache/ant/pull/18 JDK9 modules support for JUnitTask Changes: 1. Added modulepath and upgrademodulepath elements. 2. When modulepath or upgrademodulepath is given VM fork is required. 3. JUnit library

[GitHub] ant pull request: The JDK 9 module system support for the Javac Ta...

2016-04-01 Thread tzezula
Github user tzezula commented on a diff in the pull request: https://github.com/apache/ant/pull/16#discussion_r58201438 --- Diff: src/tests/junit/org/apache/tools/ant/taskdefs/JavacTest.java --- @@ -244,4 +248,85 @@ public void testTargetOverridesDefault

[GitHub] ant pull request: The JDK 9 module system support for the Javac Ta...

2016-03-21 Thread tzezula
Github user tzezula commented on the pull request: https://github.com/apache/ant/pull/16#issuecomment-199305236 Yes. Unfortunately the javac `-modulesourcepath` option for the multi module compilation is more complex than existing path arguments. It's described in [JEP 261: Module

[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...

2016-03-13 Thread tzezula
Github user tzezula commented on the pull request: https://github.com/apache/ant/pull/15#issuecomment-195935714 Thanks a lot Stefan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] ant pull request: The JDK 9 module system support for the Javac Ta...

2016-03-11 Thread tzezula
GitHub user tzezula opened a pull request: https://github.com/apache/ant/pull/16 The JDK 9 module system support for the Javac Task Added a support for jigsaw modulepath, upgrademodulepath and modulesourcepath to Javac task. Both single module and multi module compilation

[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...

2016-03-08 Thread tzezula
Github user tzezula commented on the pull request: https://github.com/apache/ant/pull/15#issuecomment-193997234 Hi Stefan Here is a patch for the Java task page inside of Ant's manual. I've also updated the since tags to 1.9.7: https://github.com/tzezula/ant/commit

[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...

2016-03-06 Thread tzezula
Github user tzezula commented on the pull request: https://github.com/apache/ant/pull/15#issuecomment-192894935 Sorry for that. I will get some Windows box for testing. Yes, it's '/'. The -m option support eitheror /. --- If your project is set up for it, you can reply

[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...

2016-03-06 Thread tzezula
Github user tzezula commented on the pull request: https://github.com/apache/ant/pull/15#issuecomment-192890123 Thanks Stefan, I will do a patch of Ant's java task manual. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant pull request: Added JDK 9 module system support to the Java Ta...

2016-03-03 Thread tzezula
GitHub user tzezula opened a pull request: https://github.com/apache/ant/pull/15 Added JDK 9 module system support to the Java Task Added main module, modulepath and moduleupgradepath into Java task. You can merge this pull request into a Git repository by running: $ git pull