Github user asfgit closed the pull request at:
https://github.com/apache/ant-ivy/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129757849
--- Diff:
src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java
---
@@ -85,14 +85,12 @@ public LatestCompatibleConflictManager(Stri
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129668076
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -71,132 +71,139 @@
--- End diff --
Here's a "diff -wc"-style di
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129663139
--- Diff:
src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java
---
@@ -85,14 +85,12 @@ public LatestCompatibleConflictManager(String
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129660986
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -71,132 +71,139 @@
--- End diff --
It's a change from if ... el
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129587968
--- Diff:
src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java
---
@@ -85,14 +85,12 @@ public LatestCompatibleConflictManager(Stri
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant-ivy/pull/53#discussion_r129593699
--- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
@@ -71,132 +71,139 @@
--- End diff --
This file has a large chan
GitHub user twogee opened a pull request:
https://github.com/apache/ant-ivy/pull/53
Suppressed warnings
As described in previous PR, all compiler warnings are annotated.
This PR removes a few of them, along with some refactoring.
Changes are grouped in separate commits which
